Skip to contentSkip to conversation

usertools/cpu_layout: fix code to be pep8 style compliant

PATCH Applied Ciara Power 2 participants 2 messages Nov 6, 2020 – Nov 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usertools/cpu_layout: fix code to be pep8 style compliant

The pycodestyle tool flagged the following issues, which are now fixed.

$ pycodestyle cpu_layout.py
  cpu_layout.py:18:5: E722 do not use bare 'except'
  cpu_layout.py:62:14: E231 missing whitespace after ','
Fixes deb87e6777c0 ("usertools: use sysfs for CPU layout")
Fixes c9208f1dc967 ("usertools: fix CPU layout with python 3")
---
 usertools/cpu_layout.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
usertools/cpu_layout.py +1 -3
index cc39638213..891b9238fa 100755
@@ -15,8 +15,6 @@
         fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
     except IOError:
         continue
-    except:
-        break
     core = int(fd.read())
     fd.close()
     fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
@@ -59,7 +57,7 @@
 for c in cores:
     output = "Core %s" % str(c).ljust(max_core_id_len)
     for s in sockets:
-        if (s,c) in core_map:
+        if (s, c) in core_map:
             output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
         else:
             output += " " * (max_core_map_len + 1)
Signature · 1 line
2.25.1
#1 lore raw

06/11/2020 13:40, Ciara Power:

Quoted 6 lines

The pycodestyle tool flagged the following issues, which are now fixed.

$ pycodestyle cpu_layout.py
  cpu_layout.py:18:5: E722 do not use bare 'except'
  cpu_layout.py:62:14: E231 missing whitespace after ','
Quoted 7 lines
Fixes deb87e6777c0 ("usertools: use sysfs for CPU layout")
Fixes c9208f1dc967 ("usertools: fix CPU layout with python 3")

Applied, thanks