Skip to contentSkip to conversation

drm/gma500: Remove unused function psb_gem_get_aperture()

PATCH In review Thomas Zimmermann 3 participants 3 messages Nov 6, 2020 – Nov 9, 2020

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/gma500: Remove unused function psb_gem_get_aperture()

Apparently, the function was never used at all.

---
 drivers/gpu/drm/gma500/gem.c     | 6 ------
 drivers/gpu/drm/gma500/psb_drv.h | 2 --
 2 files changed, 8 deletions(-)
drivers/gpu/drm/gma500/gem.c +0 -6
index 8f07de83b6fb..db827e591403 100644
@@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj)
 	psb_gtt_free_range(obj->dev, gtt);
 }
 
-int psb_gem_get_aperture(struct drm_device *dev, void *data,
-				struct drm_file *file)
-{
-	return -EINVAL;
-}
-
 static const struct vm_operations_struct psb_gem_vm_ops = {
 	.fault = psb_gem_fault,
 	.open = drm_gem_vm_open,
drivers/gpu/drm/gma500/psb_drv.h +0 -2
index c71a5a4e912c..ce6aae4b1bb2 100644
@@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs
 extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
 
 /* gem.c */
-extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
-			struct drm_file *file);
 extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
 			struct drm_mode_create_dumb *args);
 
Signature · 6 lines
2.29.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Thomas Zimmermann

Apparently, the function was never used at all.

Indeed unused.
I expect you or Patrik to apply the patch.

Sam

Quoted 42 lines
---
 drivers/gpu/drm/gma500/gem.c     | 6 ------
 drivers/gpu/drm/gma500/psb_drv.h | 2 --
 2 files changed, 8 deletions(-)
drivers/gpu/drm/gma500/gem.c +0 -6
index 8f07de83b6fb..db827e591403 100644
@@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj)
 	psb_gtt_free_range(obj->dev, gtt);
 }
 
-int psb_gem_get_aperture(struct drm_device *dev, void *data,
-				struct drm_file *file)
-{
-	return -EINVAL;
-}
-
 static const struct vm_operations_struct psb_gem_vm_ops = {
 	.fault = psb_gem_fault,
 	.open = drm_gem_vm_open,
drivers/gpu/drm/gma500/psb_drv.h +0 -2
index c71a5a4e912c..ce6aae4b1bb2 100644
@@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs
 extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
 
 /* gem.c */
-extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
-			struct drm_file *file);
 extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
 			struct drm_mode_create_dumb *args);
 
Signature · 6 lines
2.29.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#2 lore raw
In reply to Thomas Zimmermann
Quoted 4 lines · Thomas Zimmermann

Apparently, the function was never used at all.

Thanks Thomas,

As agreed, please apply to drm-misc-next

-Patrik

Quoted 36 lines
---
 drivers/gpu/drm/gma500/gem.c     | 6 ------
 drivers/gpu/drm/gma500/psb_drv.h | 2 --
 2 files changed, 8 deletions(-)
drivers/gpu/drm/gma500/gem.c +0 -6
index 8f07de83b6fb..db827e591403 100644
@@ -32,12 +32,6 @@ static void psb_gem_free_object(struct drm_gem_object *obj)
        psb_gtt_free_range(obj->dev, gtt);
 }
 
-int psb_gem_get_aperture(struct drm_device *dev, void *data,
-                               struct drm_file *file)
-{
-       return -EINVAL;
-}
-
 static const struct vm_operations_struct psb_gem_vm_ops = {
        .fault = psb_gem_fault,
        .open = drm_gem_vm_open,
drivers/gpu/drm/gma500/psb_drv.h +0 -3
index c71a5a4e912c..ce6aae4b1bb2 100644
@@ -735,8 +735,6 @@ extern const struct drm_connector_helper_funcs
 extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
 
 /* gem.c */
-extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
-                       struct drm_file *file);
 extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
                        struct drm_mode_create_dumb *args);
 
--
Quoted 2 lines

2.29.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel