watchdog: stm32_iwdg: don't print an error on probe deferral
Subsystems (2)
v2 cover watchdog: stm32_iwdg: don't print an error on probe deferral
Do not print an error trace when deferring probe for clock resources.
Version 2: Remark from Guenter and Ahmad
use dev_err_probe instead
Etienne Carriere (1):
watchdog: stm32_iwdg: don't print an error on probe deferral
drivers/watchdog/stm32_iwdg.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/1 watchdog: stm32_iwdg: don't print an error on probe deferral
From: Etienne Carriere <[email protected]>
Do not print an error trace when deferring probe for clock resources.
Signed-off-by Etienne Carriere <[email protected]>
Signed-off-by Christophe Roullier <[email protected]>
--- drivers/watchdog/stm32_iwdg.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/watchdog/stm32_iwdg.c +5 -8
@@ -162,18 +162,15 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev,u32 ret; wdt->clk_lsi =devm_clk_get (dev,"lsi" ); -if (IS_ERR (wdt->clk_lsi)) { -dev_err (dev,"Unable to get lsi clock\n" ); -return PTR_ERR (wdt->clk_lsi); - } +if (IS_ERR (wdt->clk_lsi)) +return dev_err_probe (dev,PTR_ERR (wdt->clk_lsi),"Unable to get lsi clock\n" );/* optional peripheral clock */ if (wdt->data->has_pclk) { wdt->clk_pclk =devm_clk_get (dev,"pclk" ); -if (IS_ERR (wdt->clk_pclk)) { -dev_err (dev,"Unable to get pclk clock\n" ); -return PTR_ERR (wdt->clk_pclk); - } +if (IS_ERR (wdt->clk_pclk)) +return dev_err_probe (dev,PTR_ERR (wdt->clk_pclk), +"Unable to get pclk clock\n" ); ret =clk_prepare_enable (wdt->clk_pclk);if (ret) {
Signature · 1 line
2.17.1
Quoted 6 lines · Christophe Roullier
From: Etienne Carriere <[email protected]>
Do not print an error trace when deferring probe for clock resources.
Signed-off-by Etienne Carriere <[email protected]>Signed-off-by Christophe Roullier <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 35 lines
--- drivers/watchdog/stm32_iwdg.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)drivers/watchdog/stm32_iwdg.c +5
-8@@ -162,18 +162,15 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev,u32 ret; wdt->clk_lsi =devm_clk_get (dev,"lsi" ); -if (IS_ERR (wdt->clk_lsi)) { -dev_err (dev,"Unable to get lsi clock\n" ); -return PTR_ERR (wdt->clk_lsi); - } +if (IS_ERR (wdt->clk_lsi)) +return dev_err_probe (dev,PTR_ERR (wdt->clk_lsi),"Unable to get lsi clock\n" );/* optional peripheral clock */ if (wdt->data->has_pclk) { wdt->clk_pclk =devm_clk_get (dev,"pclk" ); -if (IS_ERR (wdt->clk_pclk)) { -dev_err (dev,"Unable to get pclk clock\n" ); -return PTR_ERR (wdt->clk_pclk); - } +if (IS_ERR (wdt->clk_pclk)) +return dev_err_probe (dev,PTR_ERR (wdt->clk_pclk), +"Unable to get pclk clock\n" ); ret =clk_prepare_enable (wdt->clk_pclk);if (ret) {Signature · 1 line
2.17.1