Skip to contentSkip to conversation

ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats

PATCH In review Kyle Russell 2 participants 2 messages Nov 6, 2020 – Nov 18, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats

The transmit phase register value is never cleared during hw params. So once hw params sets this bit to handle a two channel format, it remains configured for dual-phase, which is not desirable for mono playback.

---
 sound/soc/pxa/mmp-sspa.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/pxa/mmp-sspa.c +1 -0
index 4255851c71c1..52d4d8ace1c3 100644
@@ -239,6 +239,7 @@ static int mmp_sspa_hw_params(struct snd_pcm_substream *substream,
 		return -EINVAL;
 	}
 
+	sspa_ctrl &= ~SSPA_CTL_XPH;
 	if (dev->of_node || params_channels(params) == 2)
 		sspa_ctrl |= SSPA_CTL_XPH;
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 4 lines · Kyle Russell

The transmit phase register value is never cleared during hw params. So once hw params sets this bit to handle a two channel format, it remains configured for dual-phase, which is not desirable for mono playback.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mmp-sspa: clear transmit phase bit for non-stereo formats

      commit: b88b31f4fa0abcd698045362d4aefcddc50cba59

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel