build: align wording of non-support reasons
Subsystems (4)
PATCH 1/1 build: align wording of non-support reasons
Reasons for building not supported generally start with lowercase because printed as the second part of a line.
Other changes:
- "linux" should be "Linux" with a capital letter.
- ARCH_X86_64 may be simply x86_64.
- aarch64 is preferred over arm64.
--- drivers/bus/dpaa/meson.build | 2 +- drivers/bus/fslmc/meson.build | 2 +- drivers/bus/vmbus/meson.build | 2 +- drivers/common/dpaax/meson.build | 2 +- drivers/crypto/caam_jr/meson.build | 2 +- drivers/crypto/ccp/meson.build | 2 +- drivers/crypto/dpaa2_sec/meson.build | 2 +- drivers/crypto/dpaa_sec/meson.build | 2 +- drivers/crypto/octeontx/meson.build | 2 +- drivers/event/dlb/meson.build | 2 +- drivers/event/dlb2/meson.build | 2 +- drivers/event/dpaa/meson.build | 2 +- drivers/event/dpaa2/meson.build | 2 +- drivers/mempool/dpaa/meson.build | 2 +- drivers/mempool/dpaa2/meson.build | 2 +- drivers/meson.build | 4 ++-- drivers/net/af_packet/meson.build | 2 +- drivers/net/avp/meson.build | 2 +- drivers/net/axgbe/meson.build | 2 +- drivers/net/dpaa/meson.build | 2 +- drivers/net/dpaa2/meson.build | 2 +- drivers/net/enetc/meson.build | 2 +- drivers/net/hns3/meson.build | 2 +- drivers/net/nfp/meson.build | 2 +- drivers/net/softnic/meson.build | 2 +- drivers/net/tap/meson.build | 2 +- drivers/net/vdev_netvsc/meson.build | 2 +- lib/librte_kni/meson.build | 2 +- lib/librte_power/meson.build | 2 +- lib/librte_vhost/meson.build | 2 +- 30 files changed, 31 insertions(+), 31 deletions(-)
drivers/bus/dpaa/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['common_dpaax', 'eventdev']
drivers/bus/fslmc/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['common_dpaax', 'eventdev', 'kvargs']
drivers/bus/vmbus/meson.build +1 -1
@@ -20,5 +20,5 @@ if is_linux includes += include_directories('linux') else build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif
drivers/common/dpaax/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('dpaax_iova_table.c', 'dpaa_of.c', 'caamflib.c')
drivers/crypto/caam_jr/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_vdev', 'bus_dpaa', 'security']
drivers/crypto/ccp/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif dep = dependency('libcrypto', required: false) if not dep.found()
drivers/crypto/dpaa2_sec/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['security', 'mempool_dpaa2']
drivers/crypto/dpaa_sec/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_dpaa', 'mempool_dpaa', 'security']
drivers/crypto/octeontx/meson.build +1 -1
@@ -2,7 +2,7 @@ # Copyright(c) 2018 Cavium, Inc if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_pci']
drivers/event/dlb/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') build = false - reason = 'only supported on ARCH_X86_64 Linux' + reason = 'only supported on x86_64 Linux' subdir_done() endif
drivers/event/dlb2/meson.build +1 -1
@@ -4,7 +4,7 @@ if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') build = false - reason = 'only supported on ARCH_X86_64 Linux' + reason = 'only supported on x86_64 Linux' subdir_done() endif
drivers/event/dpaa/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['net_dpaa', 'crypto_dpaa_sec'] sources = files('dpaa_eventdev.c')
drivers/event/dpaa2/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_vdev', 'net_dpaa2', 'crypto_dpaa2_sec'] sources = files('dpaa2_hw_dpcon.c',
drivers/mempool/dpaa/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_dpaa']
drivers/mempool/dpaa2/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['bus_fslmc']
drivers/meson.build +2 -2
@@ -77,7 +77,7 @@ foreach subpath:subdirs if disabled_drivers.contains(drv_path) build = false - reason = 'Explicitly disabled via build config' + reason = 'explicitly disabled via build config' else # pull in driver directory which should update all the local variables subdir(drv_path)
@@ -90,7 +90,7 @@ foreach subpath:subdirs foreach d:deps if not is_variable('shared_rte_' + d) build = false - reason = 'Missing internal dependency, "@0@"'.format(d) + reason = 'missing internal dependency, "@0@"'.format(d) message('Disabling @1@ [@2@]: missing internal dependency "@0@"' .format(d, name, 'drivers/' + drv_path)) else
drivers/net/af_packet/meson.build +1 -1
@@ -3,6 +3,6 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('rte_eth_af_packet.c')
drivers/net/avp/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('avp_ethdev.c') headers = files('rte_avp_common.h', 'rte_avp_fifo.h')
drivers/net/axgbe/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('axgbe_ethdev.c',
drivers/net/dpaa/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['mempool_dpaa']
drivers/net/dpaa2/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['mempool_dpaa2']
drivers/net/enetc/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif deps += ['common_dpaax']
drivers/net/hns3/meson.build +1 -1
@@ -9,7 +9,7 @@ endif if arch_subdir != 'x86' and arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64') build = false - reason = 'only supported on x86_64 and arm64' + reason = 'only supported on x86_64 and aarch64' subdir_done() endif
drivers/net/nfp/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux or not dpdk_conf.get('RTE_ARCH_64') build = false - reason = 'only supported on 64-bit linux' + reason = 'only supported on 64-bit Linux' endif sources = files('nfpcore/nfp_cpp_pcie_ops.c', 'nfpcore/nfp_nsp.c',
drivers/net/softnic/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif headers = files('rte_eth_softnic.h') sources = files('rte_eth_softnic_tm.c',
drivers/net/tap/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files( 'rte_eth_tap.c',
drivers/net/vdev_netvsc/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('vdev_netvsc.c')
lib/librte_kni/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux or not dpdk_conf.get('RTE_ARCH_64') build = false - reason = 'only supported on 64-bit linux' + reason = 'only supported on 64-bit Linux' endif sources = files('rte_kni.c') headers = files('rte_kni.h', 'rte_kni_common.h')
lib/librte_power/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif sources = files('rte_power.c', 'power_acpi_cpufreq.c', 'power_kvm_vm.c', 'guest_channel.c',
lib/librte_vhost/meson.build +1 -1
@@ -3,7 +3,7 @@ if not is_linux build = false - reason = 'only supported on linux' + reason = 'only supported on Linux' endif if has_libnuma == 1 dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)
Signature · 1 line
2.28.0
Quoted 10 lines · Thomas Monjalon
Reasons for building not supported generally start with lowercase because printed as the second part of a line.
Other changes:
- "linux" should be "Linux" with a capital letter.
-ARCH_X86_64may be simplyx86_64.
- aarch64 is preferred over arm64.Signed-off-by Thomas Monjalon <[email protected]>
After patch, we end up with:
1 'missing dependency, DPDK KNI library'
1 'missing dependency, DPDK VMBus driver'
1 'missing dependency, "libAArch64crypto"'
1 'missing dependency, "libbpf"'
1 'missing dependency, "libisal"'
1 'missing dependency, "libnfb"'
1 'missing dependency, "libpcap"'
1 'missing dependency, "librt"'
1 'missing dependency, "libsze2"'
1 'only supported on Linux and Windows'
1 'only supported on x86'
2 ''
2 'missing dependency, DPDK DPAA2 mempool driver' 2 'missing dependency, DPDK vhost library'
2 'missing dependency, "libcrypto"'
2 'missing dependency, "libfdt"'
2 'missing dependency, "' + libname + '"'
2 'missing dependency, "zlib"'
2 'only supported on x86_64 Linux'
3 'only supported on x86_64 and aarch64'
4 'missing dependency, "libmusdk"'
4 'only supported on 64-bit'
4 'only supported on 64-bit Linux'
5 'IPSec_MB version >= @0@ is required, found version @1@' 5 'missing dependency, "libIPSec_MB"'
6 'not supported on Windows'
32 'only supported on Linux'
I wonder if we could use some helper here, like for OS checks and avoid getting those strings "not supported on XXX" "only supported on XXX" in libs/drivers meson.build.
But otherwise, I tried it, looked at meson logs, LGTM.
Signature · 1 line
David Marchand
David Marchand
AppliedQuoted 5 lines · David Marchand
Quoted 4 lines · Thomas Monjalon
Reasons for building not supported generally start with lowercase because printed as the second part of a line.
Quoted 7 lines
Quoted 6 lines
Other changes:
- "linux" should be "Linux" with a capital letter.
-ARCH_X86_64may be simplyx86_64.
- aarch64 is preferred over arm64.Signed-off-by Thomas Monjalon <[email protected]>Acked-by David Marchand <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand