affine_move_task does not always release rq lock
FYI. There is one path through affine_move_task() which does not release the rq lock. This appears to be in error.
* Either way, we really should have a @pending here. */ if (WARN_ON_ONCE(!pending)) return -EINVAL;
Regards,
Joe
Quoted 7 lines · Joe Korty
FYI. There is one path through
affine_move_task()which does not release the rq lock. This appears to be in error.* Either way, we really should have a @pending here. */ if (WARN_ON_ONCE(!pending)) return -EINVAL;
Indeed so. I'm assuming you didn't actually hit the warning but found this through inspection?
Anyway, let me go ammend this. Thanks!
Quoted 11 lines · Peter Zijlstra
Quoted 7 lines · Joe Korty
FYI. There is one path through
affine_move_task()which does not release the rq lock. This appears to be in error.* Either way, we really should have a @pending here. */ if (WARN_ON_ONCE(!pending)) return -EINVAL;Indeed so. I'm assuming you didn't actually hit the warning but found this through inspection?
That is correct...
Quoted 1 line
Anyway, let me go ammend this. Thanks!
Yer welcome!
Joe