Skip to contentSkip to conversation

package/cryptsetup: break circular dependency

PATCH New Fabrice Fontaine 2 participants 2 messages Nov 6, 2020 – Nov 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/cryptsetup: break circular dependency

Build fails because of the following circular dependency:

cryptsetup -> util-linux -> udev -> systemd -> cryptsetup

which results in the following build failure:

checking uuid/uuid.h usability... no checking uuid/uuid.h presence... no checking for uuid/uuid.h... no
configure: error: You need the uuid library.

To break it, apply the same ugly workaround that was applied for
libglib2 until a better solution is found:
https://patchwork.ozlabs.org/project/buildroot/patch/20201101150619.1709959-1-fontaine.fabrice at gmail.com/

Fixes:
- http://autobuild.buildroot.org/results/a1a020a3e1c2383a030fcd73eae7c0fe5f82b022

---
 package/cryptsetup/cryptsetup.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/cryptsetup/cryptsetup.mk +3 -1
index a2abf776cc..60097595b4 100644
@@ -8,8 +8,10 @@ CRYPTSETUP_VERSION_MAJOR = 2.3
 CRYPTSETUP_VERSION = $(CRYPTSETUP_VERSION_MAJOR).4
 CRYPTSETUP_SOURCE = cryptsetup-$(CRYPTSETUP_VERSION).tar.xz
 CRYPTSETUP_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/cryptsetup/v$(CRYPTSETUP_VERSION_MAJOR)
-CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf json-c libargon2 \
+CRYPTSETUP_DEPENDENCIES = \
+	lvm2 popt util-linux host-pkgconf json-c libargon2 \
 	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
+	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
 	$(TARGET_NLS_DEPENDENCIES)
 CRYPTSETUP_LICENSE = GPL-2.0+ (programs), LGPL-2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/cryptsetup: break circular dependency

Fabrice, All,

On 2020-11-06 19:02 +0100, Fabrice Fontaine spake thusly:

Quoted 11 lines

Build fails because of the following circular dependency:

cryptsetup -> util-linux -> udev -> systemd -> cryptsetup

which results in the following build failure:

checking uuid/uuid.h usability... no checking uuid/uuid.h presence... no checking for uuid/uuid.h... no
configure: error: You need the uuid library.

Quoted 8 lines

To break it, apply the same ugly workaround that was applied for
libglib2 until a better solution is found:
https://patchwork.ozlabs.org/project/buildroot/patch/20201101150619.1709959-1-fontaine.fabrice at gmail.com/

Fixes:
- http://autobuild.buildroot.org/results/a1a020a3e1c2383a030fcd73eae7c0fe5f82b022

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 package/cryptsetup/cryptsetup.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/cryptsetup/cryptsetup.mk +3 -1
index a2abf776cc..60097595b4 100644
@@ -8,8 +8,10 @@ CRYPTSETUP_VERSION_MAJOR = 2.3
 CRYPTSETUP_VERSION = $(CRYPTSETUP_VERSION_MAJOR).4
 CRYPTSETUP_SOURCE = cryptsetup-$(CRYPTSETUP_VERSION).tar.xz
 CRYPTSETUP_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/cryptsetup/v$(CRYPTSETUP_VERSION_MAJOR)
-CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf json-c libargon2 \
+CRYPTSETUP_DEPENDENCIES = \
+	lvm2 popt util-linux host-pkgconf json-c libargon2 \
 	$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
+	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
 	$(TARGET_NLS_DEPENDENCIES)
 CRYPTSETUP_LICENSE = GPL-2.0+ (programs), LGPL-2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'