git-gui: ssh-askpass: add a checkbox to show the input text
PATCH 1/1 git-gui: ssh-askpass: add a checkbox to show the input text
Hide the input text by default since the field is commonly used for sensative informations such as passwords.
Add a "Show input" checkbox to conditionally show the input.
Helped-by Miguel Boekhold <[email protected]>
Signed-off-by Efimov Vasily <[email protected]>
Signed-off-by David Aguilar <[email protected]>
--- git-gui--askpass | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
This patch gathers the submissions from the following sources:
https://github.com/patthoyts/git-gui/issues/22
https://github.com/prati0100/git-gui/pull/38
https://github.com/git-cola/git-cola/issues/1004
https://github.com/git-cola/git-cola/pull/1069
git-gui--askpass +14 -1
@@ -26,8 +26,21 @@ pack .m -side top -fill x -padx 20 -pady 20 -expand 1 entry .e -textvariable answer -width 50 pack .e -side top -fill x -padx 10 -pady 10 +proc on_show_input_changed {args} { + global show_input + if {$show_input} { + .e configure -show "" + } else { + .e configure -show "*" + } +} +trace add variable show_input write "on_show_input_changed" + +set show_input 0 + if {!$yesno} { - .e configure -show "*" + checkbutton .cb_show -text "Show input" -variable show_input + pack .cb_show -side top -anchor nw } frame .b
Signature · 1 line
2.29.2.154.g7f7ebe054a
Pratyush Yadav
AppliedQuoted 8 lines · David Aguilar
Hide the input text by default since the field is commonly used for sensative informations such as passwords.
Add a "Show input" checkbox to conditionally show the input.
Helped-by Miguel Boekhold <[email protected]>Signed-off-by Efimov Vasily <[email protected]>Signed-off-by David Aguilar <[email protected]>
Merged to git-gui/master. Thanks.
Signature · 2 lines
Regards, Pratyush Yadav