drm: bridge: dw-hdmi: Avoid resetting force in the detect function
Subsystems (4)
PATCH 1/1 drm: bridge: dw-hdmi: Avoid resetting force in the detect function
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to dump_stack() in dw_hdmi_phy_power_off() shows the following in dmesg:
[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
Call trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_fork
--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0 -6
@@ -2327,12 +2327,6 @@ static enum drm_connector_status dw_hdmi_detect(struct dw_hdmi *hdmi) {enum drm_connector_status result; -mutex_lock (&hdmi->mutex); - hdmi->force =DRM_FORCE_UNSPECIFIED ; -dw_hdmi_update_power (hdmi); -dw_hdmi_update_phy_mask (hdmi); -mutex_unlock (&hdmi->mutex); - result = hdmi->phy.ops->read_hpd (hdmi, hdmi->phy.data);mutex_lock (&hdmi->mutex);
Signature · 1 line
2.29.1
Russell,
Quoted 23 lines · Jonathan Liu
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterationsCall trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_fork
Quoted 2 lines
Fixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")Signed-off-by Jonathan Liu <[email protected]>
you are the original author of this code - any comments on this patch?
Sam
Quoted 28 lines
--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ------ 1 file changed, 6 deletions(-)drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0
-6@@ -2327,12 +2327,6 @@ static enum drm_connector_status dw_hdmi_detect(struct dw_hdmi *hdmi) {enum drm_connector_status result; -mutex_lock (&hdmi->mutex); - hdmi->force =DRM_FORCE_UNSPECIFIED ; -dw_hdmi_update_power (hdmi); -dw_hdmi_update_phy_mask (hdmi); -mutex_unlock (&hdmi->mutex); - result = hdmi->phy.ops->read_hpd (hdmi, hdmi->phy.data);mutex_lock (&hdmi->mutex);Signature · 6 lines
2.29.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 26 lines · Sam Ravnborg
Russell,
Quoted 23 lines · Jonathan Liu
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterationsCall trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_fork
Quoted 4 lines
Quoted 2 lines
Fixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")Signed-off-by Jonathan Liu <[email protected]>you are the original author of this code - any comments on this patch?
No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry.
Signature · 6 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Russell,
Quoted 30 lines · Russell King - ARM Linux admin
Quoted 29 lines · Sam Ravnborg
Russell,
Quoted 25 lines · Jonathan Liu
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterationsCall trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_forkFixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")Signed-off-by Jonathan Liu <[email protected]>
Quoted 6 lines
Quoted 1 line
you are the original author of this code - any comments on this patch?
No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry.
Thanks for the quick reply.
Given that this fixes a problem for Jonathan I will apply this to -fixes if there is no other feedback the next couple of days.
If it introduces regression we can take it from there.
Jonathan - please ping me if I forget.
Sam
Hi Sam,
Quoted 42 lines · Sam Ravnborg
Hi Russell,
Quoted 30 lines · Russell King - ARM Linux admin
Quoted 29 lines · Sam Ravnborg
Russell,
Quoted 25 lines · Jonathan Liu
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterationsCall trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_forkFixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")Signed-off-by Jonathan Liu <[email protected]>Quoted 6 lines
Quoted 1 line
you are the original author of this code - any comments on this patch?
No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry.
Thanks for the quick reply.
Quoted 7 lines
Given that this fixes a problem for Jonathan I will apply this to -fixes if there is no other feedback the next couple of days.
If it introduces regression we can take it from there.Jonathan - please ping me if I forget.
Sam
Ping.
Regards,
Jonathan
Hi Sam,
Quoted 48 lines · Sam Ravnborg
Hi Russell,
Quoted 4 lines · Russell King - ARM Linux admin
Quoted 3 lines · Sam Ravnborg
Russell,
On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0iterations
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Call trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_forkQuoted 1 line
Quoted 1 line
Quoted 1 line
Fixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector modeforcing")
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Jonathan Liu <[email protected]>you are the original author of this code - any comments on this patch?
No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry.
Thanks for the quick reply.
Given that this fixes a problem for Jonathan I will apply this to -fixes if there is no other feedback the next couple of days.
If it introduces regression we can take it from there.
Quoted 6 lines
Jonathan - please ping me if I forget.
Sam
Ping.
Regards,
Jonathan
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg
AppliedHi Jonathan
Quoted 23 lines · Jonathan Liu
It has been observed that resetting force in the detect function can result in the PHY being powered down in response to hot-plug detect being asserted, even when the HDMI connector is forced on.
Enabling debug messages and adding a call to
dump_stack()indw_hdmi_phy_power_off()shows the following in dmesg:[ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterationsCall trace:
dw_hdmi_phy_power_offdw_hdmi_phy_disabledw_hdmi_update_powerdw_hdmi_detectdw_hdmi_connector_detectdrm_helper_probe_detect_ctxdrm_helper_hpd_irq_eventdw_hdmi_irqirq_thread_fnirq_thread
kthreadret_from_fork
Quoted 2 lines
Fixes 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")Signed-off-by Jonathan Liu <[email protected]>
Applied to drm-misc-fixes.
Sam