qga: fix missing closedir() in qmp_guest_get_disks()
PATCH 1/1 qga: fix missing closedir() in qmp_guest_get_disks()
We opendir("/sys/block") at the beginning of the function, but we never close it prior to returning.
Fixes Coverity CID 1436130
Fixes fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")
Reported-by Peter Maydell <[email protected]>
Cc Marc-André Lureau <[email protected]>
Cc Tomáš Golembiovský <[email protected]>
Signed-off-by Michael Roth <[email protected]>
--- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+)
qga/commands-posix.c +3 -0
@@ -1443,6 +1443,9 @@ GuestDiskInfoList *qmp_guest_get_disks(Error **errp)get_disk_deps (disk_dir, disk); ret =get_disk_partitions (ret, de->d_name, disk_dir, dev_name); } + +closedir (dp); +return ret; }
Signature · 1 line
2.25.1
Quoted 9 lines · Michael Roth
We
opendir("/sys/block")at the beginning of the function, but we never close it prior to returning.Fixes Coverity CID 1436130Fixes fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")Reported-by Peter Maydell <[email protected]>Cc Marc-André Lureau <[email protected]>Cc Tomáš Golembiovský <[email protected]>Signed-off-by Michael Roth <[email protected]>
Quoted 3 lines
--- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+)
Reviewed-by Philippe Mathieu-Daudé <[email protected]>