libnvdimm: Introduce ND_CMD_GET_STAT to retrieve nvdimm statistics
Subsystems (2)
RFC PATCH 1/2 libnvdimm: Introduce ND_CMD_GET_STAT to retrieve nvdimm statistics
Implement support for exposing generic nvdimm statistics via newly introduced dimm-command ND_CMD_GET_STAT that can be handled by nvdimm command handler function and provide values for these statistics back to libnvdimm. Following generic nvdimm statistics are defined as an enumeration in 'uapi/ndctl.h':
* "media_reads" : Number of media reads that have occurred since reboot.
* "media_writes" : Number of media writes that have occurred since reboot.
* "read_requests" : Number of read requests that have occurred since reboot.
* "write_requests" : Number of write requests that have occurred since reboot.
* "total_media_reads" : Total number of media reads that have occurred.
* "total_media_writes" : Total number of media writes that have occurred.
* "total_read_requests" : Total number of read requests that have occurred.
* "total_write_requests" : Total number of write requests that have occurred.
Apart from ND_CMD_GET_STAT ioctl these nvdimm statistics are also exposed via sysfs '<nvdimm-device>/stats' directory for easy user-space access like below:
/sys/class/nd/ndctl0/device/nmem0/stats # tail -n +1 * ==> media_reads <==
252197707602
==> media_writes <==
20684685172
==> read_requests <==
658810924962
==> write_requests <==
404464081574
In case a specific nvdimm-statistic is not supported than nvdimm command handler function can simply return an error (e.g -ENOENT) for request to read that nvdimm-statistic.
The value for a specific nvdimm-stat is exchanged via newly introduced 'struct nd_cmd_get_dimm_stat' that hold a single statistics and a union of possible values types. Presently only '__s64' type of generic attributes are supported. These attributes are defined in 'ndvimm/dimm_devs.c' via a helper macro 'NVDIMM_STAT_ATTR'.
--- drivers/nvdimm/bus.c | 6 ++ drivers/nvdimm/dimm_devs.c | 109 +++++++++++++++++++++++++++++++++++++ drivers/nvdimm/nd.h | 5 ++ include/uapi/linux/ndctl.h | 27 +++++++++ 4 files changed, 147 insertions(+)
drivers/nvdimm/bus.c +6 -0
@@ -794,6 +794,12 @@ static const struct nd_cmd_desc __nd_cmd_dimm_descs[] = { .out_num = 1, .out_sizes = { UINT_MAX, }, }, + [ND_CMD_GET_STAT] = { + .in_num = 1, + .in_sizes = { sizeof(struct nd_cmd_get_dimm_stat), }, + .out_num = 1, + .out_sizes = { sizeof(struct nd_cmd_get_dimm_stat), }, + }, };const struct nd_cmd_desc *nd_cmd_dimm_desc (int cmd)
drivers/nvdimm/dimm_devs.c +109 -0
121 lines not on this page · raw message
drivers/nvdimm/nd.h +5 -0
@@ -223,6 +223,11 @@ enum nd_async_mode { ND_ASYNC, }; +struct nvdimm_stat_attr { +struct device_attribute attr; +u64 stat_id; +}; +int nd_integrity_init (struct gendisk *disk,unsigned long meta_size);void wait_nvdimm_bus_probe_idle (struct device *dev);void nd_device_register (struct device *dev);
include/uapi/linux/ndctl.h +27 -0
@@ -97,6 +97,31 @@ struct nd_cmd_clear_error {__u64 cleared; } __packed; +/* Various generic dimm stats that can be reported */ +enum { +ND_DIMM_STAT_INVALID =0 , +ND_DIMM_STAT_MEDIA_READS =1 ,/* Media reads after power cycle */ +ND_DIMM_STAT_MEDIA_WRITES =2 ,/* Media writes after power cycle */ +ND_DIMM_STAT_READ_REQUESTS =3 ,/* Read requests after power cycle */ +ND_DIMM_STAT_WRITE_REQUESTS =4 ,/* Write requests after power cycle */ +ND_DIMM_STAT_TOTAL_MEDIA_READS =5 ,/* Total Media Reads */ +ND_DIMM_STAT_TOTAL_MEDIA_WRITES =6 ,/* Total Media Writes */ +ND_DIMM_STAT_TOTAL_READ_REQUESTS =7 ,/* Total Read Requests */ +ND_DIMM_STAT_TOTAL_WRITE_REQUESTS =8 ,/* Total Write Requests */ +ND_DIMM_STAT_MAX =8 , +}; + +struct nd_cmd_get_dimm_stat { +/* See enum above for valid values */ +__u64 stat_id; + +/* Holds a single dimm stat value */ +union { +__s64 int_val; +char str_val[120 ]; + }; +} __packed; +enum {ND_CMD_IMPLEMENTED =0 ,
@@ -117,6 +142,7 @@ enum {ND_CMD_VENDOR_EFFECT_LOG =8 ,ND_CMD_VENDOR =9 ,ND_CMD_CALL =10 , + ND_CMD_GET_STAT = 11, }; enum {
@@ -151,6 +177,7 @@ static inline const char *nvdimm_cmd_name(unsigned cmd)case ND_CMD_VENDOR_EFFECT_LOG :return "effect_log" ;case ND_CMD_VENDOR :return "vendor" ;case ND_CMD_CALL :return "cmd_call" ; +case ND_CMD_GET_STAT :return "get_stat" ;default :return "unknown" ; } }
Signature · 4 lines
2.28.0 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
RFC PATCH 2/2 powerpc/papr_scm: Implement support for reporting generic nvdimm stats
Add support for reporting papr-scm supported generic nvdimm stats by implementing support for handling ND_CMD_GET_STAT in 'papr_scm_ndctl().
The mapping between libnvdimm generic nvdimm-stats and papr-scm specific performance-stats is embedded inside 'dimm_stats_map[]'. This array is queried by newly introduced 'papr_scm_get_stat()' that verifies if the requested nvdimm-stat is supported and if yes does an hcall via 'drc_pmem_query_stat()' to request the performance-stat and return it back to libnvdimm.
--- arch/powerpc/platforms/pseries/papr_scm.c | 66 ++++++++++++++++++++++- 1 file changed, 65 insertions(+), 1 deletion(-)
arch/powerpc/platforms/pseries/papr_scm.c +65 -1
@@ -25,7 +25,8 @@ ((1ul <<ND_CMD_GET_CONFIG_SIZE ) | \ (1ul <<ND_CMD_GET_CONFIG_DATA ) | \ (1ul <<ND_CMD_SET_CONFIG_DATA ) | \ - (1ul <<ND_CMD_CALL )) + (1ul <<ND_CMD_CALL ) | \ + (1ul <<ND_CMD_GET_STAT ))/* DIMM health bitmap bitmap indicators */ /* SCM device is unable to persist memory contents */
@@ -120,6 +121,16 @@ struct papr_scm_priv {static LIST_HEAD (papr_nd_regions);static DEFINE_MUTEX (papr_ndr_lock); +/* Map generic nvdimm stats to papr-scm stats */ +static const char *const dimm_stat_map[] = { + [ND_DIMM_STAT_INVALID ] =NULL , + [ND_DIMM_STAT_MEDIA_READS ] ="MedRCnt " , + [ND_DIMM_STAT_MEDIA_WRITES ] ="MedWCnt " , + [ND_DIMM_STAT_READ_REQUESTS ] ="HostLCnt" , + [ND_DIMM_STAT_WRITE_REQUESTS ] ="HostSCnt" , + [ND_DIMM_STAT_MAX ] =NULL , +}; +static int drc_pmem_bind (struct papr_scm_priv *p) {unsigned long ret[PLPAR_HCALL_BUFSIZE ];
@@ -728,6 +739,54 @@ static int papr_scm_service_pdsm(struct papr_scm_priv *p,return pdsm_pkg->cmd_status; } +/* +* For a given pdsm request call an appropriate service function. +* Returns errors if any while handling the pdsm command package. +*/ +static int papr_scm_get_stat (struct papr_scm_priv *p, +struct nd_cmd_get_dimm_stat *dimm_stat) + +{ +int rc; +ssize_t size; +struct papr_scm_perf_stat *stat; +struct papr_scm_perf_stats *stats; + +/* Check if the requested stat-id is supported */ +if (dimm_stat->stat_id >=ARRAY_SIZE (dimm_stat_map) || + !dimm_stat_map[dimm_stat->stat_id]) { +dev_dbg (&p->pdev->dev,"Invalid stat-id %lld\n" , dimm_stat->stat_id); +return -ENOSPC ; + } + +/* Allocate request buffer enough to hold single performance stat */ + size =sizeof (struct papr_scm_perf_stats ) + +sizeof (struct papr_scm_perf_stat ); + + stats =kzalloc (size,GFP_KERNEL ); +if (!stats) +return -ENOMEM ; + + stat = &stats->scm_statistic[0 ]; +memcpy (&stat->stat_id, dimm_stat_map[dimm_stat->stat_id], +sizeof (stat->stat_id)); + stat->stat_val =0 ; + +/* Fetch the statistic from PHYP and copy it to provided payload */ + rc =drc_pmem_query_stats (p, stats,1 ); +if (rc <0 ) { +dev_dbg (&p->pdev->dev,"Err(%d) fetching stat '%.8s'\n" , + rc, stat->stat_id); +kfree (stats); +return rc; + } + + dimm_stat->int_val =be64_to_cpu (stat->stat_val); + +kfree (stats); +return 0 ; +} +static int papr_scm_ndctl (struct nvdimm_bus_descriptor *nd_desc,struct nvdimm *nvdimm,unsigned int cmd,void *buf,unsigned int buf_len,int *cmd_rc)
@@ -772,6 +831,11 @@ static int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc, *cmd_rc =papr_scm_service_pdsm (p, call_pkg);break ; +case ND_CMD_GET_STAT : + *cmd_rc =papr_scm_get_stat (p, + (struct nd_cmd_get_dimm_stat *)buf); +break ; +default :dev_dbg (&p->pdev->dev,"Unknown command = %d\n" , cmd);return -EINVAL ;
Signature · 4 lines
2.28.0 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Re: [RFC][PATCH 2/2] powerpc/papr_scm: Implement support for reporting generic nvdimm stats
Hi,
Le 08/11/2020 à 22:15, Vaibhav Jain a écrit :
Quoted 4 lines
Add support for reporting papr-scm supported generic nvdimm stats by implementing support for handling
ND_CMD_GET_STATin 'papr_scm_ndctl().
Quoted 8 lines
The mapping between libnvdimm generic nvdimm-stats and papr-scm specific performance-stats is embedded inside 'dimm_stats_map[]'. This array is queried by newly introduced '
papr_scm_get_stat()' that verifies if the requested nvdimm-stat is supported and if yes does an hcall via 'drc_pmem_query_stat()' to request the performance-stat and return it back to libnvdimm.Signed-off-by Vaibhav Jain <[email protected]>
I see this series is still flagged as 'new' in patchwork.
I saw some patches providing stats to nvdimm are in a pull request for 5.18.
I imagine this is the same subject, so I'm going to change the status of this series. Let me know if I'm wrong.
Thanks
Christophe
Quoted 102 lines
--- arch/powerpc/platforms/pseries/papr_scm.c | 66 ++++++++++++++++++++++- 1 file changed, 65 insertions(+), 1 deletion(-)arch/powerpc/platforms/pseries/papr_scm.c +65
-1@@ -25,7 +25,8 @@ ((1ul <<ND_CMD_GET_CONFIG_SIZE ) | \ (1ul <<ND_CMD_GET_CONFIG_DATA ) | \ (1ul <<ND_CMD_SET_CONFIG_DATA ) | \ - (1ul <<ND_CMD_CALL )) + (1ul <<ND_CMD_CALL ) | \ + (1ul <<ND_CMD_GET_STAT ))/* DIMM health bitmap bitmap indicators */ /* SCM device is unable to persist memory contents */ @@ -120,6 +121,16 @@ struct papr_scm_priv {static LIST_HEAD (papr_nd_regions);static DEFINE_MUTEX (papr_ndr_lock); +/* Map generic nvdimm stats to papr-scm stats */ +static const char *const dimm_stat_map[] = { + [ND_DIMM_STAT_INVALID ] =NULL , + [ND_DIMM_STAT_MEDIA_READS ] ="MedRCnt " , + [ND_DIMM_STAT_MEDIA_WRITES ] ="MedWCnt " , + [ND_DIMM_STAT_READ_REQUESTS ] ="HostLCnt" , + [ND_DIMM_STAT_WRITE_REQUESTS ] ="HostSCnt" , + [ND_DIMM_STAT_MAX ] =NULL , +}; +static int drc_pmem_bind (struct papr_scm_priv *p) {unsigned long ret[PLPAR_HCALL_BUFSIZE ];@@ -728,6 +739,54 @@ static int papr_scm_service_pdsm(struct papr_scm_priv *p,return pdsm_pkg->cmd_status; } +/* +* For a given pdsm request call an appropriate service function. +* Returns errors if any while handling the pdsm command package. +*/ +static int papr_scm_get_stat (struct papr_scm_priv *p, +struct nd_cmd_get_dimm_stat *dimm_stat) + +{ +int rc; +ssize_t size; +struct papr_scm_perf_stat *stat; +struct papr_scm_perf_stats *stats; + +/* Check if the requested stat-id is supported */ +if (dimm_stat->stat_id >=ARRAY_SIZE (dimm_stat_map) || + !dimm_stat_map[dimm_stat->stat_id]) { +dev_dbg (&p->pdev->dev,"Invalid stat-id %lld\n" , dimm_stat->stat_id); +return -ENOSPC ; + } + +/* Allocate request buffer enough to hold single performance stat */ + size =sizeof (struct papr_scm_perf_stats ) + +sizeof (struct papr_scm_perf_stat ); + + stats =kzalloc (size,GFP_KERNEL ); +if (!stats) +return -ENOMEM ; + + stat = &stats->scm_statistic[0 ]; +memcpy (&stat->stat_id, dimm_stat_map[dimm_stat->stat_id], +sizeof (stat->stat_id)); + stat->stat_val =0 ; + +/* Fetch the statistic from PHYP and copy it to provided payload */ + rc =drc_pmem_query_stats (p, stats,1 ); +if (rc <0 ) { +dev_dbg (&p->pdev->dev,"Err(%d) fetching stat '%.8s'\n" , + rc, stat->stat_id); +kfree (stats); +return rc; + } + + dimm_stat->int_val =be64_to_cpu (stat->stat_val); + +kfree (stats); +return 0 ; +} +static int papr_scm_ndctl (struct nvdimm_bus_descriptor *nd_desc,struct nvdimm *nvdimm,unsigned int cmd,void *buf,unsigned int buf_len,int *cmd_rc)@@ -772,6 +831,11 @@ static int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc, *cmd_rc =papr_scm_service_pdsm (p, call_pkg);break ; +case ND_CMD_GET_STAT : + *cmd_rc =papr_scm_get_stat (p, + (struct nd_cmd_get_dimm_stat *)buf); +break ; +default :dev_dbg (&p->pdev->dev,"Unknown command = %d\n" , cmd);return -EINVAL ;
[ add perf maintainers ]
Quoted 11 lines · Vaibhav Jain
Implement support for exposing generic nvdimm statistics via newly introduced dimm-command
ND_CMD_GET_STATthat can be handled by nvdimm command handler function and provide values for these statistics back to libnvdimm. Following generic nvdimm statistics are defined as an enumeration in 'uapi/ndctl.h':* "
media_reads" : Number of media reads that have occurred since reboot.
* "media_writes" : Number of media writes that have occurred since reboot.
* "read_requests" : Number of read requests that have occurred since reboot.
* "write_requests" : Number of write requests that have occurred since reboot.
Perhaps document these as "since device reset"? As I can imagine some devices might have a mechanism to reset the count outside of "reboot" which is a bit ambiguous.
Quoted 9 lines
* "
total_media_reads" : Total number of media reads that have occurred.
* "total_media_writes" : Total number of media writes that have occurred.
* "total_read_requests" : Total number of read requests that have occurred.
* "total_write_requests" : Total number of write requests that have occurred.Apart from
ND_CMD_GET_STATioctl these nvdimm statistics are also exposed via sysfs '<nvdimm-device>/stats' directory for easy user-space access like below:
Quoted 9 lines
/sys/class/nd/ndctl0/device/nmem0/stats# tail -n +1 * ==>media_reads<==
252197707602
==>media_writes<==
20684685172
==>read_requests<==
658810924962
==>write_requests<==
404464081574
Hmm, I haven't looked but how hard would it be to plumb these to be perf counter-events. So someone could combine these with other perf counters?
Quoted 3 lines
In case a specific nvdimm-statistic is not supported than nvdimm command handler function can simply return an error (e.g
-ENOENT) for request to read that nvdimm-statistic.
Makes sense, but I expect the perf route also has a way to enumerate which statistics / counters are supported. I'm not opposed to also having them in sysfs, but I think perf support should be a first class citizen.
Quoted 197 lines
The value for a specific nvdimm-stat is exchanged via newly introduced 'struct
nd_cmd_get_dimm_stat' that hold a single statistics and a union of possible values types. Presently only '__s64' type of generic attributes are supported. These attributes are defined in 'ndvimm/dimm_devs.c' via a helper macro 'NVDIMM_STAT_ATTR'.Signed-off-by Vaibhav Jain <[email protected]>--- drivers/nvdimm/bus.c | 6 ++ drivers/nvdimm/dimm_devs.c | 109 +++++++++++++++++++++++++++++++++++++ drivers/nvdimm/nd.h | 5 ++ include/uapi/linux/ndctl.h | 27 +++++++++ 4 files changed, 147 insertions(+)drivers/nvdimm/bus.c +6
-0@@ -794,6 +794,12 @@ static const struct nd_cmd_desc __nd_cmd_dimm_descs[] = { .out_num = 1, .out_sizes = { UINT_MAX, }, }, + [ND_CMD_GET_STAT] = { + .in_num = 1, + .in_sizes = { sizeof(struct nd_cmd_get_dimm_stat), }, + .out_num = 1, + .out_sizes = { sizeof(struct nd_cmd_get_dimm_stat), }, + }, };const struct nd_cmd_desc *nd_cmd_dimm_desc (int cmd)drivers/nvdimm/dimm_devs.c +109
-0@@ -555,6 +555,114 @@ static umode_t nvdimm_firmware_visible(struct kobject *kobj, struct attribute *areturn a->mode; } +/* Request a dimm stat from the bus driver */ +static int __request_dimm_stat (struct nvdimm_bus *nvdimm_bus, +struct nvdimm *dimm,u64 stat_id, +s64 *stat_val) +{ +struct nvdimm_bus_descriptor *nd_desc = nvdimm_bus->nd_desc; +struct nd_cmd_get_dimm_stat stat = { .stat_id = stat_id }; +int rc, cmd_rc; + +if (!test_bit (ND_CMD_GET_STAT , &dimm->cmd_mask)) { +pr_debug ("CMD_GET_STAT not set for bus driver 0x%lx\n" , + nd_desc->cmd_mask); +return -ENOENT ; + } + +/* Is stat requested is known & bus driver supports fetching stats */ +if (stat_id <=ND_DIMM_STAT_INVALID || stat_id >ND_DIMM_STAT_MAX ) { +WARN (1 ,"Unknown stat-id(%llu) requested" , stat_id); +return -ENOENT ; + } + +/* Ask bus driver for its stat value */ + rc = nd_desc->ndctl (nd_desc, dimm,ND_CMD_GET_STAT , + &stat,sizeof (stat), &cmd_rc); +if (rc || cmd_rc) { +pr_debug ("Unable to request stat %lld. Error (%d,%d)\n" , + stat_id, rc, cmd_rc); +return rc ? rc : cmd_rc; + } + +/* Indicate error in case returned struct doesn't have the stat_id set */ +if (stat.stat_id != stat_id) { +pr_debug ("Invalid statid %llu returned\n" , stat.stat_id); +return -ENOENT ; + } + + *stat_val = stat.int_val; +return 0 ; +} + +static ssize_t nvdimm_stat_attr_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct nvdimm_stat_attr *nattr =container_of (attr,typeof (*nattr), attr); +struct nvdimm_bus *nvdimm_bus =walk_to_nvdimm_bus (dev); +struct nvdimm *nvdimm =to_nvdimm (dev); +s64 stat_val; +int rc; + + rc =__request_dimm_stat (nvdimm_bus, nvdimm, nattr->stat_id, &stat_val); + +if (rc) +return rc; + +return snprintf (buf,PAGE_SIZE ,"%lld" , stat_val); +} + +static umode_t nvdimm_stats_visible (struct kobject *kobj,struct attribute *a,int n) +{ +struct nvdimm_stat_attr *nattr =container_of (a,typeof (*nattr), attr.attr); +struct device *dev =container_of (kobj,typeof (*dev), kobj); +struct nvdimm_bus *nvdimm_bus =walk_to_nvdimm_bus (dev); +struct nvdimm *nvdimm =to_nvdimm (dev); +u64 stat_val; +int rc; + +/* request dimm stat from bus driver and is success mark attribute as visible */ + rc =__request_dimm_stat (nvdimm_bus, nvdimm, nattr->stat_id, &stat_val); +if (rc) +pr_info ("Unable to query stat %llu . Error(%d)\n" , nattr->stat_id, rc); + +return rc ?0 : a->mode; +} + +#define NVDIMM_STAT_ATTR (_name, _stat_id) \ + struct nvdimm_stat_attr nvdimm_stat_attr_##_name = { \ + .attr = __ATTR(_name, 0400, nvdimm_stat_attr_show, NULL), \ + .stat_id = _stat_id, \ + } + +static NVDIMM_STAT_ATTR(media_reads, ND_DIMM_STAT_MEDIA_READS); +static NVDIMM_STAT_ATTR(media_writes, ND_DIMM_STAT_MEDIA_WRITES); +static NVDIMM_STAT_ATTR(read_requests, ND_DIMM_STAT_READ_REQUESTS); +static NVDIMM_STAT_ATTR(write_requests, ND_DIMM_STAT_WRITE_REQUESTS); +static NVDIMM_STAT_ATTR(total_media_reads, ND_DIMM_STAT_TOTAL_MEDIA_READS); +static NVDIMM_STAT_ATTR(total_media_writes, ND_DIMM_STAT_TOTAL_MEDIA_WRITES); +static NVDIMM_STAT_ATTR(total_read_requests, ND_DIMM_STAT_TOTAL_READ_REQUESTS); +static NVDIMM_STAT_ATTR(total_write_requests, ND_DIMM_STAT_TOTAL_WRITE_REQUESTS); + +static struct attribute *nvdimm_stats_attributes[] = { + &nvdimm_stat_attr_media_reads.attr.attr, + &nvdimm_stat_attr_media_writes.attr.attr, + &nvdimm_stat_attr_read_requests.attr.attr, + &nvdimm_stat_attr_write_requests.attr.attr, + &nvdimm_stat_attr_total_media_reads.attr.attr, + &nvdimm_stat_attr_total_media_writes.attr.attr, + &nvdimm_stat_attr_total_read_requests.attr.attr, + &nvdimm_stat_attr_total_write_requests.attr.attr, +NULL , +}; + +static const struct attribute_group nvdimm_stats_group = { + .name ="stats" , + .attrs = nvdimm_stats_attributes, + .is_visible = nvdimm_stats_visible, +}; +static const struct attribute_group nvdimm_firmware_attribute_group = { .name ="firmware" , .attrs = nvdimm_firmware_attributes,@@ -565,6 +673,7 @@ static const struct attribute_group *nvdimm_attribute_groups[] = { &nd_device_attribute_group, &nvdimm_attribute_group, &nvdimm_firmware_attribute_group, + &nvdimm_stats_group, NULL, };drivers/nvdimm/nd.h +5
-0@@ -223,6 +223,11 @@ enum nd_async_mode { ND_ASYNC, }; +struct nvdimm_stat_attr { +struct device_attribute attr; +u64 stat_id; +}; +int nd_integrity_init (struct gendisk *disk,unsigned long meta_size);void wait_nvdimm_bus_probe_idle (struct device *dev);void nd_device_register (struct device *dev);include/uapi/linux/ndctl.h +14
-0@@ -97,6 +97,31 @@ struct nd_cmd_clear_error {__u64 cleared; } __packed; +/* Various generic dimm stats that can be reported */ +enum { +ND_DIMM_STAT_INVALID =0 , +ND_DIMM_STAT_MEDIA_READS =1 ,/* Media reads after power cycle */ +ND_DIMM_STAT_MEDIA_WRITES =2 ,/* Media writes after power cycle */ +ND_DIMM_STAT_READ_REQUESTS =3 ,/* Read requests after power cycle */ +ND_DIMM_STAT_WRITE_REQUESTS =4 ,/* Write requests after power cycle */ +ND_DIMM_STAT_TOTAL_MEDIA_READS =5 ,/* Total Media Reads */ +ND_DIMM_STAT_TOTAL_MEDIA_WRITES =6 ,/* Total Media Writes */ +ND_DIMM_STAT_TOTAL_READ_REQUESTS =7 ,/* Total Read Requests */ +ND_DIMM_STAT_TOTAL_WRITE_REQUESTS =8 ,/* Total Write Requests */ +ND_DIMM_STAT_MAX =8 , +}; +
include/uapi/linux/ndctl.h struct nd_cmd_clear_error { · line 123
Quoted 10 lines
include/uapi/linux/ndctl.h +10
-0+struct nd_cmd_get_dimm_stat { +/* See enum above for valid values */ +__u64 stat_id; + +/* Holds a single dimm stat value */ +union { +__s64 int_val; +char str_val[120 ]; + }; +} __packed;
Is this needed? Especially if perf has the counters, and sysfs optionally has the counters, does the ioctl path also need to be plumbed?
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Quoted 42 lines · Dan Williams
[ add perf maintainers ]
Quoted 11 lines · Vaibhav Jain
Implement support for exposing generic nvdimm statistics via newly introduced dimm-command
ND_CMD_GET_STATthat can be handled by nvdimm command handler function and provide values for these statistics back to libnvdimm. Following generic nvdimm statistics are defined as an enumeration in 'uapi/ndctl.h':* "
media_reads" : Number of media reads that have occurred since reboot.
* "media_writes" : Number of media writes that have occurred since reboot.
* "read_requests" : Number of read requests that have occurred since reboot.
* "write_requests" : Number of write requests that have occurred since reboot.Perhaps document these as "since device reset"? As I can imagine some devices might have a mechanism to reset the count outside of "reboot" which is a bit ambiguous.
Quoted 9 lines
* "
total_media_reads" : Total number of media reads that have occurred.
* "total_media_writes" : Total number of media writes that have occurred.
* "total_read_requests" : Total number of read requests that have occurred.
* "total_write_requests" : Total number of write requests that have occurred.Apart from
ND_CMD_GET_STATioctl these nvdimm statistics are also exposed via sysfs '<nvdimm-device>/stats' directory for easy user-space access like below:Quoted 9 lines
/sys/class/nd/ndctl0/device/nmem0/stats# tail -n +1 * ==>media_reads<==
252197707602
==>media_writes<==
20684685172
==>read_requests<==
658810924962
==>write_requests<==
404464081574Hmm, I haven't looked but how hard would it be to plumb these to be perf counter-events. So someone could combine these with other perf counters?
Quoted 8 lines
Quoted 3 lines
In case a specific nvdimm-statistic is not supported than nvdimm command handler function can simply return an error (e.g
-ENOENT) for request to read that nvdimm-statistic.Makes sense, but I expect the perf route also has a way to enumerate which statistics / counters are supported. I'm not opposed to also having them in sysfs, but I think perf support should be a first class citizen.
arch/x86/events/msr.c might be a good starting point for a software pmu delivering pure counters.
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]