MAINTAINERS: rectify file patterns for NETFILTER
Subsystems (2)
PATCH 1/1 MAINTAINERS: rectify file patterns for NETFILTER
The two file patterns in the NETFILTER section:
F: include/linux/netfilter*
F: include/uapi/linux/netfilter*
intended to match the directories:
./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
A quick check with ./scripts/get_maintainer.pl --letters -f will show that they are not matched, though, because this pattern only matches files, but not directories.
Rectify the patterns to match the intended directories.
---
applies cleanly on v5.10-rc3 and next-20201109
Pablo, Jozsef, Florian, please pick this minor non-urgent clean-up patch.
MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
@@ -12139,10 +12139,10 @@ W: http://www.nftables.org/ Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git -F: include/linux/netfilter* +F: include/linux/netfilter*/ F: include/linux/netfilter/ F: include/net/netfilter/ -F: include/uapi/linux/netfilter* +F: include/uapi/linux/netfilter*/ F: include/uapi/linux/netfilter/ F: net/*/netfilter.c F: net/*/netfilter/
Signature · 1 line
2.17.1
Quoted 7 lines · Lukas Bulwahn
The two file patterns in the NETFILTER section:
F:
include/linux/netfilter*
F:include/uapi/linux/netfilter*intended to match the directories:
Quoted 7 lines
./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
A quick check with
./scripts/get_maintainer.pl--letters -f will show that they are not matched, though, because this pattern only matches files, but not directories.Rectify the patterns to match the intended directories.
Applied, thanks.
Quoted 7 lines · Lukas Bulwahn
The two file patterns in the NETFILTER section:
F:
include/linux/netfilter*
F:include/uapi/linux/netfilter*intended to match the directories:
Quoted 7 lines
./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
A quick check with
./scripts/get_maintainer.pl--letters -f will show that they are not matched, though, because this pattern only matches files, but not directories.Rectify the patterns to match the intended directories.
[]
MAINTAINERS +0 -0
[]
Quoted 7 lines
(quoted diff) +0
-0@@ -12139,10 +12139,10 @@ W: http://www.nftables.org/Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/
T: gitgit://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
T: gitgit://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git(quoted diff) +1
-1-F: include/linux/netfilter* +F: include/linux/netfilter*/F:
include/linux/netfilter/
This line could be deleted or perhaps moved up one line above
F: include/linux/netfilter/
F: include/linux/netfilter*/
(as the second line already matches the first line's files too)
Quoted 4 lines
F:
include/net/netfilter/(quoted diff) +1
-1-F: include/uapi/linux/netfilter* +F: include/uapi/linux/netfilter*/F:
include/uapi/linux/netfilter/
same here.
Quoted 2 lines
F:
net/*/netfilter.c
F:net/*/netfilter/
Pablo Neira Ayuso
maintainerHi Lukas,
Quoted 31 lines · Joe Perches
Quoted 7 lines · Lukas Bulwahn
The two file patterns in the NETFILTER section:
F:
include/linux/netfilter*
F:include/uapi/linux/netfilter*intended to match the directories:
Quoted 7 lines
./include{/uapi}/linux/netfilter_{arp,bridge,ipv4,ipv6}
A quick check with
./scripts/get_maintainer.pl--letters -f will show that they are not matched, though, because this pattern only matches files, but not directories.Rectify the patterns to match the intended directories.
[]
MAINTAINERS +0
-0[]
Quoted 7 lines
(quoted diff) +0
-0@@ -12139,10 +12139,10 @@ W: http://www.nftables.org/Q: http://patchwork.ozlabs.org/project/netfilter-devel/list/
T: gitgit://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
T: gitgit://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git(quoted diff) +1
-1-F: include/linux/netfilter* +F: include/linux/netfilter*/F:
include/linux/netfilter/This line could be deleted or perhaps moved up one line above
F:
include/linux/netfilter/
F:include/linux/netfilter*/
Quoted 11 lines
(as the second line already matches the first line's files too)
Quoted 4 lines
F:
include/net/netfilter/(quoted diff) +1
-1-F: include/uapi/linux/netfilter* +F: include/uapi/linux/netfilter*/F:
include/uapi/linux/netfilter/same here.
Quoted 2 lines
F:
net/*/netfilter.c
F:net/*/netfilter/
Please, send a v2 to address this feedback. Thank you.