arm64: Kconfig RANDOMIZE_MODULE_REGION_FULL correction
PATCH 1/1 arm64: Kconfig RANDOMIZE_MODULE_REGION_FULL correction
In the 5.1.5 Kernel RANDOMIZE_MODULE_REGION_FULL was a 4GB window, however this was changed to 2GB from 5.1.6
(see /arch/arm64/kernel/kaslr.c). This updates the
config description for RANDOMIZE_MODULE_REGION_FULL in /arch/arm64/Kconfig to reflect this.
--- arch/arm64/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/Kconfig +2 -2
@@ -1782,11 +1782,11 @@ config RANDOMIZE_BASE If unsure, say N. config RANDOMIZE_MODULE_REGION_FULL - bool "Randomize the module region over a 4 GB range" + bool "Randomize the module region over a 2 GB range" depends on RANDOMIZE_BASE default y help - Randomizes the location of the module region inside a 4 GB window + Randomizes the location of the module region inside a 2 GB window covering the core kernel. This way, it is less likely for modules to leak information about the location of core kernel data structures but it does imply that function calls between modules and the core
Signature · 6 lines
2.18.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Will Deacon
maintainerHi Ross,
[+Ard]
Quoted 2 lines · Ross Meikleham
In the 5.1.5 Kernel
RANDOMIZE_MODULE_REGION_FULLwas a 4GB window, however this was changed to 2GB from 5.1.6
5.1.5 and 5.1.6 are both stable releases, so it's not terribly useful to talk about them here and you can't really infer much about when the change was introduced. Please can you refer to the commit instead? I think you want:
commit b2eed9b58811 ("arm64/kernel: kaslr: reduce module randomization range to 2 GB")
Quoted 1 line
(see /arch/arm64/kernel/kaslr.c). This updates the
(you can remove the "see ..." part as it's obvious once you refer to the commit.
Quoted 2 lines
config description for
RANDOMIZE_MODULE_REGION_FULLin /arch/arm64/Kconfig to reflect this.
There's no need to say "This...". Documentation/process/submitting-patches.rst has a bit about how to write commit messages, but I suggest changing this last sentence to:
Fix the stale Kconfig entry for RANDOMIZE_MODULE_REGION_FULL.
Quoted 13 lines
Signed-off-by Ross Meikleham <[email protected]>--- arch/arm64/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/Kconfig +0
-0@@ -1782,11 +1782,11 @@ config RANDOMIZE_BASE If unsure, say N. config RANDOMIZE_MODULE_REGION_FULL
arch/arm64/Kconfig config RANDOMIZE_BASE · line 1792
Quoted 10 lines
arch/arm64/Kconfig +2
-2- bool "Randomize the module region over a 4 GB range" + bool "Randomize the module region over a 2 GB range" depends on RANDOMIZE_BASE default y help - Randomizes the location of the module region inside a 4 GB window + Randomizes the location of the module region inside a 2 GB window covering the core kernel. This way, it is less likely for modules to leak information about the location of core kernel data structures but it does imply that function calls between modules and the core
Patch looks fine. Please send a v2 with the commit message sorted out and I can queue it as a fix.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel