phy: sun4i-usb: Use power efficient workqueue for debounce and poll
Subsystems (2)
PATCH 3/3 phy: sun4i-usb: Use power efficient workqueue for debounce and poll
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
--- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/phy/allwinner/phy-sun4i-usb.c +7 -7
@@ -326,7 +326,7 @@ static int sun4i_usb_phy_init(struct phy *_phy)/* Force ISCR and cable state updates */ data->id_det =-1 ; data->vbus_det =-1 ; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 ); }return 0 ;
@@ -444,7 +444,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)/* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */ if (phy->index ==0 &&sun4i_usb_phy0_poll (data)) -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return 0 ; }
@@ -465,7 +465,7 @@ static int sun4i_usb_phy_power_off(struct phy *_phy)* Vbus gpio to not trigger an edge irq on Vbus off, so force a rescan. */ if (phy->index ==0 && !sun4i_usb_phy0_poll (data)) -mod_delayed_work (system_wq, &data->detect,POLL_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,POLL_TIME );return 0 ; }
@@ -504,7 +504,7 @@ static int sun4i_usb_phy_set_mode(struct phy *_phy, data->id_det =-1 ;/* Force reprocessing of id */ data->force_session_end = true; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 );return 0 ; }
@@ -616,7 +616,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work)extcon_set_state_sync (data->extcon,EXTCON_USB , vbus_det);if (sun4i_usb_phy0_poll (data)) -queue_delayed_work (system_wq, &data->detect,POLL_TIME ); +queue_delayed_work (system_power_efficient_wq, &data->detect,POLL_TIME ); }static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq (int irq,void *dev_id)
@@ -624,7 +624,7 @@ static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq(int irq, void *dev_id)struct sun4i_usb_phy_data *data = dev_id;/* vbus or id changed, let the pins settle and then scan them */ -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return IRQ_HANDLED ; }
@@ -638,7 +638,7 @@ static int sun4i_usb_phy0_vbus_notify(struct notifier_block *nb,/* Properties on the vbus_power_supply changed, scan vbus_det */ if (val ==PSY_EVENT_PROP_CHANGED && psy == data->vbus_power_supply) -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return NOTIFY_OK ; }
Signature · 1 line
2.28.0
Quoted 7 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Signed-off-by Yangtao Li <[email protected]>
Thanks!
Maxime
Samuel Holland
maintainerQuoted 25 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Signed-off-by Yangtao Li <[email protected]>--- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/phy/allwinner/phy-sun4i-usb.c +1
-1@@ -326,7 +326,7 @@ static int sun4i_usb_phy_init(struct phy *_phy)/* Force ISCR and cable state updates */ data->id_det =-1 ; data->vbus_det =-1 ; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 ); }return 0 ;
drivers/phy/allwinner/phy-sun4i-usb.c static int sun4i_usb_phy_power_on(struct phy *_phy) · line 445
Quoted 2 lines
drivers/phy/allwinner/phy-sun4i-usb.c +0
-0@@ -444,7 +444,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)/* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */
This doesn't sound like "not performance critical" to me. My understanding is the debouncing has a deadline from the USB spec. Maybe this is more flexible than the comment makes it sound?
Quoted 52 lines
drivers/phy/allwinner/phy-sun4i-usb.c +6
-6if (phy->index ==0 &&sun4i_usb_phy0_poll (data)) -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return 0 ; }@@ -465,7 +465,7 @@ static int sun4i_usb_phy_power_off(struct phy *_phy)* Vbus gpio to not trigger an edge irq on Vbus off, so force a rescan. */ if (phy->index ==0 && !sun4i_usb_phy0_poll (data)) -mod_delayed_work (system_wq, &data->detect,POLL_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,POLL_TIME );return 0 ; }@@ -504,7 +504,7 @@ static int sun4i_usb_phy_set_mode(struct phy *_phy, data->id_det =-1 ;/* Force reprocessing of id */ data->force_session_end = true; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 );return 0 ; }@@ -616,7 +616,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work)extcon_set_state_sync (data->extcon,EXTCON_USB , vbus_det);if (sun4i_usb_phy0_poll (data)) -queue_delayed_work (system_wq, &data->detect,POLL_TIME ); +queue_delayed_work (system_power_efficient_wq, &data->detect,POLL_TIME ); }static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq (int irq,void *dev_id)@@ -624,7 +624,7 @@ static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq(int irq, void *dev_id)struct sun4i_usb_phy_data *data = dev_id;/* vbus or id changed, let the pins settle and then scan them */ -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return IRQ_HANDLED ; }@@ -638,7 +638,7 @@ static int sun4i_usb_phy0_vbus_notify(struct notifier_block *nb,/* Properties on the vbus_power_supply changed, scan vbus_det */ if (val ==PSY_EVENT_PROP_CHANGED && psy == data->vbus_power_supply) -mod_delayed_work (system_wq, &data->detect,DEBOUNCE_TIME ); +mod_delayed_work (system_power_efficient_wq, &data->detect,DEBOUNCE_TIME );return NOTIFY_OK ; }
HI,
Quoted 25 lines · Samuel Holland
Quoted 23 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Signed-off-by Yangtao Li <[email protected]>--- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/phy/allwinner/phy-sun4i-usb.c +1
-1@@ -326,7 +326,7 @@ static int sun4i_usb_phy_init(struct phy *_phy)/* Force ISCR and cable state updates */ data->id_det =-1 ; data->vbus_det =-1 ; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 ); }
Quoted 8 lines
drivers/phy/allwinner/phy-sun4i-usb.c static int sun4i_usb_phy_power_on(struct phy *_phy) · line 445
Quoted 4 lines
drivers/phy/allwinner/phy-sun4i-usb.c +0
-0return 0 ;@@ -444,7 +444,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)/* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */ This doesn't sound like "not performance critical" to me. My understanding is the debouncing has a deadline from the USB spec. Maybe this is more flexible than the comment makes it sound?
According to my understanding, the more meaning of performance here comes from cache locality.
Quoted 24 lines · Samuel Holland
Quoted 23 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Signed-off-by Yangtao Li <[email protected]>--- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/phy/allwinner/phy-sun4i-usb.c +1
-1@@ -326,7 +326,7 @@ static int sun4i_usb_phy_init(struct phy *_phy)/* Force ISCR and cable state updates */ data->id_det =-1 ; data->vbus_det =-1 ; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 ); }
Quoted 8 lines
drivers/phy/allwinner/phy-sun4i-usb.c static int sun4i_usb_phy_power_on(struct phy *_phy) · line 445
Quoted 4 lines
drivers/phy/allwinner/phy-sun4i-usb.c +0
-0return 0 ;@@ -444,7 +444,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)/* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */ This doesn't sound like "not performance critical" to me. My understanding is the debouncing has a deadline from the USB spec. Maybe this is more flexible than the comment makes it sound?
It's not really clear to me what the power_efficient workqueue brings to the table exactly from the comments on WQ_POWER_EFFICIENT (and the associated gmane link is long dead).
It's only effect seems to be that it sets WQ_UNBOUND when the proper command line option is set, and WQ_UNBOUND allows for the scheduled work to run on any CPU instead of the local one.
Given that we don't have any constraint on the CPU here, and the CPU locality shouldn't really make any difference, I'm not sure we should expect any meaningful difference.
This is also what the rest of the similar drivers seem to be using:
https://elixir.bootlin.com/linux/v5.10-rc3/source/drivers/usb/common/usb-conn-gpio.c#L119
https://elixir.bootlin.com/linux/v5.10-rc3/source/drivers/usb/core/hub.c#L1254
Maxime
Quoted 42 lines · Maxime Ripard
Quoted 24 lines · Samuel Holland
Quoted 23 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Signed-off-by Yangtao Li <[email protected]>--- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/phy/allwinner/phy-sun4i-usb.c +1
-1@@ -326,7 +326,7 @@ static int sun4i_usb_phy_init(struct phy *_phy)/* Force ISCR and cable state updates */ data->id_det =-1 ; data->vbus_det =-1 ; -queue_delayed_work (system_wq, &data->detect,0 ); +queue_delayed_work (system_power_efficient_wq, &data->detect,0 ); }Quoted 8 lines
drivers/phy/allwinner/phy-sun4i-usb.c static int sun4i_usb_phy_power_on(struct phy *_phy) · line 445
Quoted 4 lines
drivers/phy/allwinner/phy-sun4i-usb.c +0
-0return 0 ;@@ -444,7 +444,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)/* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */ This doesn't sound like "not performance critical" to me. My understanding is the debouncing has a deadline from the USB spec. Maybe this is more flexible than the comment makes it sound?
It's not really clear to me what the
power_efficientworkqueue brings to the table exactly from the comments onWQ_POWER_EFFICIENT(and the associated gmane link is long dead).It's only effect seems to be that it sets
WQ_UNBOUNDwhen the proper command line option is set, andWQ_UNBOUNDallows for the scheduled work to run on any CPU instead of the local one.
Quoted 7 lines
Given that we don't have any constraint on the CPU here, and the CPU locality shouldn't really make any difference, I'm not sure we should expect any meaningful difference.
This is also what the rest of the similar drivers seem to be using:
https://elixir.bootlin.com/linux/v5.10-rc3/source/drivers/usb/common/usb-conn-gpio.c#L119
https://elixir.bootlin.com/linux/v5.10-rc3/source/drivers/usb/core/hub.c#L1254
Thanks for the explanation. Then the patch looks fine to me.
Cheers,
Samuel
Quoted 5 lines · Frank Lee
From: Yangtao Li <[email protected]>
The debounce and poll time is generally quite long and the work not performance critical so allow the scheduler to run the work anywhere rather than in the normal per-CPU workqueue.
Applied, thanks
Signature · 1 line
~Vinod