amd/display/amdgpu_dm: delete same check in if condition
Subsystems (3)
PATCH 1/1 amd/display/amdgpu_dm: delete same check in if condition
In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) encoder =amdgpu_dm_connector_to_encoder (connector); -if (!edid || !drm_edid_is_valid (edid)) { +if (!drm_edid_is_valid (edid)) { amdgpu_dm_connector->num_modes =drm_add_modes_noedid (connector,640 ,480 ); }else {
Signature · 1 line
2.29.0
Quoted 5 lines · Bernard Zhao
In function
amdgpu_dm_connector_get_modes,drm_edid_is_validwill check weather (!edid), no need to check again in the if branch.Signed-off-by Bernard Zhao <[email protected]>
Harry
Quoted 10 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) · line 6358
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-1@@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) encoder =amdgpu_dm_connector_to_encoder (connector); -if (!edid || !drm_edid_is_valid (edid)) { +if (!drm_edid_is_valid (edid)) { amdgpu_dm_connector->num_modes =drm_add_modes_noedid (connector,640 ,480 ); }else {
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 24 lines · Harry Wentland
Quoted 5 lines · Bernard Zhao
In function
amdgpu_dm_connector_get_modes,drm_edid_is_validwill check weather (!edid), no need to check again in the if branch.Signed-off-by Bernard Zhao <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 12 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0@@ -6352,7 +6352,7 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) encoder =amdgpu_dm_connector_to_encoder (connector);
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_connector_get_modes(struct drm_connector *connector) · line 6358
Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-1-if (!edid || !drm_edid_is_valid (edid)) { +if (!drm_edid_is_valid (edid)) { amdgpu_dm_connector->num_modes =drm_add_modes_noedid (connector,640 ,480 ); }else {_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx