Skip to contentSkip to conversation

devtools: fix directory filter in forbidden token check

PATCH Applied David Marchand 2 participants 2 messages Nov 10, 2020 – Nov 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtools: fix directory filter in forbidden token check

checkpatches.sh current complains on a patch [1] adding ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib and drivers directories:

Warning in examples/ethtool/ethtool-app/Makefile:
Using experimental build flag for in-tree compilation

The regexp on entering files concerned by this filter is incorrect. In the [1] case, the file full name is matched against "app" rather than "+++ b/app".

1: https://patchwork.dpdk.org/patch/83902/

Fixes 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
---
 devtools/check-forbidden-tokens.awk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
devtools/check-forbidden-tokens.awk +1 -1
index f86cbe8dc1..61ba707c9b 100755
@@ -54,7 +54,7 @@ BEGIN {
 	}
 	for (i in deny_folders) {
 		re = "^\\+\\+\\+ b/" deny_folders[i];
-		if ($0 ~ deny_folders[i]) {
+		if ($0 ~ re) {
 			in_file = 1
 			last_file = $0
 		}
Signature · 1 line
2.23.0
#1 lore raw

10/11/2020 16:40, David Marchand:

Quoted 11 lines

checkpatches.sh current complains on a patch [1] adding ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib and drivers directories:

Warning in examples/ethtool/ethtool-app/Makefile:
Using experimental build flag for in-tree compilation

The regexp on entering files concerned by this filter is incorrect. In the [1] case, the file full name is matched against "app" rather than "+++ b/app".

Quoted 6 lines

1: https://patchwork.dpdk.org/patch/83902/

Fixes 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")

Applied, thanks