Skip to contentSkip to conversation

cosa: Add missing kfree in error path of cosa_write

PATCH Applied Wang Hai 3 participants 3 messages Nov 10, 2020 – Nov 12, 2020

Subsystems (2)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 cosa: Add missing kfree in error path of cosa_write

If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/net/wan/cosa.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wan/cosa.c +1 -0
index f8aed0696d77..2369ca250cd6 100644
@@ -889,6 +889,7 @@ static ssize_t cosa_write(struct file *file,
 			chan->tx_status = 1;
 			spin_unlock_irqrestore(&cosa->lock, flags);
 			up(&chan->wsem);
+			kfree(kbuf);
 			return -ERESTARTSYS;
 		}
 	}
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Wang Hai wrote:
: If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a : corresponding kfree() in exception handling. Thus add kfree() for this : function implementation.

Looks correct, thanks.

That said, COSA is an ancient ISA bus device designed in late 1990s, I doubt anybody is still using it. I still do have one or two of these cards myself, but no computer with ISA bus to use them.

-Yenya

:
: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
: Reported-by: Hulk Robot <[email protected]>
: Signed-off-by: Wang Hai <[email protected]>
: ---
: drivers/net/wan/cosa.c | 1 +
: 1 file changed, 1 insertion(+)
:
: diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c : index f8aed0696d77..2369ca250cd6 100644
: --- a/drivers/net/wan/cosa.c
: +++ b/drivers/net/wan/cosa.c
: @@ -889,6 +889,7 @@ static ssize_t cosa_write(struct file *file,

:  			chan->tx_status = 1;
:  			spin_unlock_irqrestore(&cosa->lock, flags);
:  			up(&chan->wsem);
: +			kfree(kbuf);
:  			return -ERESTARTSYS;
:  		}
:  	}

: --
: 2.17.1

Signature · 4 lines
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| http://www.fi.muni.cz/~kas/                         GPG: 4096R/A45477D5 |
    We all agree on the necessity of compromise. We just can't agree on
    when it's necessary to compromise.                     --Larry Wall
maintainer Applied
#2 lore raw
Quoted 6 lines · On Tue, 10 Nov 2020 17:38:09 +0100 Jan Kasprzak wrote:

Wang Hai wrote:
: If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a : corresponding kfree() in exception handling. Thus add kfree() for this : function implementation.

Applied, thanks!

Quoted 3 lines

That said, COSA is an ancient ISA bus device designed in late 1990s, I doubt anybody is still using it. I still do have one or two of these cards myself, but no computer with ISA bus to use them.

Maybe we can move it out to staging or just remove it?