net/iavf: fix cannot release mbufs issue
PATCH 1/1 net/iavf: fix cannot release mbufs issue
In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs, rxq->rxrearm_nb is given the value of rx descriptor number at last. However, since the process to release and allocate mbufs lacks the initialization of rxrearm_nb, if we try to release mbufs next time, it will return without releasing directly. In this patch, rxrearm_nb is initialized to be zero in rx queue reset.
--- drivers/net/iavf/iavf_rxtx.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/iavf/iavf_rxtx.c +1 -0
@@ -194,6 +194,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) rxq->nb_rx_hold =0 ; rxq->pkt_first_seg =NULL ; rxq->pkt_last_seg =NULL ; + rxq->rxrearm_nb =0 ; } static inline void
Signature · 1 line
2.17.1
Quoted 18 lines
-----Original Message-----
From: Xu, Ting <[email protected]>
Sent: Wednesday, November 11, 2020 11:07 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Xu, Ting <[email protected]>; [email protected]
Subject: [PATCH v1] net/iavf: fix cannot release mbufs issueIn the function
_iavf_rx_queue_release_mbufs_vecto release rx mbufs,rxq->rxrearm_nbis given the value of rx descriptor number at last. However, since the process to release and allocate mbufs lacks the initialization ofrxrearm_nb, if we try to release mbufs next time, it will return without releasing directly. In this patch,rxrearm_nbis initialized to be zero in rx queue reset.
Quoted 4 lines
Fixes 319c421f3890 ("net/avf: enable SSE Rx Tx")Signed-off-by Ting Xu <[email protected]>
Zhang, Qi Z
AppliedQuoted 28 lines
-----Original Message-----
From: Wu, Jingjing <[email protected]>
Sent: Wednesday, November 11, 2020 1:16 PM
To: Xu, Ting <[email protected]>; [email protected]
Cc: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>; [email protected]
Subject: RE: [PATCH v1] net/iavf: fix cannot release mbufs issueQuoted 16 lines
-----Original Message-----
From: Xu, Ting <[email protected]>
Sent: Wednesday, November 11, 2020 11:07 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Xu, Ting <[email protected]>; [email protected]
Subject: [PATCH v1] net/iavf: fix cannot release mbufs issueIn the function
_iavf_rx_queue_release_mbufs_vecto release rx mbufs,rxq->rxrearm_nbis given the value of rx descriptor number at last. However, since the process to release and allocate mbufs lacks the initialization ofrxrearm_nb, if we try to release mbufs next time, it will return without releasing directly. In this patch,rxrearm_nbis initialized to be zero in rx queue reset.
Quoted 6 lines
Quoted 4 lines
Fixes 319c421f3890 ("net/avf: enable SSE Rx Tx")Signed-off-by Ting Xu <[email protected]>Acked-by Jingjing Wu <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi