i2c: mlxbf: Fix the return check of devm_ioremapm and ioremap
Subsystems (2)
PATCH 1/1 i2c: mlxbf: Fix the return check of devm_ioremapm and ioremap
devm_ioremapm and ioremap may return NULL which cannot be checked by IS_ERR.
Signed-off-by Wang Xiaojun <[email protected]>
Reported-by Hulk Robot <[email protected]>
--- drivers/i2c/busses/i2c-mlxbf.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/i2c/busses/i2c-mlxbf.c +6 -6
@@ -1258,9 +1258,9 @@ static int mlxbf_i2c_get_gpio(struct platform_device *pdev,return -EFAULT ; gpio_res->io =devm_ioremap (dev, params->start, size); -if (IS_ERR (gpio_res->io)) { +if (!gpio_res->io) {devm_release_mem_region (dev, params->start, size); -return PTR_ERR (gpio_res->io); +return -ENOMEM ; }return 0 ;
@@ -1323,9 +1323,9 @@ static int mlxbf_i2c_get_corepll(struct platform_device *pdev,return -EFAULT ; corepll_res->io =devm_ioremap (dev, params->start, size); -if (IS_ERR (corepll_res->io)) { +if (!corepll_res->io) {devm_release_mem_region (dev, params->start, size); -return PTR_ERR (corepll_res->io); +return -ENOMEM ; }return 0 ;
@@ -1717,9 +1717,9 @@ static int mlxbf_i2c_init_coalesce(struct platform_device *pdev,return -EFAULT ; coalesce_res->io =ioremap (params->start, size); -if (IS_ERR (coalesce_res->io)) { +if (!coalesce_res->io) {release_mem_region (params->start, size); -return PTR_ERR (coalesce_res->io); +return -ENOMEM ; } priv->coalesce = coalesce_res;
Signature · 1 line
2.25.1
Quoted 4 lines
devm_ioremapmand ioremap may return NULL which cannot be checked byIS_ERR.
devm_ioremap
Quoted 49 lines
Signed-off-by Wang Xiaojun <[email protected]>Reported-by Hulk Robot <[email protected]>--- drivers/i2c/busses/i2c-mlxbf.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/i2c/busses/i2c-mlxbf.c +2
-2@@ -1258,9 +1258,9 @@ static int mlxbf_i2c_get_gpio(struct platform_device *pdev, return -EFAULT ; gpio_res->io =devm_ioremap (dev, params->start, size); -if (IS_ERR (gpio_res->io)) { +if (!gpio_res->io) {devm_release_mem_region (dev, params->start, size); -return PTR_ERR (gpio_res->io); +return -ENOMEM ; }drivers/i2c/busses/i2c-mlxbf.c +2
-2return 0 ;@@ -1323,9 +1323,9 @@ static int mlxbf_i2c_get_corepll(struct platform_device *pdev, return -EFAULT ; corepll_res->io =devm_ioremap (dev, params->start, size); -if (IS_ERR (corepll_res->io)) { +if (!corepll_res->io) {devm_release_mem_region (dev, params->start, size); -return PTR_ERR (corepll_res->io); +return -ENOMEM ; }drivers/i2c/busses/i2c-mlxbf.c +2
-2return 0 ;@@ -1717,9 +1717,9 @@ static int mlxbf_i2c_init_coalesce(struct platform_device *pdev, return -EFAULT ; coalesce_res->io =ioremap (params->start, size); -if (IS_ERR (coalesce_res->io)) { +if (!coalesce_res->io) {release_mem_region (params->start, size); -return PTR_ERR (coalesce_res->io); +return -ENOMEM ; }
Quoted 3 lines
priv->coalesce=coalesce_res;
--
2.25.1
Acked-by Khalil Blaiech <[email protected]>
Thanks.
Quoted 5 lines · Wang Xiaojun
devm_ioremapmand ioremap may return NULL which cannot be checked byIS_ERR.Signed-off-by Wang Xiaojun <[email protected]>Reported-by Hulk Robot <[email protected]>
Please fix the typo found by Khalil and resend.