Skip to contentSkip to conversation

net/iavf: fix RSS queue region size exceeds

PATCH Applied Ting Xu 2 participants 2 messages Nov 11, 2020 Network drivers

lore
Share & tools
lore

Ting Xu

author
#0 lore raw

PATCH 1/1 net/iavf: fix RSS queue region size exceeds

When a rule is set to do RSS to redirect flows to a group of queues, the queue region size should not be larger than the max RSS queue region supported by HW. This patch added the step to check the queue region size, and report failure if the size does not meet the requirement.

Fixes e436cd43835b ("net/iavf: negotiate large VF and request more queues")
---
 drivers/net/iavf/iavf_fdir.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/net/iavf/iavf_fdir.c +8 -0
index f584e5624c..d683a468c1 100644
@@ -256,6 +256,7 @@ iavf_fdir_parse_action_qregion(struct iavf_adapter *ad,
 			const struct rte_flow_action *act,
 			struct virtchnl_filter_action *filter_action)
 {
+	struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(ad);
 	const struct rte_flow_action_rss *rss = act->conf;
 	uint32_t i;
 
@@ -300,6 +301,13 @@ iavf_fdir_parse_action_qregion(struct iavf_adapter *ad,
 		return -rte_errno;
 	}
 
+	if (rss->queue_num > vf->max_rss_qregion) {
+		rte_flow_error_set(error, EINVAL,
+				RTE_FLOW_ERROR_TYPE_ACTION, act,
+				"The region size cannot be large than the supported max RSS queue region");
+		return -rte_errno;
+	}
+
 	filter_action->act_conf.queue.index = rss->queue[0];
 	filter_action->act_conf.queue.region = rte_fls_u32(rss->queue_num) - 1;
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 15 lines

-----Original Message-----
From: Xu, Ting <[email protected]>
Sent: Wednesday, November 11, 2020 2:43 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]
Subject: [PATCH v1] net/iavf: fix RSS queue region size exceeds

When a rule is set to do RSS to redirect flows to a group of queues, the queue region size should not be larger than the max RSS queue region supported by HW. This patch added the step to check the queue region size, and report failure if the size does not meet the requirement.

Quoted 4 lines
Fixes e436cd43835b ("net/iavf: negotiate large VF and request more queues")

Applied to dpdk-next-net-intel.

Thanks
Qi