m4: Remove workaround for old pkg-config
PATCH 1/1 m4: Remove workaround for old pkg-config
fix was for 0.24 which is probably old enough (released in 2010; problematic 0.23 was released 2008).
---
Travis CI:
https://travis-ci.org/github/pevik/ltp/builds/742685737
m4/ltp-tirpc.m4 | 5 ----- 1 file changed, 5 deletions(-)
m4/ltp-tirpc.m4 +0 -5
@@ -22,9 +22,4 @@ AC_DEFUN([LTP_CHECK_TIRPC], [ if test "x$have_libtirpc" = "xyes" -o "x$have_rpc_glibc" = "xyes"; then AC_SUBST(HAVE_RPC, 1) fi - - dnl fix for old pkg-config (< 0.24) - dnl https://autotools.io/pkgconfig/pkg_check_modules.html - AC_SUBST(TIRPC_CFLAGS) - AC_SUBST(TIRPC_LIBS) ])
Signature · 1 line
2.29.2
PATCH 1/1 m4: Remove workaround for old pkg-config
Hi!
Looks good to me, let's apply this unless anybody complains.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 m4: Remove workaround for old pkg-config
Hi,
Quoted 3 lines · Cyril Hrubis
Hi!
Looks good to me, let's apply this unless anybody complains.
Hold on, please.
Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in all respective Makefiles? Otherwise, it will fail like the Travis CI job I guess.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20201111/e805a9bf/attachment.htm>
PATCH 1/1 m4: Remove workaround for old pkg-config
Hi,
Quoted 11 lines · Cyril Hrubis
Quoted 3 lines
Hi!
Looks good to me, let's apply this unless anybody complains.Hold on, please.
Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in all respective Makefiles? Otherwise, it will fail like the Travis CI job I guess.
Correct, currently would fail without it.
https://travis-ci.org/github/pevik/ltp/builds/742685737
I'll send v2 where I implement this.
Kind regards,
Petr
PATCH 1/1 m4: Remove workaround for old pkg-config
Quoted 10 lines · Petr Vorel
Hi,
Quoted 7 lines · Cyril Hrubis
Quoted 3 lines
Hi!
Looks good to me, let's apply this unless anybody complains.Hold on, please.
Quoted 9 lines
Quoted 3 lines
Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in all respective Makefiles? Otherwise, it will fail like the Travis CI job I guess.
Correct, currently would fail without it.
https://travis-ci.org/github/pevik/ltp/builds/742685737I'll send v2 where I implement this.
Thanks, I modified base on your patch, test result FYI
https://github.com/wangli5665/ltp/commit/dad10021771101e7fdd416af894be7484fcb7a52
https://travis-ci.org/github/wangli5665/ltp/builds/742909686
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20201111/5bf743f8/attachment.htm>
PATCH 1/1 m4: Remove workaround for old pkg-config
Hi Li,
Quoted 19 lines · Petr Vorel
Quoted 17 lines
Hi,
Quoted 11 lines · Cyril Hrubis
Quoted 3 lines
Hi!
Looks good to me, let's apply this unless anybody complains.Hold on, please.
Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in all respective Makefiles? Otherwise, it will fail like the Travis CI job I guess.
Correct, currently would fail without it.
https://travis-ci.org/github/pevik/ltp/builds/742685737
Quoted 6 lines
Quoted 1 line
I'll send v2 where I implement this.
Thanks, I modified base on your patch, test result FYI
https://github.com/wangli5665/ltp/commit/dad10021771101e7fdd416af894be7484fcb7a52
https://travis-ci.org/github/wangli5665/ltp/builds/742909686
You implemented it, thank you. Please push it after Travis finishes.
Just an explanation, why I introduced TIRPC_{CFLAGS,LIBS}: there was Sun-RPC implementation in glibc, which I wanted to test. Thus variable name without "LIB" to say, that it could be also glibc.
But Sun-RPC is broken, was deprecated and my patchset which removes it from glibc was accepted and released in glibc 2.32. Thus I'm going to send patch which reverts the commit 60b20c428060b20c428 ("rpc: Enable and fix build basic RPC tests with glibc SunRPC").
My long term goal: fix and cleanup RPC tests (some are failing also with libtirpc), move these tests to libtirpc sources (they needs to be cleaned. And also I'd prefer to not put there whole LTP library, but just needed subset).
Kind regards,
Petr
PATCH 1/1 m4: Remove workaround for old pkg-config
Hi Petr,
Quoted 24 lines · Petr Vorel
Hi Li,
Quoted 5 lines · Petr Vorel
Quoted 4 lines
Hi,
Quoted 1 line
On Wed, Nov 11, 2020 at 5:38 PM Cyril Hrubis <[email protected]>
Quoted 7 lines · wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
Hi!
Looks good to me, let's apply this unless anybody complains.Hold on, please.
Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in
all
Quoted 1 line
Quoted 1 line
Quoted 1 line
respective Makefiles? Otherwise, it will fail like the Travis CI job
I
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
guess.
Correct, currently would fail without it.
https://travis-ci.org/github/pevik/ltp/builds/742685737
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
I'll send v2 where I implement this.
Thanks, I modified base on your patch, test result FYI
https://github.com/wangli5665/ltp/commit/dad10021771101e7fdd416af894be7484fcb7a52
You implemented it, thank you. Please push it after Travis finishes.
Pushed, and thanks for the explanation.
Quoted 22 lines
Just an explanation, why I introduced TIRPC_{CFLAGS,LIBS}: there was Sun-RPC
implementation in glibc, which I wanted to test. Thus variable name without "LIB" to say, that it could be also glibc.But Sun-RPC is broken, was deprecated and my patchset which removes it from glibc was accepted and released in glibc 2.32. Thus I'm going to send patch which reverts the commit
60b20c428060b20c428("rpc: Enable and fix build basic
RPC tests with glibc SunRPC").My long term goal: fix and cleanup RPC tests (some are failing also with libtirpc), move these tests to libtirpc sources (they needs to be cleaned. And
also I'd prefer to not put there whole LTP library, but just needed subset).Kind regards,
Petr
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20201111/6b807d74/attachment.htm>