Skip to contentSkip to conversation

riscv: Drop a duplicated PAGE_KERNEL_EXEC

PATCH In review Kefeng Wang 4 participants 5 messages Nov 11, 2020 – Jan 9, 2021 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: Drop a duplicated PAGE_KERNEL_EXEC

commit b91540d52a08 ("RISC-V: Add EFI runtime services") add a duplicated PAGE_KERNEL_EXEC, kill it.

---
 arch/riscv/include/asm/pgtable.h | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -1
index 183f1f4b2ae6..73e8b5e5bb65 100644
@@ -99,7 +99,6 @@
 				| _PAGE_DIRTY)
 
 #define PAGE_KERNEL		__pgprot(_PAGE_KERNEL)
-#define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ	__pgprot(_PAGE_KERNEL & ~_PAGE_WRITE)
 #define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ_EXEC	__pgprot((_PAGE_KERNEL & ~_PAGE_WRITE) \
Signature · 7 lines
2.26.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Kefeng Wang

commit b91540d52a08 ("RISC-V: Add EFI runtime services") add a duplicated PAGE_KERNEL_EXEC, kill it.

Quoted 20 lines
---
 arch/riscv/include/asm/pgtable.h | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -2
index 183f1f4b2ae6..73e8b5e5bb65 100644
@@ -99,7 +99,6 @@
                                | _PAGE_DIRTY)
 
 #define PAGE_KERNEL            __pgprot(_PAGE_KERNEL)
-#define PAGE_KERNEL_EXEC       __pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ       __pgprot(_PAGE_KERNEL & ~_PAGE_WRITE)
 #define PAGE_KERNEL_EXEC       __pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ_EXEC  __pgprot((_PAGE_KERNEL & ~_PAGE_WRITE) \
--

2.26.2

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

Reviewed-by on v1 1/1
#2 lore raw
In reply to Kefeng Wang
Quoted 25 lines · Kefeng Wang

commit b91540d52a08 ("RISC-V: Add EFI runtime services") add a duplicated PAGE_KERNEL_EXEC, kill it.

---
 arch/riscv/include/asm/pgtable.h | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -2
index 183f1f4b2ae6..73e8b5e5bb65 100644
@@ -99,7 +99,6 @@
                                | _PAGE_DIRTY)
 
 #define PAGE_KERNEL            __pgprot(_PAGE_KERNEL)
-#define PAGE_KERNEL_EXEC       __pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ       __pgprot(_PAGE_KERNEL & ~_PAGE_WRITE)
 #define PAGE_KERNEL_EXEC       __pgprot(_PAGE_KERNEL | _PAGE_EXEC)
 #define PAGE_KERNEL_READ_EXEC  __pgprot((_PAGE_KERNEL & ~_PAGE_WRITE) \
--

2.26.2

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

Apologies for the oversight. Thanks for the quick fix :).

Signature · 7 lines
Regards,
Atish

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#3 lore raw
In reply to Kefeng Wang

Hi Palmer,  kindly ping..

Quoted 13 lines · Kefeng Wang

commit b91540d52a08 ("RISC-V: Add EFI runtime services") add a duplicated PAGE_KERNEL_EXEC, kill it.

---
  arch/riscv/include/asm/pgtable.h | 1 -
  1 file changed, 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -0
index 183f1f4b2ae6..73e8b5e5bb65 100644

arch/riscv/include/asm/pgtable.h line 104

Quoted 7 lines
arch/riscv/include/asm/pgtable.h +0 -1
@@ -99,7 +99,6 @@
  				| _PAGE_DIRTY)
 
  #define PAGE_KERNEL		__pgprot(_PAGE_KERNEL)
-#define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
  #define PAGE_KERNEL_READ	__pgprot(_PAGE_KERNEL & ~_PAGE_WRITE)
  #define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
  #define PAGE_KERNEL_READ_EXEC	__pgprot((_PAGE_KERNEL & ~_PAGE_WRITE) \

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

maintainer
#4 lore raw
Quoted 18 lines · On Mon, 14 Dec 2020 03:30:19 PST (-0800), [email protected] wrote:

Hi Palmer,  kindly ping..

Quoted 15 lines · Kefeng Wang

commit b91540d52a08 ("RISC-V: Add EFI runtime services") add a duplicated PAGE_KERNEL_EXEC, kill it.

---
  arch/riscv/include/asm/pgtable.h | 1 -
  1 file changed, 1 deletion(-)
arch/riscv/include/asm/pgtable.h +0 -0
index 183f1f4b2ae6..73e8b5e5bb65 100644
@@ -99,7 +99,6 @@
  				| _PAGE_DIRTY)
 
Quoted 5 lines

arch/riscv/include/asm/pgtable.h line 104

Quoted 5 lines
arch/riscv/include/asm/pgtable.h +0 -1
  #define PAGE_KERNEL		__pgprot(_PAGE_KERNEL)
-#define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
  #define PAGE_KERNEL_READ	__pgprot(_PAGE_KERNEL & ~_PAGE_WRITE)
  #define PAGE_KERNEL_EXEC	__pgprot(_PAGE_KERNEL | _PAGE_EXEC)
  #define PAGE_KERNEL_READ_EXEC	__pgprot((_PAGE_KERNEL & ~_PAGE_WRITE) \

Thanks, this is on fixes.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv