net/ixgbe: remove the redundant MAC flag check
PATCH 1/1 net/ixgbe: remove the redundant MAC flag check
The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition of RTE_ETHTYPE_FLAGS_MAC.
--- drivers/net/ixgbe/ixgbe_flow.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/net/ixgbe/ixgbe_flow.c +0 -9
@@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev,if (ret)return ret; -/* Ixgbe doesn't support MAC address. */ -if (filter->flags &RTE_ETHTYPE_FLAGS_MAC ) { -memset (filter,0 ,sizeof (struct rte_eth_ethertype_filter )); -rte_flow_error_set (error,EINVAL , -RTE_FLOW_ERROR_TYPE_ITEM , -NULL ,"Not supported by ethertype filter" ); -return -rte_errno; - } -if (filter->queue >= dev->data->nb_rx_queues) {memset (filter,0 ,sizeof (struct rte_eth_ethertype_filter )); rte_flow_error_set(error, EINVAL,
Signature · 1 line
2.29.2
Quoted 18 lines
-----Original Message-----
From: Wang, Haiyue <[email protected]>
Sent: Thursday, November 12, 2020 10:00 AM
To: [email protected]
Cc: Yigit, Ferruh <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Haiyue <[email protected]>; [email protected]; Guo, Jia <[email protected]>; Zhao1, Wei <[email protected]>; Xing, Beilei <[email protected]>; Wei Dai <[email protected]>; Lu, Wenzhuo <[email protected]>
Subject: [PATCH v1] net/ixgbe: remove the redundant MAC flag checkThe flag of
RTE_ETHTYPE_FLAGS_MAChas been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition ofRTE_ETHTYPE_FLAGS_MAC.
Quoted 4 lines
Fixes eb3539fc8550 ("net/ixgbe: parse ethertype filter")Signed-off-by Haiyue Wang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi