scsi: ufs: Add retry flow for failed hba enabling
Subsystems (2)
PATCH 1/1 scsi: ufs: Add retry flow for failed hba enabling
Once hba enabling is failed, add retry mechanism and in the meanwhile allow vendors to apply specific handlings before the next retry. For example, vendors can do vendor-specific host reset flow in variant function "ufshcd_vops_hce_enable_notify()".
--- drivers/scsi/ufs/ufshcd.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/scsi/ufs/ufshcd.c +10 -4
@@ -4328,8 +4328,10 @@ static inline void ufshcd_hba_stop(struct ufs_hba *hba)*/ static int ufshcd_hba_execute_hce (struct ufs_hba *hba) { -int retry; +int retry_outer =3 ; +int retry_inner; +start:if (!ufshcd_is_hba_active (hba))/* change controller state to "reset state" */ ufshcd_hba_stop (hba);
@@ -4355,13 +4357,17 @@ static int ufshcd_hba_execute_hce(struct ufs_hba *hba)ufshcd_delay_us (hba->vps->hba_enable_delay_us,100 );/* wait for the host controller to complete initialization */ - retry =50 ; + retry_inner =50 ;while (ufshcd_is_hba_active (hba)) { -if (retry) { - retry--; +if (retry_inner) { + retry_inner--; }else {dev_err (hba->dev,"Controller enable failed\n" ); +if (retry_outer) { + retry_outer--; + goto start; + }return -EIO ; }usleep_range (1000 ,1100 );
Signature · 1 line
2.18.0
Quoted 6 lines · Stanley Chu
Once hba enabling is failed, add retry mechanism and in the meanwhile allow vendors to apply specific handlings before the next retry. For example, vendors can do vendor-specific host reset flow in variant function "
ufshcd_vops_hce_enable_notify()".Signed-off-by Stanley Chu <[email protected]>
Quoted 43 lines
--- drivers/scsi/ufs/ufshcd.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)drivers/scsi/ufs/ufshcd.c +3
-1@@ -4328,8 +4328,10 @@ static inline void ufshcd_hba_stop(structufs_hba *hba) */ static int ufshcd_hba_execute_hce (struct ufs_hba *hba) { -int retry; +int retry_outer =3 ; +int retry_inner; +start:if (!ufshcd_is_hba_active (hba))/* change controller state to "reset state" */ drivers/scsi/ufs/ufshcd.c +7
-3ufshcd_hba_stop (hba);@@ -4355,13 +4357,17 @@ static int ufshcd_hba_execute_hce(struct ufs_hba *hba) ufshcd_delay_us(hba->vps->hba_enable_delay_us, 100);/* wait for the host controller to complete initialization */ - retry =50 ; + retry_inner =50 ;while (ufshcd_is_hba_active (hba)) { -if (retry) { - retry--; +if (retry_inner) { + retry_inner--; }else {dev_err (hba->dev,"Controller enable failed\n" ); +if (retry_outer) { + retry_outer--; + goto start; + }return -EIO ; }
usleep_range(1000, 1100);
Martin K. Petersen
AppliedStanley,
Quoted 4 lines
Once hba enabling is failed, add retry mechanism and in the meanwhile allow vendors to apply specific handlings before the next retry. For example, vendors can do vendor-specific host reset flow in variant function "
ufshcd_vops_hce_enable_notify()".
Applied to 5.11/scsi-staging, thanks!
Signature · 6 lines
Martin K. Petersen Oracle Linux Engineering _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Martin K. Petersen
AppliedQuoted 4 lines · Stanley Chu
Once hba enabling is failed, add retry mechanism and in the meanwhile allow vendors to apply specific handlings before the next retry. For example, vendors can do vendor-specific host reset flow in variant function "
ufshcd_vops_hce_enable_notify()".
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: ufs: Add retry flow for failed HBA enabling
https://git.kernel.org/mkp/scsi/c/6081b12ceb7d
Signature · 6 lines
Martin K. Petersen Oracle Linux Engineering _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek