Skip to contentSkip to conversation

nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards

PATCH Applied Robin van der Gracht 3 participants 3 messages Nov 12, 2020 NVMEM framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards

The imx6q_ocotp_data struct is incomplete resulting in a crash when trying to read/blow fuses.

---
 drivers/nvmem/ocotp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/nvmem/ocotp.c +2 -0
index 356e9bf11..cee50955e 100644
@@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
 	.mac_offsets = { MAC_OFFSET_0 },
 	.format_mac = imx_ocotp_format_mac,
 	.set_timing = imx6_ocotp_set_timing,
+	.fuse_blow = imx6_fuse_blow_addr,
+	.fuse_read = imx6_fuse_read_addr,
 };
 
 static struct imx_ocotp_data imx6sl_ocotp_data = {
Signature · 7 lines
2.25.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Reviewed-by on v1 1/1
#1 lore raw

Re: [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp compatible boards

Quoted 14 lines · Robin van der Gracht

The imx6q_ocotp_data struct is incomplete resulting in a crash when trying
to read/blow fuses.

---
 drivers/nvmem/ocotp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/nvmem/ocotp.c +0 -0
index 356e9bf11..cee50955e 100644

drivers/nvmem/ocotp.c static struct imx_ocotp_data imx6q_ocotp_data = { · line 840

Quoted 8 lines
drivers/nvmem/ocotp.c +2 -0
@@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
 	.mac_offsets = { MAC_OFFSET_0 },
 	.format_mac = imx_ocotp_format_mac,
 	.set_timing = imx6_ocotp_set_timing,
+	.fuse_blow = imx6_fuse_blow_addr,
+	.fuse_read = imx6_fuse_read_addr,
 };
 
 static struct imx_ocotp_data imx6sl_ocotp_data = {
Fixes 17cba91885d9 ("nvmem: ocotp: read/write i.MX7 support")

Thanks for the fix,
Rouven

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Applied
#2 lore raw

Re: [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp compatible boards

In reply to Robin van der Gracht
Quoted 7 lines · Robin van der Gracht

The imx6q_ocotp_data struct is incomplete resulting in a crash when trying to read/blow fuses.

---
 drivers/nvmem/ocotp.c | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks

Sascha

Quoted 18 lines
drivers/nvmem/ocotp.c +2 -0
index 356e9bf11..cee50955e 100644
@@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
 	.mac_offsets = { MAC_OFFSET_0 },
 	.format_mac = imx_ocotp_format_mac,
 	.set_timing = imx6_ocotp_set_timing,
+	.fuse_blow = imx6_fuse_blow_addr,
+	.fuse_read = imx6_fuse_read_addr,
 };
 
 static struct imx_ocotp_data imx6sl_ocotp_data = {
Signature · 1 line
2.25.1
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox