Rid W=1 issues from Input
Subsystems (6)
PATCH 2/2 Rid W=1 issues from Input
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
This is the second (and last) of 2 sets.
Lee Jones (15):
input: joystick: xpad: Demote non-conformant kernel-doc header
input: keyboard: samsung-keypad: Remove set but unused variable 'var'
input: misc: mc13783-pwrbutton: File headers are not good candidates
for kernel-doc
input: touchscreen: goodix: Provide some missing function parameter
descriptions
input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'
input: touchscreen: melfas_mip4: Remove a bunch of unused variables
input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
input: touchscreen: surface3_spi: Remove set but unused variable
'timestamp'
input: misc: wm831x-on: Source file headers are not good candidates
for kernel-doc
input: touchscreen: surface3_spi: Fix naming issue with
'surface3_spi_get_gpio_config's header
input: touchscreen: wm97xx-core: Provide missing description for
'status'
input: mouse: synaptics: Demote non-conformant kernel-doc header
input: touchscreen: goodix: Fix misspelling of 'ctx'
input: keyboard: applespi: Provide missing struct 'message'
descriptions
input: mouse: vmmouse: Demote obvious abuse of kernel-doc header
drivers/input/joystick/xpad.c | 2 +- drivers/input/keyboard/applespi.c | 9 +++++++++ drivers/input/keyboard/samsung-keypad.c | 3 +-- drivers/input/misc/mc13783-pwrbutton.c | 2 +- drivers/input/misc/wm831x-on.c | 2 +- drivers/input/mouse/synaptics.c | 2 +- drivers/input/mouse/vmmouse.c | 2 +- drivers/input/touchscreen/goodix.c | 5 ++++- drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- drivers/input/touchscreen/surface3_spi.c | 4 +--- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- drivers/input/touchscreen/wm97xx-core.c | 2 +- 13 files changed, 24 insertions(+), 27 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/15 input: joystick: xpad: Demote non-conformant kernel-doc header
Fixes the following W=1 kernel build warning(s):
drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'xpad' not described in 'xpad_send_led_command' drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'command' not described in 'xpad_send_led_command'
--- drivers/input/joystick/xpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/joystick/xpad.c +1 -1
@@ -1337,7 +1337,7 @@ struct xpad_led {struct usb_xpad *xpad; }; -/** +/* * set the LEDs on Xbox360 / Wireless Controllers * @param command * 0: off
Signature · 1 line
2.25.1
Re: [PATCH 01/15] input: joystick: xpad: Demote non-conformant kernel-doc header
Quoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'xpad' not described in 'xpad_send_led_command'drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'command' not described in 'xpad_send_led_command'
Quoted 14 lines
Cc Dmitry Torokhov <[email protected]>Cc "Łukasz Patron" <[email protected]>Cc Cameron Gutman <[email protected]>Cc Marko Friedemann <[email protected]>Cc Oliver Schwartz <[email protected]>Cc Steven Toth <[email protected]>Cc Franz Lehner <[email protected]>Cc Ivan Hawkes <[email protected]>Cc Dominic Cerquetti <[email protected]>Cc Adam Buchbinder <[email protected]>Cc Jan Kratochvil <[email protected]>Cc Christoph Fritz <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 2/15 input: keyboard: samsung-keypad: Remove set but unused variable 'var'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/keyboard/samsung-keypad.c: In function ‘samsung_keypad_irq’:
drivers/input/keyboard/samsung-keypad.c:149:15: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
--- drivers/input/keyboard/samsung-keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/keyboard/samsung-keypad.c +1 -2
@@ -146,13 +146,12 @@ static irqreturn_t samsung_keypad_irq(int irq, void *dev_id) {struct samsung_keypad *keypad = dev_id;unsigned int row_state[SAMSUNG_MAX_COLS ]; -unsigned int val;bool key_down;pm_runtime_get_sync (&keypad->pdev->dev); do { - val = readl(keypad->base + SAMSUNG_KEYIFSTSCLR); + readl(keypad->base + SAMSUNG_KEYIFSTSCLR); /* Clear interrupt. */ writel(~0x0, keypad->base + SAMSUNG_KEYIFSTSCLR);
Signature · 1 line
2.25.1
Re: [PATCH 02/15] input: keyboard: samsung-keypad: Remove set but unused variable 'var'
Quoted 10 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/samsung-keypad.c: In function ‘samsung_keypad_irq’:
drivers/input/keyboard/samsung-keypad.c:149:15: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Joonyoung Shim <[email protected]>Cc Donghwa Lee <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 3/15 input: misc: mc13783-pwrbutton: File headers are not good candidates for kernel-doc
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/misc/mc13783-pwrbutton.c:32: warning: cannot understand function prototype: 'struct mc13783_pwrb '
--- drivers/input/misc/mc13783-pwrbutton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/mc13783-pwrbutton.c +1 -1
@@ -1,4 +1,4 @@ -/** +/* * Copyright (C) 2011 Philippe Rétornaz * * Based on twl4030-pwrbutton driver by:
Signature · 1 line
2.25.1
Re: [PATCH 03/15] input: misc: mc13783-pwrbutton: File headers are not good candidates for kernel-doc
Quoted 9 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/mc13783-pwrbutton.c:32: warning: cannot understand function prototype: 'structmc13783_pwrb'Cc Dmitry Torokhov <[email protected]>Cc De Schrijver <[email protected]>Cc Felipe Balbi <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 4/15 input: touchscreen: goodix: Provide some missing function parameter descriptions
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg' drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb'
--- drivers/input/touchscreen/goodix.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/input/touchscreen/goodix.c +3 -0
@@ -564,6 +564,7 @@ static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts)* * @ts: goodix_ts_data pointer * @cfg: firmware config data +* @len: config data length */ static int goodix_check_cfg (struct goodix_ts_data *ts,const u8 *cfg,int len) {
@@ -582,6 +583,7 @@ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)* * @ts: goodix_ts_data pointer * @cfg: config firmware to write to device +* @len: config data length */ static int goodix_send_cfg (struct goodix_ts_data *ts,const u8 *cfg,int len) {
@@ -1156,6 +1158,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)/** * goodix_config_cb - Callback to finish device init * +* @cfg: firmware config * @ts: our goodix_ts_data pointer * * request_firmware_wait callback that finishes
Signature · 1 line
2.25.1
Re: [PATCH 04/15] input: touchscreen: goodix: Provide some missing function parameter descriptions
Quoted 8 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg'drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg'drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb'drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb'drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb'
Quoted 8 lines
Cc Bastien Nocera <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc "K. Merker" <[email protected]>Cc authored by <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 5/15 input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’:
drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
--- drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/touchscreen/imx6ul_tsc.c +1 -2
@@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) {struct imx6ul_tsc *tsc = dev_id;u32 coco; -u32 value; coco =readl (tsc->adc_regs +REG_ADC_HS );if (coco &0x01 ) { - value =readl (tsc->adc_regs +REG_ADC_R0 ); +readl (tsc->adc_regs +REG_ADC_R0 );complete (&tsc->completion); }
Signature · 1 line
2.25.1
RE: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'
Quoted 40 lines
-----Original Message-----
From: Lee Jones [mailto:[email protected]]
Sent: 2020年11月12日 19:02
To: [email protected]
Cc: [email protected]; Dmitry Torokhov <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Pengutronix Kernel Team <[email protected]>; Fabio Estevam <[email protected]>; dl-linux-imx <[email protected]>; Haibo Chen <[email protected]>; [email protected]
Subject: [PATCH 05/15] input: touchscreen:imx6ul_tsc: Remove set but unused variable 'value'Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’:
drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set
but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Pengutronix Kernel Team <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP Linux Team <[email protected]>Cc Haibo Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/input/touchscreen/imx6ul_tsc.c +0
-0@@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) {struct imx6ul_tsc *tsc = dev_id;
drivers/input/touchscreen/imx6ul_tsc.c static irqreturn_t adc_irq_fn(int irq, void *dev_id) · line 313
Quoted 10 lines
drivers/input/touchscreen/imx6ul_tsc.c +1
-2u32 coco; -u32 value; coco =readl (tsc->adc_regs +REG_ADC_HS );if (coco &0x01 ) { - value =readl (tsc->adc_regs +REG_ADC_R0 ); +readl (tsc->adc_regs +REG_ADC_R0 );complete (&tsc->completion); }
Quoted 2 lines
--
2.25.1
Re: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'
In reply to Lee JonesQuoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’:
drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
Quoted 9 lines
Cc Dmitry Torokhov <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Pengutronix Kernel Team <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP Linux Team <[email protected]>Cc Haibo Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
Re: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value'
Quoted 16 lines · Dmitry Torokhov
Quoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’:
drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]Quoted 9 lines
Cc Dmitry Torokhov <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Pengutronix Kernel Team <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP Linux Team <[email protected]>Cc Haibo Chen <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 1 line
Applied, thank you.
Good morning Dmitry,
Are you planning on finishing this review?
About half of the patches are unreviewed and there are a couple of open questions on others.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 6/15 input: touchscreen: melfas_mip4: Remove a bunch of unused variables
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]
--- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-)
drivers/input/touchscreen/melfas_mip4.c +0 -11
@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)static void mip4_report_touch (struct mip4_ts *ts,u8 *packet) {int id; -bool hover; -bool palm;bool state;u16 x, y; -u8 pressure_stage =0 ;u8 pressure; -u8 size;u8 touch_major;u8 touch_minor;
@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)case 1 :/* Touch only */ state = packet[0 ] &BIT (7 ); - hover = packet[0 ] &BIT (5 ); - palm = packet[0 ] &BIT (4 ); id = (packet[0 ] &0x0F ) -1 ; x = ((packet[1 ] &0x0F ) <<8 ) | packet[2 ]; y = (((packet[1 ] >>4 ) &0x0F ) <<8 ) | packet[3 ]; pressure = packet[4 ]; - size = packet[5 ];if (ts->event_format ==0 ) { touch_major = packet[5 ]; touch_minor = packet[5 ];
@@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)default :/* Touch + Force(Pressure) */ id = (packet[0 ] &0x0F ) -1 ; - hover = packet[1 ] &BIT (2 ); - palm = packet[1 ] &BIT (1 ); state = packet[1 ] &BIT (0 ); x = ((packet[2 ] &0x0F ) <<8 ) | packet[3 ]; y = (((packet[2 ] >>4 ) &0x0F ) <<8 ) | packet[4 ]; - size = packet[6 ]; - pressure_stage = (packet[7 ] &0xF0 ) >>4 ; pressure = ((packet[7 ] &0x0F ) <<8 ) | packet[8 ]; touch_major = packet[9 ];
Signature · 1 line
2.25.1
Dmitry Torokhov
maintainerRe: [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
Quoted 36 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]Cc Sangwon Jee <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/input/touchscreen/melfas_mip4.c +0
-4@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)static void mip4_report_touch (struct mip4_ts *ts,u8 *packet) {int id; -bool hover; -bool palm;bool state;u16 x, y; -u8 pressure_stage =0 ;u8 pressure; -u8 size;u8 touch_major;u8 touch_minor;
drivers/input/touchscreen/melfas_mip4.c static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) · line 484
Quoted 5 lines
drivers/input/touchscreen/melfas_mip4.c +0
-2@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)case 1 :/* Touch only */ state = packet[0 ] &BIT (7 ); - hover = packet[0 ] &BIT (5 ); - palm = packet[0 ] &BIT (4 );
No really happy that we'd be losing information about protocol. Is there a better way to suppress the warning while keeping this info?
Quoted 27 lines
drivers/input/touchscreen/melfas_mip4.c +0
-5id = (packet[0 ] &0x0F ) -1 ; x = ((packet[1 ] &0x0F ) <<8 ) | packet[2 ]; y = (((packet[1 ] >>4 ) &0x0F ) <<8 ) | packet[3 ]; pressure = packet[4 ]; - size = packet[5 ];if (ts->event_format ==0 ) { touch_major = packet[5 ]; touch_minor = packet[5 ];@@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)default :/* Touch + Force(Pressure) */ id = (packet[0 ] &0x0F ) -1 ; - hover = packet[1 ] &BIT (2 ); - palm = packet[1 ] &BIT (1 ); state = packet[1 ] &BIT (0 ); x = ((packet[2 ] &0x0F ) <<8 ) | packet[3 ]; y = (((packet[2 ] >>4 ) &0x0F ) <<8 ) | packet[4 ]; - size = packet[6 ]; - pressure_stage = (packet[7 ] &0xF0 ) >>4 ; pressure = ((packet[7 ] &0x0F ) <<8 ) | packet[8 ]; touch_major = packet[9 ];Signature · 1 line
2.25.1
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
Quoted 36 lines · Dmitry Torokhov
Quoted 35 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]Cc Sangwon Jee <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/input/touchscreen/melfas_mip4.c +0
-4@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)static void mip4_report_touch (struct mip4_ts *ts,u8 *packet) {int id; -bool hover; -bool palm;bool state;u16 x, y; -u8 pressure_stage =0 ;u8 pressure; -u8 size;u8 touch_major;u8 touch_minor;
Quoted 9 lines
drivers/input/touchscreen/melfas_mip4.c static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) · line 484
Quoted 6 lines
drivers/input/touchscreen/melfas_mip4.c +0
-2@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)case 1 :/* Touch only */ state = packet[0 ] &BIT (7 ); - hover = packet[0 ] &BIT (5 ); - palm = packet[0 ] &BIT (4 );No really happy that we'd be losing information about protocol. Is there a better way to suppress the warning while keeping this info?
Yes. We can either convert the information to comments, or mark the variables as __always_unused.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Dmitry Torokhov
maintainerRe: [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
Quoted 48 lines · Lee Jones
Quoted 36 lines · Dmitry Torokhov
Quoted 35 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]Cc Sangwon Jee <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/input/touchscreen/melfas_mip4.c +0
-4@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)static void mip4_report_touch (struct mip4_ts *ts,u8 *packet) {int id; -bool hover; -bool palm;bool state;u16 x, y; -u8 pressure_stage =0 ;u8 pressure; -u8 size;u8 touch_major;u8 touch_minor;Quoted 9 lines
drivers/input/touchscreen/melfas_mip4.c static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) · line 484
Quoted 6 lines
drivers/input/touchscreen/melfas_mip4.c +0
-2@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)case 1 :/* Touch only */ state = packet[0 ] &BIT (7 ); - hover = packet[0 ] &BIT (5 ); - palm = packet[0 ] &BIT (4 );No really happy that we'd be losing information about protocol. Is there a better way to suppress the warning while keeping this info?
Quoted 2 lines
Yes. We can either convert the information to comments, or mark the variables as
__always_unused.
If __always unused suppresses this warning that would be my preference.
Thanks!
Signature · 1 line
Dmitry
Re: [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
Quoted 49 lines · Dmitry Torokhov
Quoted 48 lines · Lee Jones
Quoted 45 lines · Dmitry Torokhov
Quoted 36 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]Cc Sangwon Jee <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-)drivers/input/touchscreen/melfas_mip4.c +0
-4@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)static void mip4_report_touch (struct mip4_ts *ts,u8 *packet) {int id; -bool hover; -bool palm;bool state;u16 x, y; -u8 pressure_stage =0 ;u8 pressure; -u8 size;u8 touch_major;u8 touch_minor;drivers/input/touchscreen/melfas_mip4.c static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) · line 484
Quoted 5 lines
drivers/input/touchscreen/melfas_mip4.c +0
-2@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)case 1 :/* Touch only */ state = packet[0 ] &BIT (7 ); - hover = packet[0 ] &BIT (5 ); - palm = packet[0 ] &BIT (4 );No really happy that we'd be losing information about protocol. Is there a better way to suppress the warning while keeping this info?
Quoted 4 lines
Quoted 2 lines
Yes. We can either convert the information to comments, or mark the variables as
__always_unused.If
__alwaysunused suppresses this warning that would be my preference.
No problem. Will fix.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 7/15 input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
--- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/usbtouchscreen.c +2 -2
@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)unsigned int data_len =be16_to_cpu (packet->data_len);unsigned int x_len =be16_to_cpu (packet->x_len);unsigned int y_len =be16_to_cpu (packet->y_len); -int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; +int x, y, begin_x, begin_y, end_x, end_y, w, h;/* got touch data? */ if ((pkt[0 ] &0xe0 ) !=0xe0 )
@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -=0x80 ;/* send ACK */ - ret =usb_submit_urb (priv->ack,GFP_ATOMIC ); +usb_submit_urb (priv->ack,GFP_ATOMIC );if (!usbtouch->type->max_xc) { usbtouch->type->max_xc =2 * x_len;
Signature · 1 line
2.25.1
Dmitry Torokhov
maintainerRe: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
Quoted 29 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc James Hilliard <[email protected]>Cc Daniel Ritz <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/input/touchscreen/usbtouchscreen.c +1
-1@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)unsigned int data_len =be16_to_cpu (packet->data_len);unsigned int x_len =be16_to_cpu (packet->x_len);unsigned int y_len =be16_to_cpu (packet->y_len); -int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; +int x, y, begin_x, begin_y, end_x, end_y, w, h;/* got touch data? */ if ((pkt[0 ] &0xe0 ) !=0xe0 )
drivers/input/touchscreen/usbtouchscreen.c static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) · line 1064
Quoted 5 lines
drivers/input/touchscreen/usbtouchscreen.c +1
-1@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -=0x80 ;/* send ACK */ - ret =usb_submit_urb (priv->ack,GFP_ATOMIC ); +usb_submit_urb (priv->ack,GFP_ATOMIC );
I wonder if we should handle potential errors instead.
Quoted 6 lines
drivers/input/touchscreen/usbtouchscreen.c +0
-0if (!usbtouch->type->max_xc) { usbtouch->type->max_xc =2 * x_len;Signature · 1 line
2.25.1
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
Quoted 32 lines · Dmitry Torokhov
Quoted 31 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc James Hilliard <[email protected]>Cc Daniel Ritz <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/input/touchscreen/usbtouchscreen.c +1
-1@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)unsigned int data_len =be16_to_cpu (packet->data_len);unsigned int x_len =be16_to_cpu (packet->x_len);unsigned int y_len =be16_to_cpu (packet->y_len); -int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; +int x, y, begin_x, begin_y, end_x, end_y, w, h;/* got touch data? */ if ((pkt[0 ] &0xe0 ) !=0xe0 )@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -=0x80 ;
Quoted 5 lines
drivers/input/touchscreen/usbtouchscreen.c static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) · line 1064
Quoted 3 lines
drivers/input/touchscreen/usbtouchscreen.c +1
-1/* send ACK */ - ret =usb_submit_urb (priv->ack,GFP_ATOMIC ); +usb_submit_urb (priv->ack,GFP_ATOMIC );I wonder if we should handle potential errors instead.
Your call. I'll do whatever you decide.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Dmitry Torokhov
maintainerRe: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
Quoted 34 lines · Lee Jones
Quoted 32 lines · Dmitry Torokhov
Quoted 31 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc James Hilliard <[email protected]>Cc Daniel Ritz <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/input/touchscreen/usbtouchscreen.c +1
-1@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)unsigned int data_len =be16_to_cpu (packet->data_len);unsigned int x_len =be16_to_cpu (packet->x_len);unsigned int y_len =be16_to_cpu (packet->y_len); -int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; +int x, y, begin_x, begin_y, end_x, end_y, w, h;/* got touch data? */ if ((pkt[0 ] &0xe0 ) !=0xe0 )@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -=0x80 ;
Quoted 7 lines
Quoted 5 lines
drivers/input/touchscreen/usbtouchscreen.c static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) · line 1064
Quoted 3 lines
drivers/input/touchscreen/usbtouchscreen.c +1
-1/* send ACK */ - ret =usb_submit_urb (priv->ack,GFP_ATOMIC ); +usb_submit_urb (priv->ack,GFP_ATOMIC );I wonder if we should handle potential errors instead.
Your call. I'll do whatever you decide.
OK, please add error handling here.
Thank you.
Signature · 1 line
Dmitry
PATCH 8/15 input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]
--- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-)
drivers/input/touchscreen/surface3_spi.c +0 -2
@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,static void surface3_spi_process_touch (struct surface3_ts_data *ts_data,u8 *data) { -u16 timestamp;unsigned int i; - timestamp =get_unaligned_le16 (&data[15 ]);for (i =0 ; i <13 ; i++) {struct surface3_ts_data_finger *finger;
Signature · 1 line
2.25.1
Dmitry Torokhov
maintainerRe: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'
Quoted 19 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-)drivers/input/touchscreen/surface3_spi.c +0
-0
drivers/input/touchscreen/surface3_spi.c static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, · line 99
Quoted 6 lines
drivers/input/touchscreen/surface3_spi.c +0
-2@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,static void surface3_spi_process_touch (struct surface3_ts_data *ts_data,u8 *data) { -u16 timestamp;unsigned int i; - timestamp =get_unaligned_le16 (&data[15 ]);
Benjamin, should we pass timing data on to userspace instead?
Quoted 6 lines
drivers/input/touchscreen/surface3_spi.c +0
-0for (i =0 ; i <13 ; i++) {struct surface3_ts_data_finger *finger;Signature · 1 line
2.25.1
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'
Quoted 22 lines · Dmitry Torokhov
Quoted 20 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-)drivers/input/touchscreen/surface3_spi.c +0
-0@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,
Quoted 7 lines
drivers/input/touchscreen/surface3_spi.c static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, · line 99
Quoted 5 lines
drivers/input/touchscreen/surface3_spi.c +0
-2static void surface3_spi_process_touch (struct surface3_ts_data *ts_data,u8 *data) { -u16 timestamp;unsigned int i; - timestamp =get_unaligned_le16 (&data[15 ]);Benjamin, should we pass timing data on to userspace instead?
Last time I checked, libinput was not using the HW timestamp. So I don't mind dropping it.
Not sure if chrome/android uses it.
Cheers,
Benjamin
Quoted 12 lines
Quoted 7 lines
drivers/input/touchscreen/surface3_spi.c +0
-1for (i =0 ; i <13 ; i++) {struct surface3_ts_data_finger *finger; --2.25.1
Thanks.
--
Dmitry
Re: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'
Quoted 32 lines · Benjamin Tissoires
Quoted 22 lines · Dmitry Torokhov
Quoted 20 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-)drivers/input/touchscreen/surface3_spi.c +0
-0@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,Quoted 7 lines
drivers/input/touchscreen/surface3_spi.c static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, · line 99
Quoted 5 lines
drivers/input/touchscreen/surface3_spi.c +0
-2static void surface3_spi_process_touch (struct surface3_ts_data *ts_data,u8 *data) { -u16 timestamp;unsigned int i; - timestamp =get_unaligned_le16 (&data[15 ]);Benjamin, should we pass timing data on to userspace instead?
Quoted 2 lines
Last time I checked, libinput was not using the HW timestamp. So I don't mind dropping it.
I'm assuming this would be passed on as MSC_TIMESTAMP?
I never found the time implementing this and I mask MSC_TIMESTAMP on most devices anyway (except for Dell's i2c touchpads where I need it to work around a fw bug). so at least from libinput's POV it wouldn't have any effect either way.
Cheers,
Peter
Quoted 18 lines
Not sure if chrome/android uses it.
Cheers,
BenjaminQuoted 12 lines
Quoted 7 lines
drivers/input/touchscreen/surface3_spi.c +0
-1for (i =0 ; i <13 ; i++) {struct surface3_ts_data_finger *finger; --2.25.1
Thanks.
--
Dmitry
PATCH 9/15 input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'struct wm831x_on '
--- drivers/input/misc/wm831x-on.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/wm831x-on.c +1 -1
@@ -1,4 +1,4 @@ -/** +/* * wm831x-on.c - WM831X ON pin driver * * Copyright (C) 2009 Wolfson Microelectronics plc
Signature · 1 line
2.25.1
Re: [PATCH 09/15] input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc
Quoted 19 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'structwm831x_on'Cc Dmitry Torokhov <[email protected]>Cc Mark Brown <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/misc/wm831x-on.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/misc/wm831x-on.c +0
-0
drivers/input/misc/wm831x-on.c line 4
Quoted 5 lines
drivers/input/misc/wm831x-on.c +1
-1@@ -1,4 +1,4 @@ -/** +/* * wm831x-on.c - WM831X ON pin driver * * Copyright (C) 2009 Wolfson Microelectronics plc
Re: [PATCH 09/15] input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc
In reply to Lee JonesQuoted 9 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'structwm831x_on'Cc Dmitry Torokhov <[email protected]>Cc Mark Brown <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 10/15 input: touchscreen: surface3_spi: Fix naming issue with 'surface3_spi_get_gpio_config's header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/surface3_spi.c:225: warning: Function parameter or member 'data' not described in 'surface3_spi_get_gpio_config' drivers/input/touchscreen/surface3_spi.c:225: warning: Excess function parameter 'ts' description in 'surface3_spi_get_gpio_config'
--- drivers/input/touchscreen/surface3_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/surface3_spi.c +1 -1
@@ -217,7 +217,7 @@ static void surface3_spi_power(struct surface3_ts_data *data, bool on)/** * surface3_spi_get_gpio_config - Get GPIO config from ACPI/DT * -* @ts: surface3_spi_ts_data pointer +* @data: surface3_spi_ts_data pointer */ static int surface3_spi_get_gpio_config (struct surface3_ts_data *data) {
Signature · 1 line
2.25.1
Re: [PATCH 10/15] input: touchscreen: surface3_spi: Fix naming issue with 'surface3_spi_get_gpio_config's header
Quoted 7 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]drivers/input/touchscreen/surface3_spi.c:225: warning: Function parameter or member 'data' not described in 'surface3_spi_get_gpio_config'drivers/input/touchscreen/surface3_spi.c:225: warning: Excess function parameter 'ts' description in 'surface3_spi_get_gpio_config'
Quoted 6 lines
Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc Lee Jones <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 11/15 input: touchscreen: wm97xx-core: Provide missing description for 'status'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/wm97xx-core.c:204: warning: Function parameter or member 'status' not described in 'wm97xx_set_gpio'
--- drivers/input/touchscreen/wm97xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/wm97xx-core.c +1 -1
@@ -194,7 +194,7 @@ EXPORT_SYMBOL_GPL(wm97xx_get_gpio);* wm97xx_set_gpio - Set the status of a codec GPIO. * @wm: wm97xx device. * @gpio: gpio -* +* @status: status * * Set the status of a codec GPIO pin */
Signature · 1 line
2.25.1
Re: [PATCH 11/15] input: touchscreen: wm97xx-core: Provide missing description for 'status'
Quoted 22 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/wm97xx-core.c:204: warning: Function parameter or member 'status' not described in 'wm97xx_set_gpio'Cc Dmitry Torokhov <[email protected]>Cc Liam Girdwood <[email protected]>Cc Ian Molton <[email protected]>Cc Andrew Zabolotny <[email protected]>Cc Russell King <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/input/touchscreen/wm97xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/touchscreen/wm97xx-core.c +0
-0
drivers/input/touchscreen/wm97xx-core.c EXPORT_SYMBOL_GPL(wm97xx_get_gpio); · line 200
Quoted 8 lines
drivers/input/touchscreen/wm97xx-core.c +1
-1@@ -194,7 +194,7 @@ EXPORT_SYMBOL_GPL(wm97xx_get_gpio);* wm97xx_set_gpio - Set the status of a codec GPIO. * @wm: wm97xx device. * @gpio: gpio -* +* @status: status * * Set the status of a codec GPIO pin */
Re: [PATCH 11/15] input: touchscreen: wm97xx-core: Provide missing description for 'status'
In reply to Lee JonesQuoted 4 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/wm97xx-core.c:204: warning: Function parameter or member 'status' not described in 'wm97xx_set_gpio'
Quoted 8 lines
Cc Dmitry Torokhov <[email protected]>Cc Liam Girdwood <[email protected]>Cc Ian Molton <[email protected]>Cc Andrew Zabolotny <[email protected]>Cc Russell King <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 12/15 input: mouse: synaptics: Demote non-conformant kernel-doc header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'psmouse' not described in 'synaptics_setup_intertouch' drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'info' not described in 'synaptics_setup_intertouch' drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'leave_breadcrumbs' not described in 'synaptics_setup_intertouch'
--- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/synaptics.c +1 -1
@@ -1771,7 +1771,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, leave_breadcrumbs); } -/** +/* * synaptics_setup_intertouch - called once the PS/2 devices are enumerated * and decides to instantiate a SMBus InterTouch device. */
Signature · 1 line
2.25.1
Re: [PATCH 12/15] input: mouse: synaptics: Demote non-conformant kernel-doc header
Quoted 6 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'psmouse' not described in 'synaptics_setup_intertouch'drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'info' not described in 'synaptics_setup_intertouch'drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'leave_breadcrumbs' not described in 'synaptics_setup_intertouch'
Quoted 9 lines
Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc Peter Osterlund <[email protected]>Cc Stefan Gmeiner <[email protected]>Cc "C. Scott Ananian" <[email protected]>Cc Bruce Kalk <[email protected]>Cc this to <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 13/15 input: touchscreen: goodix: Fix misspelling of 'ctx'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/goodix.c:1168: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1168: warning: Excess function parameter 'ts' description in 'goodix_config_cb'
--- drivers/input/touchscreen/goodix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/goodix.c +1 -1
@@ -1159,7 +1159,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)* goodix_config_cb - Callback to finish device init * * @cfg: firmware config -* @ts: our goodix_ts_data pointer +* @ctx: our goodix_ts_data pointer * * request_firmware_wait callback that finishes * initialization of the device.
Signature · 1 line
2.25.1
Re: [PATCH 13/15] input: touchscreen: goodix: Fix misspelling of 'ctx'
Quoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/goodix.c:1168: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb'drivers/input/touchscreen/goodix.c:1168: warning: Excess function parameter 'ts' description in 'goodix_config_cb'
Quoted 8 lines
Cc Bastien Nocera <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc "K. Merker" <[email protected]>Cc authored by <[email protected]>Cc Benjamin Tissoires <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 14/15 input: keyboard: applespi: Provide missing struct 'message' descriptions
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'keyboard' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'touchpad' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'init_mt_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'capsl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'bl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'data' not described in 'message'
--- drivers/input/keyboard/applespi.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/input/keyboard/applespi.c +9 -0
@@ -286,6 +286,15 @@ struct command_protocol_bl {* structure (after re-assembly in case of being split over * multiple spi-packets), minus the trailing crc. The total size * of the message struct is therefore @length + 10. +* +* @keyboard: Keyboard message +* @touchpad: Touchpad message +* @tp_info: Touchpad info (response) +* @tp_info_command: Touchpad info (CRC) +* @init_mt_command: Initialise Multitouch +* @capsl_command: Toggle caps-lock LED +* @bl_command: Keyboard brightness +* @data: Buffer data */ struct message {__le16 type;
Signature · 1 line
2.25.1
Re: [PATCH 14/15] input: keyboard: applespi: Provide missing struct 'message' descriptions
Quoted 11 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'keyboard' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'touchpad' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info_command' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'init_mt_command' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'capsl_command' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'bl_command' not described in 'message'drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'data' not described in 'message'
Quoted 5 lines
Cc Dmitry Torokhov <[email protected]>Cc Henrik Rydberg <[email protected]>Cc "Gustavo A. R. Silva" <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry
PATCH 15/15 input: mouse: vmmouse: Demote obvious abuse of kernel-doc header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'cmd' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'in1' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out1' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out2' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out3' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out4' not described in 'VMMOUSE_CMD'
--- drivers/input/mouse/vmmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/mouse/vmmouse.c +1 -1
@@ -76,7 +76,7 @@ struct vmmouse_data {char dev_name[128 ]; }; -/** +/* * Hypervisor-specific bi-directional communication channel * implementing the vmmouse protocol. Should never execute on * bare metal hardware.
Signature · 1 line
2.25.1
Re: [PATCH 15/15] input: mouse: vmmouse: Demote obvious abuse of kernel-doc header
Quoted 9 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'cmd' not described in 'VMMOUSE_CMD'drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'in1' not described in 'VMMOUSE_CMD'drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out1' not described in 'VMMOUSE_CMD'drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out2' not described in 'VMMOUSE_CMD'drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out3' not described in 'VMMOUSE_CMD'drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out4' not described in 'VMMOUSE_CMD'
Quoted 6 lines
Cc VMware Graphics <[email protected]>Cc "VMware, Inc." <[email protected]>Cc Dmitry Torokhov <[email protected]>Cc Thomas Hellstrom <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry