ceph: downgrade warning from mdsmap decode to debug
PATCH 1/1 ceph: downgrade warning from mdsmap decode to debug
While the MDS cluster is unstable and changing state the client may get mdsmap updates that will trigger warnings:
[144692.478400] ceph: mdsmap_decode got incorrect state(up:standby-replay) [144697.489552] ceph: mdsmap_decode got incorrect state(up:standby-replay) [144697.489580] ceph: mdsmap_decode got incorrect state(up:standby-replay)
This patch downgrades these warnings to debug, as they may flood the logs if the cluster is unstable for a while.
Signed-off-by Luis Henriques <[email protected]>
---
Hi!
This patch follows from my other patch "ceph: fix race in concurrent __ceph_remove_cap invocations", where I see a *lot* of warnings before the NULL pointer. Maybe this could be a pr_warn_once instead, but not sure that would be useful.
Note that before commit 4d7ace02ba5c ("ceph: fix mdsmap cluster available check based on laggy number") this was simply ignored without any pr_warn or dout.
Cheers,
--
Luis
fs/ceph/mdsmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/mdsmap.c +2 -2
@@ -243,8 +243,8 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) }if (state <=0 ) { -pr_warn ("mdsmap_decode got incorrect state(%s)\n" , -ceph_mds_state_name (state)); +dout ("mdsmap_decode got incorrect state(%s)\n" , +ceph_mds_state_name (state));continue ; }