Skip to contentSkip to conversation

net: ipa: two fixes

PATCH Applied Alex Elder 2 participants 4 messages Nov 12, 2020 – Nov 13, 2020

Subsystems (3)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

cover net: ipa: two fixes

This small series makes two fixes to the IPA code:
- While reviewing something else I found that one of the resource limits on the SDM845 used the wrong value. The first patch fixes this. The correct value allocates more resources of this type for IPA to use, and otherwise does not change behavior.
- When the IPA-resident microcontroller starts up it generates an event, which triggers an AP interrupt. The event merely provides some information for logging, which we don't support. We already ignore the event, and that's harmless. So this patch explicitly ignores it rather than issuing a warning when it occurs.

-Alex

Alex Elder (2):
net: ipa: fix source packet contexts limit
net: ipa: ignore the microcontroller log event

 drivers/net/ipa/ipa_data-sdm845.c | 4 ++--
 drivers/net/ipa/ipa_uc.c          | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 1/2 net: ipa: fix source packet contexts limit

I have discovered that the maximum number of source packet contexts configured for SDM845 is incorrect. Fix this error.

---
 drivers/net/ipa/ipa_data-sdm845.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ipa/ipa_data-sdm845.c +2 -2
index a9a992404b39f..bd92b619e7fec 100644
@@ -150,11 +150,11 @@ static const struct ipa_resource_src ipa_resource_src[] = {
 		.type = IPA_RESOURCE_TYPE_SRC_PKT_CONTEXTS,
 		.limits[0] = {
 			.min = 1,
-			.max = 63,
+			.max = 255,
 		},
 		.limits[1] = {
 			.min = 1,
-			.max = 63,
+			.max = 255,
 		},
 	},
 	{
Signature · 1 line
2.20.1
author
#2 lore raw

PATCH 2/2 net: ipa: ignore the microcontroller log event

In reply to Alex Elder

The IPA-resident microcontroller has the ability to log various activity in an area of IPA shared memory. When the microcontroller starts it generates an event to the AP to provide information about the log.

We don't support reading this log, and we can safely ignore the event. So do that rather than treating the log info event we receive as "unsupported."

---
 drivers/net/ipa/ipa_uc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ipa/ipa_uc.c +2 -1
index b382d47bc70d9..15bb357f3cfb1 100644
@@ -129,9 +129,10 @@ static void ipa_uc_event_handler(struct ipa *ipa, enum ipa_irq_id irq_id)
 
 	if (shared->event == IPA_UC_EVENT_ERROR)
 		dev_err(dev, "microcontroller error event\n");
-	else
+	else if (shared->event != IPA_UC_EVENT_LOG_INFO)
 		dev_err(dev, "unsupported microcontroller event %hhu\n",
 			shared->event);
+	/* The LOG_INFO event can be safely ignored */
 }
 
 /* Microcontroller response IPA interrupt handler */
Signature · 1 line
2.20.1
#3 lore raw
In reply to Alex Elder
This series was applied to netdev/net-next.git (refs/heads/master):

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

Quoted 12 lines · On Thu, 12 Nov 2020 06:11:55 -0600 you wrote:

This small series makes two fixes to the IPA code:
- While reviewing something else I found that one of the resource limits on the SDM845 used the wrong value. The first patch fixes this. The correct value allocates more resources of this type for IPA to use, and otherwise does not change behavior.
- When the IPA-resident microcontroller starts up it generates an event, which triggers an AP interrupt. The event merely provides some information for logging, which we don't support. We already ignore the event, and that's harmless. So this patch explicitly ignores it rather than issuing a warning when it occurs.

Quoted 1 line

[...]

Here is the summary with links:
- [net-next,1/2] net: ipa: fix source packet contexts limit

    https://git.kernel.org/netdev/net-next/c/3ce6da1b2e47
  - [net-next,2/2] net: ipa: ignore the microcontroller log event
    https://git.kernel.org/netdev/net-next/c/0a5096ec2a35

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html