usb: gadget: mass_storage: fix error return code in msg_bind()
PATCH v2 1/1 usb: gadget: mass_storage: fix error return code in msg_bind()
Fix to return a negative error code from the error handling case instead of 0 in function msg_bind(), as done elsewhere in this function.
Fixes d86788979761 ("usb: gadget: mass_storage: allocate and init otg descriptor by otg capabilities")
Reported-by Hulk Robot <[email protected]>
Signed-off-by Chen Zhou <[email protected]>
--- drivers/usb/gadget/legacy/mass_storage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/gadget/legacy/mass_storage.c +3 -1
@@ -175,8 +175,10 @@ static int msg_bind(struct usb_composite_dev *cdev)struct usb_descriptor_header *usb_desc; usb_desc =usb_otg_descriptor_alloc (cdev->gadget); -if (!usb_desc) +if (!usb_desc) { + status = -ENOMEM ; goto fail_string_ids; + }usb_otg_descriptor_init (cdev->gadget, usb_desc); otg_desc[0 ] = usb_desc; otg_desc[1 ] =NULL ;
Signature · 1 line
2.20.1
Quoted 7 lines · Chen Zhou
Fix to return a negative error code from the error handling case instead of 0 in function
msg_bind(), as done elsewhere in this function.Fixes d86788979761 ("usb: gadget: mass_storage: allocate and init otg descriptor by otg capabilities")Reported-by Hulk Robot <[email protected]>Signed-off-by Chen Zhou <[email protected]>
Reviewed-by Peter Chen <[email protected]>
Peter
Quoted 23 lines
--- drivers/usb/gadget/legacy/mass_storage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/usb/gadget/legacy/mass_storage.c +3
-1@@ -175,8 +175,10 @@ static int msg_bind(struct usb_composite_dev *cdev)struct usb_descriptor_header *usb_desc; usb_desc =usb_otg_descriptor_alloc (cdev->gadget); -if (!usb_desc) +if (!usb_desc) { + status = -ENOMEM ; goto fail_string_ids; + }usb_otg_descriptor_init (cdev->gadget, usb_desc); otg_desc[0 ] = usb_desc; otg_desc[1 ] =NULL ;Signature · 1 line
2.20.1
Signature · 2 lines
Thanks, Peter Chen