Skip to contentSkip to conversation

net: phy: Add additional logics on probing C45 PHY devices

PATCH In review Wong Vee Khee 3 participants 3 messages Nov 12, 2020 – Nov 17, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: Add additional logics on probing C45 PHY devices

For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to check if there is at least one valid device ID, return 0 on true, and -ENODEV otherwise.

---
 drivers/net/phy/phy_device.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/net/phy/phy_device.c +10 -0
index e13a46c25437..c9ddcd7a63d4 100644
@@ -730,6 +730,7 @@ static int get_phy_c45_ids(struct mii_bus *bus, int addr,
 	const int num_ids = ARRAY_SIZE(c45_ids->device_ids);
 	u32 devs_in_pkg = 0;
 	int i, ret, phy_reg;
+	u32 valid_did = 0;
 
 	/* Find first non-zero Devices In package. Device zero is reserved
 	 * for 802.3 c45 complied PHYs, so don't probe it at first.
@@ -796,12 +797,21 @@ static int get_phy_c45_ids(struct mii_bus *bus, int addr,
 		if (phy_reg < 0)
 			return -EIO;
 		c45_ids->device_ids[i] |= phy_reg;
+
+		/* Check if there is at least one valid device ID */
+		if (c45_ids->device_ids[i] &&
+		    (c45_ids->device_ids[i] & 0x1fffffff) != 0x1fffffff)
+			valid_did |= (1 << i);
 	}
 
 	c45_ids->devices_in_package = devs_in_pkg;
 	/* Bit 0 doesn't represent a device, it indicates c22 regs presence */
 	c45_ids->mmds_present = devs_in_pkg & ~BIT(0);
 
+	/* There is no valid device ID */
+	if (!valid_did)
+		return -ENODEV;
+
 	return 0;
 }
 
Signature · 1 line
2.17.0
maintainer
#1 lore raw
Quoted 3 lines · Wong Vee Khee

For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to check if there is at least one valid device ID, return 0 on true, and -ENODEV otherwise.

So does this mean you have a device which uses c45 and does not have any valid IDs? What device is it? Can it be used via c22?

I would like to know more about why this is needed, since it sounds like a workaround for a broken device.

Andrew

maintainer
#2 lore raw
In reply to Wong Vee Khee
Quoted 5 lines · On Thu, 12 Nov 2020 23:03:51 +0800 Wong Vee Khee wrote:

For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to check if there is at least one valid device ID, return 0 on true, and -ENODEV otherwise.

I don't see any response to Andrew's questions, so I'm dropping this from patchwork.