migration: handle CANCELLING state in migration_completion()
PATCH 1/1 migration: handle CANCELLING state in migration_completion()
The following sequence may cause the VM abort during migration:
1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE
2. before call migration_completion(), we send migrate_cancel QMP command, the state machine is changed to:
RUN_STATE_RUNNING,MIGRATION_STATUS_CANCELLING
3. call migration_completion(), and the state machine is switch to: RUN_STATE_RUNNING,MIGRATION_STATUS_COMPLETED
4. call migration_iteration_finish(), because the migration status is COMPLETED, so it will try to set the runstate to POSTMIGRATE, but RUNNING-->POSTMIGRATE is an invalid transition, so abort().
The migration_completion() should not change the migration state to COMPLETED if it is already changed to CANCELLING.
--- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+)
migration/migration.c +2 -0
@@ -3061,6 +3061,8 @@ static void migration_completion(MigrationState *s)qemu_savevm_state_complete_postcopy (s->to_dst_file);trace_migration_completion_postcopy_end_after_complete (); + }else if (s->state ==MIGRATION_STATUS_CANCELLING ) { + goto fail; }/*
Signature · 1 line
1.8.3.1
Quoted 16 lines · * Longpeng(Mike) ([email protected]) wrote:
The following sequence may cause the VM abort during migration:
1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE
2. before call
migration_completion(), we sendmigrate_cancelQMP command, the state machine is changed to:
RUN_STATE_RUNNING,MIGRATION_STATUS_CANCELLING3. call
migration_completion(), and the state machine is switch to: RUN_STATE_RUNNING,MIGRATION_STATUS_COMPLETED4. call
migration_iteration_finish(), because the migration status is COMPLETED, so it will try to set the runstate to POSTMIGRATE, but RUNNING-->POSTMIGRATE is an invalid transition, soabort().
Quoted 4 lines
The
migration_completion()should not change the migration state to COMPLETED if it is already changed to CANCELLING.Signed-off-by Longpeng(Mike) <[email protected]>
Yes I think so; the only downside I see is I think this ends up going from CACELLNG->FAILED.
Quoted 20 lines
--- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+)migration/migration.c +2
-0@@ -3061,6 +3061,8 @@ static void migration_completion(MigrationState *s)qemu_savevm_state_complete_postcopy (s->to_dst_file);trace_migration_completion_postcopy_end_after_complete (); + }else if (s->state ==MIGRATION_STATUS_CANCELLING ) { + goto fail; }/* Signature · 1 line
1.8.3.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 16 lines · * Longpeng(Mike) ([email protected]) wrote:
The following sequence may cause the VM abort during migration:
1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE
2. before call
migration_completion(), we sendmigrate_cancelQMP command, the state machine is changed to:
RUN_STATE_RUNNING,MIGRATION_STATUS_CANCELLING3. call
migration_completion(), and the state machine is switch to: RUN_STATE_RUNNING,MIGRATION_STATUS_COMPLETED4. call
migration_iteration_finish(), because the migration status is COMPLETED, so it will try to set the runstate to POSTMIGRATE, but RUNNING-->POSTMIGRATE is an invalid transition, soabort().
Quoted 4 lines
The
migration_completion()should not change the migration state to COMPLETED if it is already changed to CANCELLING.Signed-off-by Longpeng(Mike) <[email protected]>
Queued
Quoted 21 lines
--- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+)migration/migration.c +2
-0@@ -3061,6 +3061,8 @@ static void migration_completion(MigrationState *s)qemu_savevm_state_complete_postcopy (s->to_dst_file);trace_migration_completion_postcopy_end_after_complete (); + }else if (s->state ==MIGRATION_STATUS_CANCELLING ) { + goto fail; }/* Signature · 1 line
1.8.3.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK