regmap: Fix order of regmap write log
Subsystems (2)
PATCH 1/1 regmap: Fix order of regmap write log
_regmap_write can trigger a _regmap_select_page, which will call another _regmap_write that will be executed first, but the log shows the inverse order
Also, keep consistency with _regmap_read which only logs in case of success
--- drivers/base/regmap/regmap.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/base/regmap/regmap.c +7 -4
@@ -1924,12 +1924,15 @@ int _regmap_write(struct regmap *map, unsigned int reg, } } -if (regmap_should_log (map)) -dev_info (map->dev,"%x <= %x\n" , reg, val); + ret = map->reg_write (context, reg, val); +if (ret ==0 ) { +if (regmap_should_log (map)) +dev_info (map->dev,"%x <= %x\n" , reg, val); -trace_regmap_reg_write (map, reg, val); +trace_regmap_reg_write (map, reg, val); + } -return map->reg_write (context, reg, val); +return ret; }/**
Signature · 1 line
2.29.2
Quoted 9 lines · Lucas Tanure
_regmap_writecan trigger a_regmap_select_page, which will call another_regmap_writethat will be executed first, but the log shows the inverse orderAlso, keep consistency with
_regmap_readwhich only logs in case of successSigned-off-by Lucas Tanure <[email protected]>---
Thanks,
Charles
Mark Brown
maintainerQuoted 6 lines · Lucas Tanure
_regmap_writecan trigger a_regmap_select_page, which will call another_regmap_writethat will be executed first, but the log shows the inverse orderAlso, keep consistency with
_regmap_readwhich only logs in case of success
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
Thanks!
[1/1] regmap: Fix order of regmap write log
commit: f7d01359b0d96331fce7bd4051d3b68a4bb5ea83
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark