Skip to contentSkip to conversation

package/apparmor: fix permission bits for apparmor.service

PATCH New Stefan Agner 3 participants 6 messages Nov 12, 2020 – Nov 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

---
 package/apparmor/apparmor.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/apparmor/apparmor.mk +1 -1
index 4d08b0433b..7ea0fabd91 100644
@@ -88,7 +88,7 @@ endef
 define APPARMOR_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
 		$(TARGET_DIR)/lib/apparmor/apparmor.systemd
-	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.service \
+	$(INSTALL) -D -m 0644 $(@D)/parser/apparmor.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/apparmor.service
 endef
 
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

Hello Stefan,

Thanks for your patch!

Quoted 16 lines · On Thu, 12 Nov 2020 21:21:34 +0100 Stefan Agner <[email protected]> wrote:

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

---
 package/apparmor/apparmor.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/apparmor/apparmor.mk +0 -0
index 4d08b0433b..7ea0fabd91 100644

package/apparmor/apparmor.mk endef · line 90

Quoted 3 lines
package/apparmor/apparmor.mk +0 -0
@@ -88,7 +88,7 @@ endef
 define APPARMOR_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
 		$(TARGET_DIR)/lib/apparmor/apparmor.systemd

Any reason not to change this one as well ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

Quoted 18 lines · Thomas Petazzoni

Hello Stefan,

Thanks for your patch!

Quoted 11 lines · On Thu, 12 Nov 2020 21:21:34 +0100 Stefan Agner <[email protected]> wrote:

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

---
 package/apparmor/apparmor.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

package/apparmor/apparmor.mk endef · line 90

Quoted 8 lines
package/apparmor/apparmor.mk +0 -0
index 4d08b0433b..7ea0fabd91 100644
@@ -88,7 +88,7 @@ endef
 define APPARMOR_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
 		$(TARGET_DIR)/lib/apparmor/apparmor.systemd

Any reason not to change this one as well ?

Hm, I somehow thought this is a directory. But it is actually a script which afaik only gets included, so I guess we can take away executable as well.

Will send a v2.

--
Stefan

#3 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

Quoted 30 lines · Stefan Agner
Quoted 18 lines · Thomas Petazzoni

Hello Stefan,

Thanks for your patch!

Quoted 11 lines · On Thu, 12 Nov 2020 21:21:34 +0100 Stefan Agner <[email protected]> wrote:

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

---
 package/apparmor/apparmor.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

package/apparmor/apparmor.mk endef · line 90

Quoted 8 lines
package/apparmor/apparmor.mk +0 -0
index 4d08b0433b..7ea0fabd91 100644
@@ -88,7 +88,7 @@ endef
 define APPARMOR_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
 		$(TARGET_DIR)/lib/apparmor/apparmor.systemd

Any reason not to change this one as well ?

Quoted 3 lines

Hm, I somehow thought this is a directory. But it is actually a script which afaik only gets included, so I guess we can take away executable as well.

No it is actually executed by the systemd service:
apparmor.service:ExecStart=/lib/apparmor/apparmor.systemd reload

So this needs executable bits.

--
Stefan

#4 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

In reply to Stefan Agner
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Stefan" == Stefan Agner <[email protected]> writes:

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 package/apparmor: fix permission bits for apparmor.service

In reply to Stefan Agner
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Stefan" == Stefan Agner <[email protected]> writes:

Avoid setting executable bits for apparmor.service. This gets rid of a corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard