Skip to contentSkip to conversation

soc: ti: Kconfig: Drop ARM64 SoC specific configs

PATCH In review Nishanth Menon 3 participants 10 messages Oct 26, 2020 – Nov 13, 2020 TI Keystone multicore navigator drivers

lore
Share & tools
lore

Nishanth Menon

author maintainer
#0 lore raw

PATCH 1/1 soc: ti: Kconfig: Drop ARM64 SoC specific configs

With the integration of chip-id detection scheme in kernel[1], there is no specific need to maintain multitudes of SoC specific config options, discussed as per [2], we have deprecated the usage in other places for v5.10-rc1. Drop the configuration for the follow on kernel.

[1] drivers/soc/ti/k3-socinfo.c commit 907a2b7e2fc7 ("soc: ti: add k3 platforms chipid module driver")
[2] https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/

---
 drivers/soc/ti/Kconfig | 18 ------------------
 1 file changed, 18 deletions(-)
drivers/soc/ti/Kconfig +0 -18
index f5b82ffa637b..7e2fb1c16af1 100644
@@ -1,22 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
-# 64-bit ARM SoCs from TI
-if ARM64
-
-if ARCH_K3
-
-config ARCH_K3_AM6_SOC
-	bool "K3 AM6 SoC"
-	help
-	  Enable support for TI's AM6 SoC Family support
-
-config ARCH_K3_J721E_SOC
-	bool "K3 J721E SoC"
-	help
-	  Enable support for TI's J721E SoC Family support
-
-endif
-
-endif
 
 #
 # TI SOC drivers
Signature · 1 line
2.28.0
#1 lore raw
Quoted 27 lines · Nishanth Menon

With the integration of chip-id detection scheme in kernel[1], there is no specific need to maintain multitudes of SoC specific config options, discussed as per [2], we have deprecated the usage in other places for v5.10-rc1. Drop the configuration for the follow on kernel.

[1] drivers/soc/ti/k3-socinfo.c commit 907a2b7e2fc7 ("soc: ti: add k3 platforms chipid module driver")
[2] https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/

---
 drivers/soc/ti/Kconfig | 18 ------------------
 1 file changed, 18 deletions(-)
drivers/soc/ti/Kconfig +0 -8
index f5b82ffa637b..7e2fb1c16af1 100644
@@ -1,22 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
-# 64-bit ARM SoCs from TI
-if ARM64
-
-if ARCH_K3
-
-config ARCH_K3_AM6_SOC
-	bool "K3 AM6 SoC"
-	help

drivers/soc/ti/Kconfig line 19

Quoted 10 lines
drivers/soc/ti/Kconfig +0 -10
-	  Enable support for TI's AM6 SoC Family support
-
-config ARCH_K3_J721E_SOC
-	bool "K3 J721E SoC"
-	help
-	  Enable support for TI's J721E SoC Family support
-
-endif
-
-endif

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

[0]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Thanks and regards,
Lokesh

author maintainer
#2 lore raw

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 10 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

Quoted 5 lines

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

[0]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Signature · 8 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by
#3 lore raw
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Sure. IMHO, the cleanup patches should get merged before this Kconfig removal patch.

Otherwise, this patch as-is looks good to me.

Thanks and regards,
Lokesh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#4 lore raw
Quoted 25 lines · Lokesh Vutla
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Quoted 5 lines

Sure. IMHO, the cleanup patches should get merged before this Kconfig removal patch.

Otherwise, this patch as-is looks good to me.

Ofcourse, thanks for highlighting the dependencies.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author maintainer
#5 lore raw
In reply to Nishanth Menon
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Santosh,

https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/
looks available in next now.

Can we queue this patch[1] up for 5.11 window?

Depending on your preference, I can carry the defconfig patch[2] (to prevent merge dependencies, might be good to get an immutable tag) OR you can pick the defconfig patch up that cleans after removing the symbol.

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#6 lore raw
Quoted 29 lines · Nishanth Menon
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Santosh,

https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$
looks available in next now.

Quoted 7 lines

Can we queue this patch[1] up for 5.11 window?

Depending on your preference, I can carry the defconfig patch[2] (to prevent merge dependencies, might be good to get an immutable tag) OR you can pick the defconfig patch up that cleans after removing the symbol.

I can apply SOC kconfig patch [1] to my soc branch. That branch with some additional patches am going to send up, so it should work. Let me know.

Regards,
Santosh

author maintainer
#7 lore raw
Quoted 38 lines · On 13:59-20201112, [email protected] wrote:
Quoted 29 lines · Nishanth Menon
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Santosh,

https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$
looks available in next now.

Quoted 7 lines

Can we queue this patch[1] up for 5.11 window?

Depending on your preference, I can carry the defconfig patch[2] (to prevent merge dependencies, might be good to get an immutable tag) OR you can pick the defconfig patch up that cleans after removing the symbol.

Quoted 3 lines

I can apply SOC kconfig patch [1] to my soc branch. That branch with some additional patches am going to send up, so it should work. Let me know.

OK, sounds fine to me, If you can give me a tag, I can add queue up defconfig on top to prevent bisect issues.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#8 lore raw
Quoted 39 lines · Nishanth Menon
Quoted 38 lines · On 13:59-20201112, [email protected] wrote:
Quoted 36 lines · Nishanth Menon
Quoted 14 lines · Nishanth Menon

On 23:30-20201026, Lokesh Vutla wrote:
[..]

Quoted 12 lines

➜ linux git:(master) git grep -in ARCH_K3_AM6_SOC arch/arm64/configs/defconfig:961:CONFIG_ARCH_K3_AM6_SOC=y drivers/soc/ti/Kconfig:7:config ARCH_K3_AM6_SOC
➜ linux git:(master) git grep -in ARCH_K3_J721E_SOC arch/arm64/configs/defconfig:962:CONFIG_ARCH_K3_J721E_SOC=y drivers/gpu/drm/bridge/cadence/Kconfig:16: depends on ARCH_K3_J721E_SOC || COMPILE_TEST
drivers/soc/ti/Kconfig:12:config ARCH_K3_J721E_SOC

I see drm bridge Kconfig is cleaned[0]. Please clean the defconfig as well.

Quoted 7 lines
Quoted 3 lines

[0]
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$

Yes, the defconfig patches have to be queued up in a different queue, Lets see where the two patches fall and will post the defconfig updates as well.

Santosh,

https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/__;!!GqivPVa7Brio!KWOx2aLl7hlHQrN--kiz1N5WaPWgeZzFZ12ptg8NzJE2BSnxxrWmsoqn5vjMvpfO1bSGYQ$
looks available in next now.

Can we queue this patch[1] up for 5.11 window?

Depending on your preference, I can carry the defconfig patch[2] (to prevent merge dependencies, might be good to get an immutable tag) OR you can pick the defconfig patch up that cleans after removing the symbol.

Quoted 7 lines
Quoted 3 lines

I can apply SOC kconfig patch [1] to my soc branch. That branch with some additional patches am going to send up, so it should work. Let me know.

OK, sounds fine to me, If you can give me a tag, I can add queue up defconfig on top to prevent bisect issues.

I won't be adding tag till all the commits are lineup but branch will be immutable.

Regards.
Santosh

author maintainer
#9 lore raw
In reply to [email protected]

On 13:59-20201112, [email protected] wrote:
[...]

Quoted 5 lines
Quoted 1 line

I can apply SOC kconfig patch [1] to my soc branch. That branch with some additional patches am going to send up, so it should work. Let me know.

I think that should work, thanks.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D