Skip to contentSkip to conversation

media: dt-bindings: coda: Add missing 'additionalProperties'

PATCH Superseded Rob Herring 2 participants 4 messages Nov 12, 2020 – Nov 17, 2020

Subsystems (3)
Device tree bindings Media (V4L/DVB) Coda V4L2 MEM2MEM driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 media: dt-bindings: coda: Add missing 'additionalProperties'

'additionalProperties' is now required by the meta-schema. Add it for coda.

Cc Philipp Zabel <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/coda.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/coda.yaml +2 -0
index 7bac0057faf7..be6218354631 100644
@@ -59,6 +59,8 @@ required:
   - clocks
   - clock-names
 
+additionalProperties: false
+
 allOf:
   - if:
       properties:
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Rob Herring

'additionalProperties' is now required by the meta-schema. Add it for coda.

Cc Philipp Zabel <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/coda.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/coda.yaml +0 -0
index 7bac0057faf7..be6218354631 100644

Documentation/devicetree/bindings/media/coda.yaml required: · line 66

Quoted 8 lines
Documentation/devicetree/bindings/media/coda.yaml +2 -0
@@ -59,6 +59,8 @@ required:
   - clocks
   - clock-names
 
+additionalProperties: false
+
 allOf:
   - if:
       properties:
Reviewed-by Philipp Zabel <[email protected]>

regards
Philipp

author maintainer
#2 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

'additionalProperties' is now required by the meta-schema. Add it for coda.

Cc Philipp Zabel <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/coda.yaml | 2 ++
 1 file changed, 2 insertions(+)

I missed an error this introduces:

/home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
video-codec@63ff4000: 'interrupts' does not match any of the regexes:
'pinctrl-[0-9]+'
From schema:
/home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml

maintainer
#3 lore raw
Quoted 12 lines · Rob Herring
Quoted 10 lines · Rob Herring

'additionalProperties' is now required by the meta-schema. Add it for coda.

Cc Philipp Zabel <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/media/coda.yaml | 2 ++
 1 file changed, 2 insertions(+)
Quoted 7 lines

I missed an error this introduces:

/home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
video-codec@63ff4000: 'interrupts' does not match any of the regexes:
'pinctrl-[0-9]+'
From schema:
/home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml

Right, because interrupts are only specified conditionally:

allOf:
- if:
properties:
compatible:
contains:
const: cnm,coda960
then:
properties:
interrupts:
items:
- description: BIT processor interrupt
- description: JPEG unit interrupt

interrupt-names:
items:
- const: bit
- const: jpeg
else:
properties:
interrupts:
items:
- description: BIT processor interrupt

What is the proper way to fix this?

regards
Philipp