Skip to contentSkip to conversation

usb: chipidea: trace: fix the endian issue

PATCH New Peter Chen 1 participant 1 message Nov 13, 2020

Subsystems (2)
USB Chipidea USB high speed dual role controller
lore
Share & tools
lore

Peter Chen

author maintainer
#0 lore raw

PATCH 1/1 usb: chipidea: trace: fix the endian issue

From: Peter Chen <[email protected]>

"sparse warnings: (new ones prefixed by >>)"
drivers/usb/chipidea/trace.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, drivers/usb/chipidea/trace.h):

Quoted 6 lines
Quoted 6 lines

drivers/usb/chipidea/./trace.h:39:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] next @@ got restricted __le32 [usertype] next @@
drivers/usb/chipidea/./trace.h:39:1: sparse: expected unsigned int [usertype] next
drivers/usb/chipidea/./trace.h:39:1: sparse: got restricted __le32 [usertype] next
drivers/usb/chipidea/./trace.h:39:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] token @@ got restricted __le32 [usertype] token @@
drivers/usb/chipidea/./trace.h:39:1: sparse: expected unsigned int [usertype] token
drivers/usb/chipidea/./trace.h:39:1: sparse: got restricted __le32 [usertype] token

drivers/usb/chipidea/trace.c: note: in included file (through include/trace/perf.h, include/trace/define_trace.h, drivers/usb/chipidea/trace.h):

Quoted 6 lines
Quoted 6 lines

drivers/usb/chipidea/./trace.h:39:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] next @@ got restricted __le32 [usertype] next @@
drivers/usb/chipidea/./trace.h:39:1: sparse: expected unsigned int [usertype] next
drivers/usb/chipidea/./trace.h:39:1: sparse: got restricted __le32 [usertype] next
drivers/usb/chipidea/./trace.h:39:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] token @@ got restricted __le32 [usertype] token @@
drivers/usb/chipidea/./trace.h:39:1: sparse: expected unsigned int [usertype] token
drivers/usb/chipidea/./trace.h:39:1: sparse: got restricted __le32 [usertype] token

Reported-by kernel test robot <[email protected]>
Signed-off-by Peter Chen <[email protected]>
---
 drivers/usb/chipidea/trace.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/chipidea/trace.h +2 -2
index 44ffb2bb625e..1601fd86c4c1 100644
@@ -56,8 +56,8 @@ DECLARE_EVENT_CLASS(ci_log_trb,
 		__entry->td = td;
 		__entry->dma = td->dma;
 		__entry->td_remaining_size = td->td_remaining_size;
-		__entry->next = td->ptr->next;
-		__entry->token = td->ptr->token;
+		__entry->next = le32_to_cpu(td->ptr->next);
+		__entry->token = le32_to_cpu(td->ptr->token);
 		__entry->type = usb_endpoint_type(hwep->ep.desc);
 	),
 	TP_printk("%s: req: %p, td: %p, td_dma_address: %pad, remaining_size: %d, "
Signature · 1 line
2.17.1