drm/kmb: fix potential integer overflow on multiplication
Subsystems (3)
PATCH 1/1 drm/kmb: fix potential integer overflow on multiplication
From: Colin Ian King <[email protected]>
There is a potential integer overflow when multiplying various sized integers that are cast to u32 integers using u32 multiplication and then assigning the result to a u64. Fix this by casting MIPI_TX_BPP to a u64 to force the multiplication to use u64 math and hence avoid any potential overflows.
Addresses-Coverity: ("Unintentional integer overflow")
--- drivers/gpu/drm/kmb/kmb_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/kmb/kmb_dsi.c +1 -1
@@ -1369,7 +1369,7 @@ int kmb_dsi_mode_set(struct kmb_dsi *kmb_dsi, struct drm_display_mode *mode,*/ data_rate = ((((u32 )mode->crtc_vtotal * (u32 )mode->crtc_htotal) * (u32)(drm_mode_vrefresh (mode)) * -MIPI_TX_BPP ) / mipi_tx_init_cfg.active_lanes) /1000000 ; + (u64 )MIPI_TX_BPP ) / mipi_tx_init_cfg.active_lanes) /1000000 ;dev_dbg (kmb_dsi->dev,"data_rate=%u active_lanes=%d\n" , (u32 )data_rate, mipi_tx_init_cfg.active_lanes);
Signature · 1 line
2.28.0
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Colin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20201112]
[cannot apply to linus/master v5.10-rc3 v5.10-rc2 v5.10-rc1 v5.10-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Colin-King/drm-kmb-fix-potential-integer-overflow-on-multiplication/20201113-203903 base: a60b1e1fe9ca5f9d9a79e89a8d71228a8e04d35c config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/bb25aac8771c57130ea5a2a016790e3b7c62e283 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Colin-King/drm-kmb-fix-potential-integer-overflow-on-multiplication/20201113-203903 git checkout bb25aac8771c57130ea5a2a016790e3b7c62e283 # save the attached .config to linux build tree make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/kmb/kmb_dsi.o: in function `kmb_dsi_mode_set':
kmb_dsi.c:(.text+0x13b7): undefined reference to `__udivdi3'
>> ld: kmb_dsi.c:(.text+0x13ca): undefined reference to `__udivdi3'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Colin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20201112]
[cannot apply to linus/master v5.10-rc3 v5.10-rc2 v5.10-rc1 v5.10-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Colin-King/drm-kmb-fix-potential-integer-overflow-on-multiplication/20201113-203903 base: a60b1e1fe9ca5f9d9a79e89a8d71228a8e04d35c config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bb25aac8771c57130ea5a2a016790e3b7c62e283
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Colin-King/drm-kmb-fix-potential-integer-overflow-on-multiplication/20201113-203903 git checkout bb25aac8771c57130ea5a2a016790e3b7c62e283
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "__udivdi3" [drivers/gpu/drm/kmb/kmb-drm.ko] undefined! >> ERROR: modpost: "__divdi3" [drivers/gpu/drm/kmb/kmb-drm.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]