Skip to contentSkip to conversation

checkpatch: fix typo and remove duplicate word

PATCH In review Dwaipayan Ray 2 participants 3 messages Nov 13, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: fix typo and remove duplicate word

Delete repeated word in scripts/checkpatch.pl.
"are are" -> "are"

Fix typo "commments" -> "comments"

---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +2 -2
index 2749f32dffe9..e7fd2d6279cf 100755
@@ -2841,7 +2841,7 @@ sub process {
 
 
 				# [email protected] or [email protected] shouldn't
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -7109,7 +7109,7 @@ sub process {
 		exit(0);
 	}
 
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
Signature · 1 line
2.27.0
#1 lore raw
Quoted 7 lines · Dwaipayan Ray

Delete repeated word in scripts/checkpatch.pl.
"are are" -> "are"

Fix typo "commments" -> "comments"

Does this make checkpatch.pl pass checkpatch without any further warnings?

Nice idea to check if checkpatch.pl still fulfills the checkpatch rules we created...

Lukas

Quoted 29 lines
---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +2 -3
index 2749f32dffe9..e7fd2d6279cf 100755
@@ -2841,7 +2841,7 @@ sub process {
 
 
                                # [email protected] or [email protected] shouldn't
-                               # have an email name. In addition commments should strictly
+                               # have an email name. In addition comments should strictly
                                # begin with a #
                                if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
                                        if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -7109,7 +7109,7 @@ sub process {
                exit(0);
        }
 
-       # This is not a patch, and we are are in 'no-patch' mode so
+       # This is not a patch, and we are in 'no-patch' mode so
        # just keep quiet.
        if (!$chk_patch && !$is_patch) {
                exit(0);
--

2.27.0

#2 lore raw
Quoted 6 lines · Lukas Bulwahn
Quoted 4 lines · Dwaipayan Ray

Delete repeated word in scripts/checkpatch.pl.
"are are" -> "are"

Quoted 9 lines
Quoted 3 lines

Fix typo "commments" -> "comments"

Does this make checkpatch.pl pass checkpatch without any further warnings?

Nice idea to check if checkpatch.pl still fulfills the checkpatch rules we created...

Yes, all the rules pass.

$ ./scripts/checkpatch.pl --codespell --strict -f scripts/checkpatch.pl
gives:
total: 0 errors, 0 warnings, 10 checks, 7233 lines checked

9 of those checks are false positives. There is another misspelled word:
#5003: FILE: scripts/checkpatch.pl:5003:
+## # falsly report the parameters of functions.

I will add that and resend.

Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees