Skip to contentSkip to conversation

checkpatch: fix typo and remove duplicate word

PATCH In review Dwaipayan Ray 2 participants 3 messages Nov 13, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: fix typo and remove duplicate word

Delete repeated word in scripts/checkpatch.pl:
"are are" -> "are"

Fix typos:
"commments" -> "comments"
"falsly" -> "falsely"

---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +3 -3
index 2749f32dffe9..041b82f6669e 100755
@@ -2841,7 +2841,7 @@ sub process {
 
 
 				# [email protected] or [email protected] shouldn't
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -5000,7 +5000,7 @@ sub process {
 ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
 ##
 ## 			# Remove any bracketed sections to ensure we do not
-## 			# falsly report the parameters of functions.
+## 			# falsely report the parameters of functions.
 ## 			my $ln = $line;
 ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
 ## 			}
@@ -7109,7 +7109,7 @@ sub process {
 		exit(0);
 	}
 
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 9 lines · Dwaipayan Ray

Delete repeated word in scripts/checkpatch.pl:
"are are" -> "are"

Fix typos:
"commments" -> "comments"
"falsly" -> "falsely"

---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get used the proper patch resubmission form but thanks.

Quoted 37 lines

 scripts/checkpatch.pl | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +0 -0
index 2749f32dffe9..041b82f6669e 100755
@@ -2841,7 +2841,7 @@ sub process {

  # [email protected] or [email protected] shouldn't

scripts/checkpatch.pl +1 -1
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
scripts/checkpatch.pl +1 -1
@@ -5000,7 +5000,7 @@ sub process {
  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
  ##
  ## 			# Remove any bracketed sections to ensure we do not
-## 			# falsly report the parameters of functions.
+## 			# falsely report the parameters of functions.
  ## 			my $ln = $line;
  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
  ## 			}
@@ -7109,7 +7109,7 @@ sub process {
  		exit(0);
  	}

scripts/checkpatch.pl +1 -1
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
#2 lore raw
Quoted 14 lines · Joe Perches
Quoted 9 lines · Dwaipayan Ray

Delete repeated word in scripts/checkpatch.pl:
"are are" -> "are"

Fix typos:
"commments" -> "comments"
"falsly" -> "falsely"

---

style: this should have subject prefix:

Quoted 9 lines

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get used the proper patch resubmission form but thanks.

Thanks, I will do that.

Regards,
Dwaipayan.