Skip to contentSkip to conversation

x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()

PATCH In review Vitaly Kuznetsov 2 participants 3 messages Nov 13, 2020 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()

Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in KASLR code") finalize_identity_maps() has no users, drop it.

---
 arch/x86/boot/compressed/ident_map_64.c | 10 ----------
 1 file changed, 10 deletions(-)
arch/x86/boot/compressed/ident_map_64.c +0 -10
index a5e5db6ada3c..6bf20223dc0f 100644
@@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
 	write_cr3(top_level_pgt);
 }
 
-/*
- * This switches the page tables to the new level4 that has been built
- * via calls to add_identity_map() above. If booted via startup_32(),
- * this is effectively a no-op.
- */
-void finalize_identity_maps(void)
-{
-	write_cr3(top_level_pgt);
-}
-
 static pte_t *split_large_pmd(struct x86_mapping_info *info,
 			      pmd_t *pmdp, unsigned long __address)
 {
Signature · 1 line
2.26.2
#1 lore raw
Quoted 32 lines · Vitaly Kuznetsov

Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in KASLR code") finalize_identity_maps() has no users, drop it.

---
 arch/x86/boot/compressed/ident_map_64.c | 10 ----------
 1 file changed, 10 deletions(-)
arch/x86/boot/compressed/ident_map_64.c +0 -10
index a5e5db6ada3c..6bf20223dc0f 100644
@@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
 	write_cr3(top_level_pgt);
 }
 
-/*
- * This switches the page tables to the new level4 that has been built
- * via calls to add_identity_map() above. If booted via startup_32(),
- * this is effectively a no-op.
- */
-void finalize_identity_maps(void)
-{
-	write_cr3(top_level_pgt);
-}
-
 static pte_t *split_large_pmd(struct x86_mapping_info *info,
 			      pmd_t *pmdp, unsigned long __address)
 {
Signature · 1 line
2.26.2

I had sent this and another unused removal last month:
https://lore.kernel.org/lkml/[email protected]/

Thanks.

#2 lore raw
Quoted 28 lines · Arvind Sankar
Quoted 27 lines · Vitaly Kuznetsov

Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in KASLR code") finalize_identity_maps() has no users, drop it.

---
 arch/x86/boot/compressed/ident_map_64.c | 10 ----------
 1 file changed, 10 deletions(-)
arch/x86/boot/compressed/ident_map_64.c +0 -10
index a5e5db6ada3c..6bf20223dc0f 100644
@@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
 	write_cr3(top_level_pgt);
 }
 
-/*
- * This switches the page tables to the new level4 that has been built
- * via calls to add_identity_map() above. If booted via startup_32(),
- * this is effectively a no-op.
- */
-void finalize_identity_maps(void)
-{
-	write_cr3(top_level_pgt);
-}
-
 static pte_t *split_large_pmd(struct x86_mapping_info *info,
Quoted 9 lines
Quoted 5 lines
arch/x86/boot/compressed/ident_map_64.c +0 -0
 			      pmd_t *pmdp, unsigned long __address)
 {
Signature · 1 line
2.26.2

I had sent this and another unused removal last month:
https://lore.kernel.org/lkml/[email protected]/

Ah, no problem, let this serve as a gentle ping to the maintainers then)

Signature · 1 line
Vitaly