locking-selftest: add option to proceed through unexpected failures
Subsystems (2)
PATCH 1/1 locking-selftest: add option to proceed through unexpected failures
Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures. Add option to not disable debug_locks, so as to let it reveal any locking flaws in new unrelated work.
--- lib/locking-selftest.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-)
lib/locking-selftest.c +18 -3
@@ -41,6 +41,20 @@ static int __init setup_debug_locks_verbose(char *str)__setup ("debug_locks_verbose=" , setup_debug_locks_verbose); +/* +* proceed thru debug fails, leave debugging enabled +*/ +static unsigned int debug_locks_proceed; + +static int __init setup_debug_locks_proceed (char *str) +{ +get_option (&str, &debug_locks_proceed); + +return 1 ; +} + +__setup ("debug_locks_proceed=" , setup_debug_locks_proceed); +#define FAILURE 0#define SUCCESS 1
@@ -2480,9 +2494,10 @@ void locking_selftest(void)if (unexpected_testcase_failures) {printk ("-----------------------------------------------------------------\n" ); - debug_locks =0 ; -printk ("BUG: %3d unexpected failures (out of %3d) - debugging disabled! |\n" , - unexpected_testcase_failures, testcase_total); + debug_locks = debug_locks_proceed; +printk ("BUG: %3d unexpected failures (out of %3d) - debugging %s! |\n" , + unexpected_testcase_failures, testcase_total, + (!debug_locks_proceed) ?"disabled" :"proceeding anyway" );printk ("-----------------------------------------------------------------\n" ); }else if (expected_testcase_failures && testcase_successes) {printk ("--------------------------------------------------------\n" );
Signature · 1 line
2.28.0
Peter Zijlstra
maintainerQuoted 3 lines · Jim Cromie
Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures. Add option to not disable
debug_locks, so as to let it reveal any locking flaws in new unrelated work.
I'm assuming this is the arm64 fallout? Mark anything I can do to help you there?
The reasoning doesn't make sense though; if it can't pass the selftest, then why would you trust any further reports?
Quoted 11 lines · Peter Zijlstra
Quoted 3 lines · Jim Cromie
Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures. Add option to not disable
debug_locks, so as to let it reveal any locking flaws in new unrelated work.I'm assuming this is the arm64 fallout? Mark anything I can do to help you there?
The reasoning doesn't make sense though; if it can't pass the selftest, then why would you trust any further reports?
because it knows more than I do.
having chosen to proceed anyway,
Im free to discount the advice.