HID: logitech-dj: Fix an error in mse_bluetooth_descriptor
Subsystems (2)
PATCH 1/1 HID: logitech-dj: Fix an error in mse_bluetooth_descriptor
Fix an error in the mouse / INPUT(2) descriptor used for quad/bt2.0 combo receivers. Replace INPUT with INPUT (Data,Var,Abs) for the field for the 4 extra buttons which share their report-byte with the low-res hwheel.
This is likely a copy and paste error. I've verified that the new 0x81, 0x02 value matches both the mouse descriptor for the currently supported MX5000 / MX5500 receivers, as well as the INPUT(2) mouse descriptors for the Dinovo receivers for which support is being worked on.
--- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-logitech-dj.c +1 -1
@@ -330,7 +330,7 @@ static const char mse_bluetooth_descriptor[] = {0x25 ,0x01 ,/* LOGICAL_MAX (1) */ 0x75 ,0x01 ,/* REPORT_SIZE (1) */ 0x95 ,0x04 ,/* REPORT_COUNT (4) */ -0x81 ,0x06 ,/* INPUT */ +0x81 ,0x02 ,/* INPUT (Data,Var,Abs) */ 0xC0 ,/* END_COLLECTION */ 0xC0, /* END_COLLECTION */ };
Signature · 1 line
2.28.0
Hi Hans,
[sorry for taking long to get to this, I wanted to conduct some tests with the Dinovo Mini with this patch and the series after]
Quoted 5 lines · Hans de Goede
Fix an error in the mouse / INPUT(2) descriptor used for quad/bt2.0 combo receivers. Replace INPUT with INPUT (Data,Var,Abs) for the field for the 4 extra buttons which share their report-byte with the low-res hwheel.
Quoted 7 lines
This is likely a copy and paste error. I've verified that the new
0x81,0x02value matches both the mouse descriptor for the currently supported MX5000 / MX5500 receivers, as well as the INPUT(2) mouse descriptors for the Dinovo receivers for which support is being worked on.Fixes f2113c3020ef ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver")
I suppose you also want a cc:stable tag here too?
I have added the patch to my local tests, and if you are happy with it, I can push it upstream.
Cheers,
Benjamin
Quoted 21 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-logitech-dj.c +1
-2@@ -330,7 +330,7 @@ static const char mse_bluetooth_descriptor[] = {0x25 ,0x01 ,/* LOGICAL_MAX (1) */ 0x75 ,0x01 ,/* REPORT_SIZE (1) */ 0x95 ,0x04 ,/* REPORT_COUNT (4) */ -0x81 ,0x06 ,/* INPUT */ +0x81 ,0x02 ,/* INPUT (Data,Var,Abs) */ 0xC0 ,/* END_COLLECTION */ 0xC0, /* END_COLLECTION */ }; --2.28.0
Hi,
Quoted 4 lines · Benjamin Tissoires
Hi Hans,
[sorry for taking long to get to this, I wanted to conduct some tests with the Dinovo Mini with this patch and the series after]
No problem.
Quoted 12 lines · Hans de Goede
Quoted 11 lines
Fix an error in the mouse / INPUT(2) descriptor used for quad/bt2.0 combo receivers. Replace INPUT with INPUT (Data,Var,Abs) for the field for the 4 extra buttons which share their report-byte with the low-res hwheel.
This is likely a copy and paste error. I've verified that the new
0x81,0x02value matches both the mouse descriptor for the currently supported MX5000 / MX5500 receivers, as well as the INPUT(2) mouse descriptors for the Dinovo receivers for which support is being worked on.
Quoted 3 lines
Quoted 1 line
Fixes f2113c3020ef ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver")I suppose you also want a cc:stable tag here too?
In my experience the stable maintainers pick up most patches with a fixes tag anyways. With that said adding a cc:stable tag is fine.
Quoted 2 lines
I have added the patch to my local tests, and if you are happy with it, I can push it upstream.
Pushing this patch upstream is fine with me.
Regards,
Hans
Quoted 22 lines
Quoted 21 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-logitech-dj.c +1
-2@@ -330,7 +330,7 @@ static const char mse_bluetooth_descriptor[] = {0x25 ,0x01 ,/* LOGICAL_MAX (1) */ 0x75 ,0x01 ,/* REPORT_SIZE (1) */ 0x95 ,0x04 ,/* REPORT_COUNT (4) */ -0x81 ,0x06 ,/* INPUT */ +0x81 ,0x02 ,/* INPUT (Data,Var,Abs) */ 0xC0 ,/* END_COLLECTION */ 0xC0, /* END_COLLECTION */ }; --2.28.0
Quoted 27 lines · Hans de Goede
Hi,
Quoted 4 lines · Benjamin Tissoires
Hi Hans,
[sorry for taking long to get to this, I wanted to conduct some tests with the Dinovo Mini with this patch and the series after]
No problem.
Quoted 12 lines · Hans de Goede
Quoted 11 lines
Fix an error in the mouse / INPUT(2) descriptor used for quad/bt2.0 combo receivers. Replace INPUT with INPUT (Data,Var,Abs) for the field for the 4 extra buttons which share their report-byte with the low-res hwheel.
This is likely a copy and paste error. I've verified that the new
0x81,0x02value matches both the mouse descriptor for the currently supported MX5000 / MX5500 receivers, as well as the INPUT(2) mouse descriptors for the Dinovo receivers for which support is being worked on.Quoted 3 lines
Quoted 1 line
Fixes f2113c3020ef ("HID: logitech-dj: add support for Logitech Bluetooth Mini-Receiver")I suppose you also want a cc:stable tag here too?
Quoted 7 lines
In my experience the stable maintainers pick up most patches with a fixes tag anyways. With that said adding a cc:stable tag is fine.
Quoted 2 lines
I have added the patch to my local tests, and if you are happy with it, I can push it upstream.
Pushing this patch upstream is fine with me.
Alright, this is now done, and with 1/3 of the RFC of the dinovo mini series
Cheers,
Benjamin
Quoted 30 lines
Regards,
Hans
Quoted 22 lines
Quoted 21 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-logitech-dj.c +1
-2@@ -330,7 +330,7 @@ static const char mse_bluetooth_descriptor[] = {0x25 ,0x01 ,/* LOGICAL_MAX (1) */ 0x75 ,0x01 ,/* REPORT_SIZE (1) */ 0x95 ,0x04 ,/* REPORT_COUNT (4) */ -0x81 ,0x06 ,/* INPUT */ +0x81 ,0x02 ,/* INPUT (Data,Var,Abs) */ 0xC0 ,/* END_COLLECTION */ 0xC0, /* END_COLLECTION */ }; --2.28.0