Skip to contentSkip to conversation

arm-bsp/n1sdp: remove swap parition entry from wic image

PATCH Applied Khasim Mohammed 2 participants 4 messages Nov 12, 2020 – Nov 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm-bsp/n1sdp: remove swap parition entry from wic image

The swap partition on n1sdp seem to create an issue when shutdown or reboot is run from the shell prompt, the console stops at "Deactivating swap ...". Hence removing the swap partition entry from wic image.

Change-Id I22cf971fdde7e3b8b386c74003983fab3d309cc5
---
 meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --
 1 file changed, 2 deletions(-)
meta-arm-bsp/wic/n1sdp-efidisk.wks +0 -2
index d1ebfb8..b131dd8 100644
@@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --
 
 part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd
 
-part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-
 bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 6 lines · Khasim Mohammed

The swap partition on n1sdp seem to create an issue when shutdown or reboot is run from the shell prompt, the console stops at "Deactivating swap ...". Hence removing the swap partition entry from wic image.

Change-Id I22cf971fdde7e3b8b386c74003983fab3d309cc5

Applied to master.

Thanks,
Jon

Quoted 22 lines
---
 meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --
 1 file changed, 2 deletions(-)
meta-arm-bsp/wic/n1sdp-efidisk.wks +0 -2
index d1ebfb8..b131dd8 100644
@@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --
 
 part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd
 
-part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-
 bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5
Signature · 1 line
2.17.1
#2 lore raw

Hi Jon,

________________________________________
From: Jon Mason <[email protected]>
Sent: Monday, November 16, 2020 7:55 PM
To: Khasim Mohammed
Cc: [email protected]; nd
Subject: Re: [meta-arm] [PATCH] arm-bsp/n1sdp: remove swap parition entry from wic image

Quoted 8 lines · Khasim Mohammed

The swap partition on n1sdp seem to create an issue when shutdown or reboot is run from the shell prompt, the console stops at "Deactivating swap ...". Hence removing the swap partition entry from wic image.

Change-Id I22cf971fdde7e3b8b386c74003983fab3d309cc5

Applied to master.

Can you please apply this patch to gatesgarth branch as well ?

Thanks,
Jon

Quoted 22 lines
---
 meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --
 1 file changed, 2 deletions(-)
meta-arm-bsp/wic/n1sdp-efidisk.wks +0 -3
index d1ebfb8..b131dd8 100644
@@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --
 
 part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd
 
-part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-
 bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5
--

2.17.1

#3 lore raw
Quoted 14 lines · Khasim Mohammed

Hi Jon,

________________________________________
From: Jon Mason <[email protected]>
Sent: Monday, November 16, 2020 7:55 PM
To: Khasim Mohammed
Cc: [email protected]; nd
Subject: Re: [meta-arm] [PATCH] arm-bsp/n1sdp: remove swap parition entry from wic image

Quoted 4 lines · Khasim Mohammed

The swap partition on n1sdp seem to create an issue when shutdown or reboot is run from the shell prompt, the console stops at "Deactivating swap ...". Hence removing the swap partition entry from wic image.

Quoted 6 lines
Quoted 4 lines
Change-Id I22cf971fdde7e3b8b386c74003983fab3d309cc5

Applied to master.

Can you please apply this patch to gatesgarth branch as well ?

Done

Quoted 27 lines

Thanks,
Jon

Quoted 22 lines
---
 meta-arm-bsp/wic/n1sdp-efidisk.wks | 2 --
 1 file changed, 2 deletions(-)
meta-arm-bsp/wic/n1sdp-efidisk.wks +0 -3
index d1ebfb8..b131dd8 100644
@@ -6,6 +6,4 @@ part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --
 
 part / --source rootfs --ondisk sda --fstype=ext4 --label root --align 1024 --uuid=6a60524d-061d-454a-bfd1-38989910eccd
 
-part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-
 bootloader --ptable gpt --configfile="n1sdp-grub.cfg" --timeout=5
--

2.17.1