Skip to contentSkip to conversation

Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet

PATCH In review Simon Beginn 3 participants 5 messages Nov 17, 2020 – Dec 11, 2020 4 messages not in the archive

Subsystems (3)
HID Input drivers Goodix touchscreen
lore
Share & tools
lore

Simon Beginn

author
#0 lore raw

PATCH 1/1 Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet

The touchscreen on the Teclast x98 Pro is also mounted upside-down in relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...

drivers/input/touchscreen/goodix.c +10 -0
index f8dd416c89b2..7668174b62ed 100644
@@ -136,6 +136,16 @@ static const struct dmi_system_id rotated_screen[] = {
                        DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
                },
        },
+       {
+               .ident = "Teclast X98 Pro",
+               .matches = {
+                       /* Only match bios date, because the manufacturers bios
+                        * does not report the board name at all (sometimes)...
+                        */
+                       DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
+                       DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
+               },
+       },
        {
                .ident = "WinBook TW100",
                .matches = {
#1 lore raw
Quoted 4 lines · Simon Beginn

The touchscreen on the Teclast x98 Pro is also mounted upside-down in relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...

Looks good to me, thanks.

Signed-off-by Bastien Nocera <[email protected]>
Quoted 26 lines
drivers/input/touchscreen/goodix.c +4 -0
index f8dd416c89b2..7668174b62ed 100644
@@ -136,6 +136,16 @@ static const struct dmi_system_id
 rotated_screen[] = {
                         DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
                 },
         },
+       {
+               .ident = "Teclast X98 Pro",
+               .matches = {
+                       /* Only match bios date, because the

manufacturers bios
+                        * does not report the board name at all (sometimes)...
+                        */
+                       DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), +                       DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"), +               },
+       },
        {
                .ident = "WinBook TW100",
                .matches = {

#2 lore raw
Quoted 10 lines · Bastien Nocera
Quoted 5 lines · Simon Beginn

The touchscreen on the Teclast x98 Pro is also mounted upside-down in
relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...

Looks good to me, thanks.

Signed-off-by Bastien Nocera <[email protected]>

Dmitry, this seems to have slipped through the cracks. Can you please pick it up for the next merge window?

Cheers

maintainer
#3 lore raw

Hi Bastien,

Quoted 8 lines · Bastien Nocera
Quoted 7 lines · Bastien Nocera
Quoted 5 lines · Simon Beginn

The touchscreen on the Teclast x98 Pro is also mounted upside-down in
relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...

Quoted 6 lines
Quoted 3 lines

Looks good to me, thanks.

Signed-off-by Bastien Nocera <[email protected]>

Dmitry, this seems to have slipped through the cracks. Can you please pick it up for the next merge window?

Argh, the original patch went into spam folder because the domain requires dmarc enforcement and Gmail is happy to oblige:

ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of [email protected] designates 23.128.96.18 as permitted sender) [email protected];
dmarc=fail (p=REJECT sp=REJECT dis=QUARANTINE) header.from=simonmicro.de

Regardless, I need "Signed-off-by" from Simon before I can apply it.

Thanks.

Signature · 1 line
Dmitry

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

maintainer
#8 lore raw

Hi Simon,

Quoted 6 lines · Simon Beginn

Hi,

all right - try #3

Cc Dmitry Torokhov <[email protected]>
Signed-off-by Simon Beginn <[email protected]>

Could you please send your Signed-off-by _with the patch_ so that I do not have try to reassemble this from separate emails. Also, I see that in the original patch either your editor or mailer converted all tabs into spaces so that the patch does not apply.

Thanks.

Signature · 1 line
Dmitry