Skip to contentSkip to conversation

(v2) drivers: clk: make gpio-gated clock support optional

PATCH Superseded Enrico Weigelt, metux IT consult 3 participants 3 messages Nov 17, 2020 – Dec 3, 2020

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 (v2) drivers: clk: make gpio-gated clock support optional

The gpio-gate-clock / gpio-mux-clock driver isn't used much, just by a few ARM SoCs, so there's no need to always include it unconditionally.

Thus make it optional, but keep it enabled by default.

fixes v2: added missing dependency on gpiolib

---
 drivers/clk/Kconfig  | 8 ++++++++
 drivers/clk/Makefile | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
drivers/clk/Kconfig +8 -0
index c715d4681a0b..99e0188a15be 100644
@@ -38,6 +38,14 @@ menuconfig COMMON_CLK
 
 if COMMON_CLK
 
+config COMMON_CLK_GPIO
+	tristate "GPIO gated clock support"
+	default y
+	select gpiolib
+	help
+	  Supports gpio gated clocks, which can be enabled/disabled via
+	  gpio output.
+
 config COMMON_CLK_WM831X
 	tristate "Clock driver for WM831x/2x PMICs"
 	depends on MFD_WM831X
drivers/clk/Makefile +1 -1
index da8fcf147eb1..0692ab5abc6d 100644
@@ -11,7 +11,7 @@ obj-$(CONFIG_COMMON_CLK)	+= clk-multiplier.o
 obj-$(CONFIG_COMMON_CLK)	+= clk-mux.o
 obj-$(CONFIG_COMMON_CLK)	+= clk-composite.o
 obj-$(CONFIG_COMMON_CLK)	+= clk-fractional-divider.o
-obj-$(CONFIG_COMMON_CLK)	+= clk-gpio.o
+obj-$(CONFIG_COMMON_CLK_GPIO)	+= clk-gpio.o
 ifeq ($(CONFIG_OF), y)
 obj-$(CONFIG_COMMON_CLK)	+= clk-conf.o
 endif
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06)

drivers/clk/Kconfig menuconfig COMMON_CLK · line 43

Quoted 11 lines
drivers/clk/Kconfig +3 -0
index c715d4681a0b..99e0188a15be 100644
@@ -38,6 +38,14 @@ menuconfig COMMON_CLK
 
 if COMMON_CLK
 
+config COMMON_CLK_GPIO
+       tristate "GPIO gated clock support"
+       default y

Maybe 'default GPIOLIB'?

drivers/clk/Kconfig menuconfig COMMON_CLK · line 44

Quoted 1 line
drivers/clk/Kconfig +1 -0
+       select gpiolib

Does lowercase work here?

Quoted 7 lines
drivers/clk/Kconfig +4 -0
+       help
+         Supports gpio gated clocks, which can be enabled/disabled via
+         gpio output.
+
 config COMMON_CLK_WM831X
        tristate "Clock driver for WM831x/2x PMICs"
        depends on MFD_WM831X
#2 lore raw
Quoted 15 lines · Stephen Boyd

Quoting Enrico Weigelt, metux IT consult (2020-11-17 08:03:06)

drivers/clk/Kconfig menuconfig COMMON_CLK · line 43

Quoted 11 lines
drivers/clk/Kconfig +3 -0
index c715d4681a0b..99e0188a15be 100644
@@ -38,6 +38,14 @@ menuconfig COMMON_CLK
 
 if COMMON_CLK
 
+config COMMON_CLK_GPIO
+       tristate "GPIO gated clock support"
+       default y

Maybe 'default GPIOLIB'?

Quoted 11 lines

drivers/clk/Kconfig menuconfig COMMON_CLK · line 44

Quoted 1 line
drivers/clk/Kconfig +1 -0
+       select gpiolib

Does lowercase work here?

Quoted 7 lines
drivers/clk/Kconfig +4 -0
+       help
+         Supports gpio gated clocks, which can be enabled/disabled via
+         gpio output.
+
 config COMMON_CLK_WM831X
        tristate "Clock driver for WM831x/2x PMICs"
        depends on MFD_WM831X

thanks, fixed it in v3.

BTW: just accidentially posted an outdated and broken version again (some submit helper script was running wild :() - please ignore that. the valid one is v3 from yesterday. sorry for the noise.

--mtx

Signature · 13 lines
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv