mm/lru: simplify is_file_lru() and is_active_lru()
Subsystems (4)
PATCH 1/1 mm/lru: simplify is_file_lru() and is_active_lru()
lru_list lru bit 0 can tell whether the list is avtive lru-list or not.lru_list lru bit 1 can tell whether the list is file lru-list or not.
And fix some define type in shrink_active_list() and get_scan_count().
v1->v2:
correct the commit message, and fix the define type.
--- include/linux/mmzone.h | 4 ++-- mm/vmscan.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
include/linux/mmzone.h +2 -2
@@ -258,12 +258,12 @@ enum lru_list {static inline bool is_file_lru (enum lru_list lru) { -return (lru ==LRU_INACTIVE_FILE || lru ==LRU_ACTIVE_FILE ); +return lru &LRU_FILE ; }static inline bool is_active_lru (enum lru_list lru) { -return (lru ==LRU_ACTIVE_ANON || lru ==LRU_ACTIVE_FILE ); +return lru &LRU_ACTIVE ; }#define ANON_AND_FILE 2
mm/vmscan.c +2 -2
@@ -2020,7 +2020,7 @@ static void shrink_active_list(unsigned long nr_to_scan,struct page *page;unsigned nr_deactivate, nr_activate;unsigned nr_rotated =0 ; -int file =is_file_lru (lru); +bool file =is_file_lru (lru);struct pglist_data *pgdat =lruvec_pgdat (lruvec);lru_add_drain ();
@@ -2323,7 +2323,7 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, denominator = ap + fp; out:for_each_evictable_lru (lru) { -int file =is_file_lru (lru); +bool file =is_file_lru (lru);unsigned long lruvec_size;unsigned long scan;unsigned long protection;
Signature · 1 line
2.29.0
Quoted 10 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.
No, still incorrect.
Quoted 6 lines · Matthew Wilcox
Quoted 5 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.
Quoted 7 lines
Quoted 5 lines
And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.No, still incorrect.
I am a little confused, can you tell in detail?
Thanks.
Quoted 10 lines · Hui Su
Quoted 9 lines · Matthew Wilcox
Quoted 8 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
v1->v2:
correct the commit message, and fix the define type.No, still incorrect.
I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of tests on it?
Quoted 14 lines · Matthew Wilcox
Quoted 13 lines · Hui Su
Quoted 12 lines · Matthew Wilcox
Quoted 10 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
No, still incorrect.
I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of tests on it?
Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
qemu-system-x86_64 -kernel /home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage -hda \
/home/rlk/myspace/qemu_build/rootfs.img -append "root=/dev/sda console=ttyS0" -nographic
using the kernel compiled with ubuntu20.04's default .config.
It seems nothing abnormal.
And i did not do other test.
Quoted 22 lines · Hui Su
Quoted 14 lines · Matthew Wilcox
Quoted 13 lines · Hui Su
Quoted 12 lines · Matthew Wilcox
Quoted 10 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.Quoted 6 lines
Quoted 3 lines
Quoted 1 line
No, still incorrect.
I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of tests on it?
Quoted 8 lines
Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
qemu-system-x86_64 -kernel/home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage-hda \
/home/rlk/myspace/qemu_build/rootfs.img-append "root=/dev/sda console=ttyS0" -nographicusing the kernel compiled with ubuntu20.04's default .config.
It seems nothing abnormal.
And i did not do other test.
Maybe you should ... how about LTP? I think that's pretty straightforward to set up and run.
Quoted 27 lines · Matthew Wilcox
Quoted 26 lines · Hui Su
Quoted 14 lines · Matthew Wilcox
Quoted 13 lines · Hui Su
Quoted 12 lines · Matthew Wilcox
Quoted 10 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.Quoted 6 lines
Quoted 3 lines
Quoted 1 line
No, still incorrect.
I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of tests on it?
Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
qemu-system-x86_64 -kernel/home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage-hda \
/home/rlk/myspace/qemu_build/rootfs.img-append "root=/dev/sda console=ttyS0" -nographic
Quoted 7 lines
Quoted 4 lines
using the kernel compiled with ubuntu20.04's default .config.
It seems nothing abnormal.
And i did not do other test.Maybe you should ... how about LTP? I think that's pretty straightforward to set up and run.
Thanks for your advice, Matthew.
I will set up an ltp test envirment, thanks again.
And Please ignore this change for now.
Quoted 27 lines · Matthew Wilcox
Quoted 26 lines · Hui Su
Quoted 14 lines · Matthew Wilcox
Quoted 13 lines · Hui Su
Quoted 12 lines · Matthew Wilcox
Quoted 10 lines · Hui Su
lru_listlru bit 0 can tell whether the list is avtive lru-list or not.lru_listlru bit 1 can tell whether the list is file lru-list or not.And fix some define type in
shrink_active_list()andget_scan_count().
v1->v2:
correct the commit message, and fix the define type.Quoted 6 lines
Quoted 3 lines
Quoted 1 line
No, still incorrect.
I am a little confused, can you tell in detail?
Have you booted a kernel with this change? Have you run any kind of tests on it?
Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
qemu-system-x86_64 -kernel/home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage-hda \
/home/rlk/myspace/qemu_build/rootfs.img-append "root=/dev/sda console=ttyS0" -nographic
Quoted 7 lines
Quoted 4 lines
using the kernel compiled with ubuntu20.04's default .config.
It seems nothing abnormal.
And i did not do other test.Maybe you should ... how about LTP? I think that's pretty straightforward to set up and run.
Hi Matthew:
Thanks for your advice, i finally setup a test platform powered by jenkins and QEMU emulator version 4.2.1 with two evening. This is the things that i always wanted to do but didn't do.
I apply this change based on the commit: 4d02da974ea8, and compile it with x86_64_defconfig:
make bzImage O=/var/lib/jenkins/workspace/linux_kernel_ltp/out/
Then start qemu:
sudo qemu-system-x86_64 \
-kernel /var/lib/jenkins/workspace/linux_kernel_ltp/out/arch/x86/boot/bzImage \
-hda /home/ubuntu/myspace/qemu_build/ubuntu.img \
-hdb /home/ubuntu/myspace/qemu_build/init.img \
-append "root=/dev/sda console=ttyS0" \
-nographic \
-m 1024 \
-fsdev local,id=fs1,path=/home/ubuntu/workspace,security_model=none \
-device virtio-9p-pci,fsdev=fs1,mount_tag=jeff-host-codeThen run the ltp test:
sudo bash /opt/ltp/runltp -f mm
The result is:
Test Start Time: Sat Nov 21 02:06:46 2020
-----------------------------------------
Testcase Result Exit Value -------- ------ ---------- mm01 PASS 0 mm02 PASS 0 mtest01 PASS 0 mtest01w PASS 0 mtest05 PASS 0 mtest06 FAIL 2 mtest06_2 PASS 0 mtest06_3 PASS 0 mem02 PASS 0
mmapstress01 PASS 0 mmapstress02 PASS 0 mmapstress03 PASS 0 mmapstress04 PASS 0 mmapstress05 PASS 0 mmapstress06 PASS 0 mmapstress07 PASS 0 mmapstress08 PASS 0 mmapstress09 PASS 0 mmapstress10 PASS 0 mmap10 PASS 0 mmap10_1 PASS 0 mmap10_2 CONF 32 mmap10_3 CONF 32 mmap10_4 CONF 32 ksm01 CONF 32 ksm01_1 CONF 32 ksm02 CONF 32 ksm02_1 CONF 32 ksm03 CONF 32 ksm03_1 CONF 32 ksm04 CONF 32 ksm04_1 CONF 32 ksm05 CONF 32 ksm06 CONF 32
thp02 CONF 32 thp03 CONF 32 thp04 CONF 32 vma01 PASS 0 vma02 CONF 32 vma03 CONF 32 vma04 CONF 32 vma05 CONF 32 overcommit_memory01 PASS 0 overcommit_memory02 CONF 32 overcommit_memory03 PASS 0 overcommit_memory04 PASS 0 overcommit_memory05 PASS 0 overcommit_memory06 PASS 0 max_map_count PASS 0 min_free_kbytes PASS 0
-----------------------------------------------
Total Tests: 76
Total Skipped Tests: 29
Total Failures: 1
Kernel Version: 5.10.0-rc4+
Machine Architecture: x86_64
Hostname: ubuntu
The one failure happens without my change, too.(maybe my config is not correct? I am not sure).
Last, i think this change have no problem.
And what's your opinions, Matthew.
Thanks.