Skip to contentSkip to conversation

gpiolib: do not print err message for EPROBE_DEFER

PATCH In review Grygorii Strashko 2 participants 3 messages Nov 18, 2020 – Dec 1, 2020 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: do not print err message for EPROBE_DEFER

The gpiochip may have dependencies from pinmux and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which is unnecessary:

"gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to register, -517"

Hence, do suppress error message for -EPROBE_DEFER case.

---
 drivers/gpio/gpiolib.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpio/gpiolib.c +5 -3
index 089ddcaa9bc6..fd2c503a6aab 100644
@@ -771,9 +771,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 	ida_free(&gpio_ida, gdev->id);
 err_free_gdev:
 	/* failures here can mean systems won't boot... */
-	pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
-	       gdev->base, gdev->base + gdev->ngpio - 1,
-	       gc->label ? : "generic", ret);
+	if (ret != -EPROBE_DEFER) {
+		pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
+		       gdev->base, gdev->base + gdev->ngpio - 1,
+		       gc->label ? : "generic", ret);
+	}
 	kfree(gdev);
 	return ret;
 }
Signature · 1 line
2.17.1
#1 lore raw

hi Bartosz, All,

Quoted 23 lines · Grygorii Strashko

The gpiochip may have dependencies from pinmux and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which is unnecessary:

"gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to register, -517"

Hence, do suppress error message for -EPROBE_DEFER case.

---
  drivers/gpio/gpiolib.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpio/gpiolib.c +0 -1
index 089ddcaa9bc6..fd2c503a6aab 100644
@@ -771,9 +771,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
  	ida_free(&gpio_ida, gdev->id);
  err_free_gdev:
  	/* failures here can mean systems won't boot... */
-	pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,

drivers/gpio/gpiolib.c int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, · line 781

Quoted 10 lines
drivers/gpio/gpiolib.c +5 -2
-	       gdev->base, gdev->base + gdev->ngpio - 1,
-	       gc->label ? : "generic", ret);
+	if (ret != -EPROBE_DEFER) {
+		pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
+		       gdev->base, gdev->base + gdev->ngpio - 1,
+		       gc->label ? : "generic", ret);
+	}
  	kfree(gdev);
  	return ret;
  }

Any comments for this patch?

Note. Modern dev_err_probe() seems can't be used as gpio_chip->parent is not guaranteed to be set and it's not clear if chip_err() still can be used at this stage.

Signature · 2 lines
Best regards,
grygorii
#2 lore raw
Quoted 40 lines · Grygorii Strashko

hi Bartosz, All,

Quoted 23 lines · Grygorii Strashko

The gpiochip may have dependencies from pinmux and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which is unnecessary:

"gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to register, -517"

Hence, do suppress error message for -EPROBE_DEFER case.

---
  drivers/gpio/gpiolib.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpio/gpiolib.c +0 -1
index 089ddcaa9bc6..fd2c503a6aab 100644
@@ -771,9 +771,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
      ida_free(&gpio_ida, gdev->id);
  err_free_gdev:
      /* failures here can mean systems won't boot... */
-     pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,

drivers/gpio/gpiolib.c int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, · line 781

Quoted 10 lines
drivers/gpio/gpiolib.c +5 -2
-            gdev->base, gdev->base + gdev->ngpio - 1,
-            gc->label ? : "generic", ret);
+     if (ret != -EPROBE_DEFER) {
+             pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
+                    gdev->base, gdev->base + gdev->ngpio - 1,
+                    gc->label ? : "generic", ret);
+     }
      kfree(gdev);
      return ret;
  }

Any comments for this patch?

Quoted 6 lines

Note. Modern dev_err_probe() seems can't be used as gpio_chip->parent is not guaranteed to be set and it's not clear if chip_err() still can be used at this stage.

--
Best regards,
grygorii

I applied this patch now. We seem to have a patch congestion on the list - I'm trying to get through unread email but more is coming everyday. :(

Bartosz