Skip to contentSkip to conversation

remove unused functions

RFC In review Ferruh Yigit 7 participants 16 messages Nov 19, 2020 – Jun 14, 2023

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

RFC 1/1 remove unused functions

Removing unused functions, reported by cppcheck.

Easy way to remove clutter, since the code is already in the git repo, they can be added back when needed.

---
 app/test-eventdev/parser.c                    |   88 -
 app/test-eventdev/parser.h                    |    6 -
 app/test/test_table_pipeline.c                |   36 -
 drivers/bus/dpaa/base/fman/fman_hw.c          |  182 -
 drivers/bus/dpaa/base/fman/netcfg_layer.c     |   11 -
 drivers/bus/dpaa/base/qbman/bman.c            |   34 -
 drivers/bus/dpaa/base/qbman/bman_driver.c     |   16 -
 drivers/bus/dpaa/base/qbman/process.c         |   94 -
 drivers/bus/dpaa/base/qbman/qman.c            |  778 ----
 drivers/bus/dpaa/base/qbman/qman_priv.h       |    9 -
 drivers/bus/dpaa/dpaa_bus.c                   |   20 -
 drivers/bus/dpaa/include/fsl_bman.h           |   15 -
 drivers/bus/dpaa/include/fsl_fman.h           |   28 -
 drivers/bus/dpaa/include/fsl_qman.h           |  307 --
 drivers/bus/dpaa/include/fsl_usd.h            |   11 -
 drivers/bus/dpaa/include/netcfg.h             |    6 -
 drivers/bus/dpaa/rte_dpaa_bus.h               |   13 -
 drivers/bus/dpaa/version.map                  |   10 -
 drivers/bus/fslmc/fslmc_bus.c                 |   19 -
 drivers/bus/fslmc/mc/dpbp.c                   |  141 -
 drivers/bus/fslmc/mc/dpci.c                   |  320 --
 drivers/bus/fslmc/mc/dpcon.c                  |  241 --
 drivers/bus/fslmc/mc/dpdmai.c                 |  144 -
 drivers/bus/fslmc/mc/dpio.c                   |  191 -
 drivers/bus/fslmc/mc/fsl_dpbp.h               |   20 -
 drivers/bus/fslmc/mc/fsl_dpci.h               |   49 -
 drivers/bus/fslmc/mc/fsl_dpcon.h              |   37 -
 drivers/bus/fslmc/mc/fsl_dpdmai.h             |   20 -
 drivers/bus/fslmc/mc/fsl_dpio.h               |   26 -
 drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c      |    7 -
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h       |    3 -
 .../bus/fslmc/qbman/include/fsl_qbman_debug.h |    2 -
 .../fslmc/qbman/include/fsl_qbman_portal.h    |  463 ---
 drivers/bus/fslmc/qbman/qbman_debug.c         |    5 -
 drivers/bus/fslmc/qbman/qbman_portal.c        |  437 ---
 drivers/bus/fslmc/rte_fslmc.h                 |   10 -
 drivers/bus/fslmc/version.map                 |    6 -
 drivers/bus/ifpga/ifpga_common.c              |   23 -
 drivers/bus/ifpga/ifpga_common.h              |    3 -
 drivers/common/dpaax/dpaa_of.c                |   27 -
 drivers/common/dpaax/dpaa_of.h                |    5 -
 drivers/common/dpaax/dpaax_iova_table.c       |   39 -
 drivers/common/dpaax/dpaax_iova_table.h       |    2 -
 drivers/common/dpaax/version.map              |    1 -
 drivers/common/iavf/iavf_common.c             |  425 ---
 drivers/common/iavf/iavf_prototype.h          |   17 -
 drivers/common/octeontx2/otx2_mbox.c          |   13 -
 drivers/common/octeontx2/otx2_mbox.h          |    1 -
 drivers/crypto/bcmfs/bcmfs_sym_pmd.c          |   19 -
 drivers/crypto/bcmfs/bcmfs_sym_pmd.h          |    3 -
 drivers/crypto/bcmfs/bcmfs_vfio.c             |   24 -
 drivers/crypto/bcmfs/bcmfs_vfio.h             |    4 -
 drivers/crypto/caam_jr/caam_jr_pvt.h          |    1 -
 drivers/crypto/caam_jr/caam_jr_uio.c          |   28 -
 drivers/crypto/ccp/ccp_dev.c                  |   65 -
 drivers/crypto/ccp/ccp_dev.h                  |    8 -
 drivers/crypto/dpaa2_sec/mc/dpseci.c          |  401 --
 drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h      |   52 -
 drivers/crypto/virtio/virtio_pci.c            |   13 -
 drivers/crypto/virtio/virtio_pci.h            |    5 -
 drivers/event/dlb/dlb_priv.h                  |    2 -
 drivers/event/dlb/dlb_xstats.c                |    7 -
 drivers/event/dlb2/dlb2_priv.h                |    2 -
 drivers/event/dlb2/dlb2_xstats.c              |    7 -
 drivers/event/opdl/opdl_ring.c                |  210 --
 drivers/event/opdl/opdl_ring.h                |  236 --
 drivers/net/ark/ark_ddm.c                     |   13 -
 drivers/net/ark/ark_ddm.h                     |    1 -
 drivers/net/ark/ark_pktchkr.c                 |   52 -
 drivers/net/ark/ark_pktchkr.h                 |    3 -
 drivers/net/ark/ark_pktdir.c                  |   22 -
 drivers/net/ark/ark_pktdir.h                  |    3 -
 drivers/net/ark/ark_pktgen.c                  |   27 -
 drivers/net/ark/ark_pktgen.h                  |    2 -
 drivers/net/ark/ark_udm.c                     |   15 -
 drivers/net/ark/ark_udm.h                     |    2 -
 drivers/net/atlantic/hw_atl/hw_atl_b0.c       |   14 -
 drivers/net/atlantic/hw_atl/hw_atl_b0.h       |    2 -
 drivers/net/atlantic/hw_atl/hw_atl_llh.c      |  318 --
 drivers/net/atlantic/hw_atl/hw_atl_llh.h      |  153 -
 drivers/net/atlantic/hw_atl/hw_atl_utils.c    |   36 -
 drivers/net/atlantic/hw_atl/hw_atl_utils.h    |    4 -
 drivers/net/bnx2x/ecore_sp.c                  |   17 -
 drivers/net/bnx2x/ecore_sp.h                  |    2 -
 drivers/net/bnx2x/elink.c                     | 1367 -------
 drivers/net/bnx2x/elink.h                     |   57 -
 drivers/net/bnxt/tf_core/bitalloc.c           |  156 -
 drivers/net/bnxt/tf_core/bitalloc.h           |   26 -
 drivers/net/bnxt/tf_core/stack.c              |   25 -
 drivers/net/bnxt/tf_core/stack.h              |   12 -
 drivers/net/bnxt/tf_core/tf_core.c            |  241 --
 drivers/net/bnxt/tf_core/tf_core.h            |   81 -
 drivers/net/bnxt/tf_core/tf_msg.c             |   40 -
 drivers/net/bnxt/tf_core/tf_msg.h             |   31 -
 drivers/net/bnxt/tf_core/tf_session.c         |   33 -
 drivers/net/bnxt/tf_core/tf_session.h         |   16 -
 drivers/net/bnxt/tf_core/tf_shadow_tbl.c      |   53 -
 drivers/net/bnxt/tf_core/tf_shadow_tbl.h      |   14 -
 drivers/net/bnxt/tf_core/tf_tcam.c            |    7 -
 drivers/net/bnxt/tf_core/tf_tcam.h            |   17 -
 drivers/net/bnxt/tf_core/tfp.c                |   27 -
 drivers/net/bnxt/tf_core/tfp.h                |    4 -
 drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c          |   78 -
 drivers/net/bnxt/tf_ulp/ulp_port_db.c         |   31 -
 drivers/net/bnxt/tf_ulp/ulp_port_db.h         |   14 -
 drivers/net/bnxt/tf_ulp/ulp_utils.c           |   11 -
 drivers/net/bnxt/tf_ulp/ulp_utils.h           |    3 -
 drivers/net/bonding/eth_bond_private.h        |    4 -
 drivers/net/bonding/rte_eth_bond.h            |   38 -
 drivers/net/bonding/rte_eth_bond_api.c        |   39 -
 drivers/net/bonding/rte_eth_bond_pmd.c        |   22 -
 drivers/net/cxgbe/base/common.h               |    5 -
 drivers/net/cxgbe/base/t4_hw.c                |   41 -
 drivers/net/dpaa/fmlib/fm_vsp.c               |   19 -
 drivers/net/dpaa/fmlib/fm_vsp_ext.h           |    3 -
 drivers/net/dpaa2/mc/dpdmux.c                 |  725 ----
 drivers/net/dpaa2/mc/dpni.c                   |  818 +----
 drivers/net/dpaa2/mc/dprtc.c                  |  365 --
 drivers/net/dpaa2/mc/fsl_dpdmux.h             |  108 -
 drivers/net/dpaa2/mc/fsl_dpni.h               |  134 -
 drivers/net/dpaa2/mc/fsl_dprtc.h              |   57 -
 drivers/net/e1000/base/e1000_82542.c          |   97 -
 drivers/net/e1000/base/e1000_82543.c          |   78 -
 drivers/net/e1000/base/e1000_82543.h          |    4 -
 drivers/net/e1000/base/e1000_82571.c          |   35 -
 drivers/net/e1000/base/e1000_82571.h          |    1 -
 drivers/net/e1000/base/e1000_82575.c          |  298 --
 drivers/net/e1000/base/e1000_82575.h          |    8 -
 drivers/net/e1000/base/e1000_api.c            |  530 ---
 drivers/net/e1000/base/e1000_api.h            |   40 -
 drivers/net/e1000/base/e1000_base.c           |   78 -
 drivers/net/e1000/base/e1000_base.h           |    1 -
 drivers/net/e1000/base/e1000_ich8lan.c        |  266 --
 drivers/net/e1000/base/e1000_ich8lan.h        |    3 -
 drivers/net/e1000/base/e1000_mac.c            |   14 -
 drivers/net/e1000/base/e1000_mac.h            |    1 -
 drivers/net/e1000/base/e1000_manage.c         |  192 -
 drivers/net/e1000/base/e1000_manage.h         |    2 -
 drivers/net/e1000/base/e1000_nvm.c            |  129 -
 drivers/net/e1000/base/e1000_nvm.h            |    5 -
 drivers/net/e1000/base/e1000_phy.c            |  201 -
 drivers/net/e1000/base/e1000_phy.h            |    4 -
 drivers/net/e1000/base/e1000_vf.c             |   19 -
 drivers/net/e1000/base/e1000_vf.h             |    1 -
 drivers/net/ena/base/ena_com.c                |  222 --
 drivers/net/ena/base/ena_com.h                |  144 -
 drivers/net/ena/base/ena_eth_com.c            |   11 -
 drivers/net/ena/base/ena_eth_com.h            |    2 -
 drivers/net/fm10k/base/fm10k_api.c            |  104 -
 drivers/net/fm10k/base/fm10k_api.h            |   11 -
 drivers/net/fm10k/base/fm10k_tlv.c            |  183 -
 drivers/net/fm10k/base/fm10k_tlv.h            |    1 -
 drivers/net/i40e/base/i40e_common.c           | 2989 ++-------------
 drivers/net/i40e/base/i40e_dcb.c              |   43 -
 drivers/net/i40e/base/i40e_dcb.h              |    3 -
 drivers/net/i40e/base/i40e_diag.c             |  146 -
 drivers/net/i40e/base/i40e_diag.h             |   30 -
 drivers/net/i40e/base/i40e_lan_hmc.c          |  264 --
 drivers/net/i40e/base/i40e_lan_hmc.h          |    6 -
 drivers/net/i40e/base/i40e_nvm.c              |  988 -----
 drivers/net/i40e/base/i40e_prototype.h        |  202 -
 drivers/net/i40e/base/meson.build             |    1 -
 drivers/net/iavf/iavf.h                       |    2 -
 drivers/net/iavf/iavf_vchnl.c                 |   72 -
 drivers/net/ice/base/ice_acl.c                |  108 -
 drivers/net/ice/base/ice_acl.h                |   13 -
 drivers/net/ice/base/ice_common.c             | 2084 ++---------
 drivers/net/ice/base/ice_common.h             |   70 -
 drivers/net/ice/base/ice_dcb.c                |  161 -
 drivers/net/ice/base/ice_dcb.h                |   11 -
 drivers/net/ice/base/ice_fdir.c               |  262 --
 drivers/net/ice/base/ice_fdir.h               |   16 -
 drivers/net/ice/base/ice_flex_pipe.c          |  103 -
 drivers/net/ice/base/ice_flex_pipe.h          |    4 -
 drivers/net/ice/base/ice_flow.c               |  207 --
 drivers/net/ice/base/ice_flow.h               |   15 -
 drivers/net/ice/base/ice_nvm.c                |  200 -
 drivers/net/ice/base/ice_nvm.h                |    8 -
 drivers/net/ice/base/ice_sched.c              | 1440 +-------
 drivers/net/ice/base/ice_sched.h              |   78 -
 drivers/net/ice/base/ice_switch.c             | 1646 +--------
 drivers/net/ice/base/ice_switch.h             |   62 -
 drivers/net/igc/base/igc_api.c                |  598 ---
 drivers/net/igc/base/igc_api.h                |   41 -
 drivers/net/igc/base/igc_base.c               |   78 -
 drivers/net/igc/base/igc_base.h               |    1 -
 drivers/net/igc/base/igc_hw.h                 |    3 -
 drivers/net/igc/base/igc_i225.c               |  159 -
 drivers/net/igc/base/igc_i225.h               |    4 -
 drivers/net/igc/base/igc_mac.c                |  853 -----
 drivers/net/igc/base/igc_mac.h                |   22 -
 drivers/net/igc/base/igc_manage.c             |  262 --
 drivers/net/igc/base/igc_manage.h             |    4 -
 drivers/net/igc/base/igc_nvm.c                |  679 ----
 drivers/net/igc/base/igc_nvm.h                |   16 -
 drivers/net/igc/base/igc_osdep.c              |   25 -
 drivers/net/igc/base/igc_phy.c                | 3256 +----------------
 drivers/net/igc/base/igc_phy.h                |   49 -
 drivers/net/ionic/ionic.h                     |    2 -
 drivers/net/ionic/ionic_dev.c                 |   39 -
 drivers/net/ionic/ionic_dev.h                 |    4 -
 drivers/net/ionic/ionic_lif.c                 |   11 -
 drivers/net/ionic/ionic_lif.h                 |    1 -
 drivers/net/ionic/ionic_main.c                |   33 -
 drivers/net/ionic/ionic_rx_filter.c           |   14 -
 drivers/net/ionic/ionic_rx_filter.h           |    1 -
 drivers/net/mlx5/mlx5.h                       |    1 -
 drivers/net/mlx5/mlx5_utils.c                 |   21 -
 drivers/net/mlx5/mlx5_utils.h                 |   25 -
 drivers/net/mvneta/mvneta_ethdev.c            |   18 -
 drivers/net/netvsc/hn_rndis.c                 |   31 -
 drivers/net/netvsc/hn_rndis.h                 |    1 -
 drivers/net/netvsc/hn_var.h                   |    3 -
 drivers/net/netvsc/hn_vf.c                    |   25 -
 drivers/net/nfp/nfpcore/nfp_cpp.h             |  213 --
 drivers/net/nfp/nfpcore/nfp_cppcore.c         |  218 --
 drivers/net/nfp/nfpcore/nfp_mip.c             |    6 -
 drivers/net/nfp/nfpcore/nfp_mip.h             |    1 -
 drivers/net/nfp/nfpcore/nfp_mutex.c           |   93 -
 drivers/net/nfp/nfpcore/nfp_nsp.c             |   41 -
 drivers/net/nfp/nfpcore/nfp_nsp.h             |   16 -
 drivers/net/nfp/nfpcore/nfp_nsp_cmds.c        |   79 -
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c         |  206 --
 drivers/net/nfp/nfpcore/nfp_resource.c        |   12 -
 drivers/net/nfp/nfpcore/nfp_resource.h        |    7 -
 drivers/net/nfp/nfpcore/nfp_rtsym.c           |   34 -
 drivers/net/nfp/nfpcore/nfp_rtsym.h           |    4 -
 drivers/net/octeontx/base/octeontx_bgx.c      |   54 -
 drivers/net/octeontx/base/octeontx_bgx.h      |    2 -
 drivers/net/octeontx/base/octeontx_pkivf.c    |   22 -
 drivers/net/octeontx/base/octeontx_pkivf.h    |    1 -
 drivers/net/octeontx2/otx2_ethdev.c           |   26 -
 drivers/net/octeontx2/otx2_ethdev.h           |    3 -
 drivers/net/octeontx2/otx2_ethdev_debug.c     |   55 -
 drivers/net/octeontx2/otx2_flow.h             |    2 -
 drivers/net/octeontx2/otx2_flow_utils.c       |   18 -
 drivers/net/pfe/base/pfe.h                    |   12 -
 drivers/net/pfe/pfe_hal.c                     |  144 -
 drivers/net/pfe/pfe_hif_lib.c                 |   20 -
 drivers/net/pfe/pfe_hif_lib.h                 |    1 -
 drivers/net/qede/base/ecore.h                 |    3 -
 drivers/net/qede/base/ecore_cxt.c             |  229 --
 drivers/net/qede/base/ecore_cxt.h             |   27 -
 drivers/net/qede/base/ecore_dcbx.c            |  266 --
 drivers/net/qede/base/ecore_dcbx_api.h        |   27 -
 drivers/net/qede/base/ecore_dev.c             |  306 --
 drivers/net/qede/base/ecore_dev_api.h         |  127 -
 drivers/net/qede/base/ecore_hw.c              |   16 -
 drivers/net/qede/base/ecore_hw.h              |   10 -
 drivers/net/qede/base/ecore_init_fw_funcs.c   |  616 ----
 drivers/net/qede/base/ecore_init_fw_funcs.h   |  227 --
 drivers/net/qede/base/ecore_int.c             |  193 -
 drivers/net/qede/base/ecore_int.h             |   13 -
 drivers/net/qede/base/ecore_int_api.h         |   60 -
 drivers/net/qede/base/ecore_iov_api.h         |  469 ---
 drivers/net/qede/base/ecore_l2.c              |  103 -
 drivers/net/qede/base/ecore_l2_api.h          |   24 -
 drivers/net/qede/base/ecore_mcp.c             | 1121 +-----
 drivers/net/qede/base/ecore_mcp.h             |   37 -
 drivers/net/qede/base/ecore_mcp_api.h         |  449 ---
 drivers/net/qede/base/ecore_sp_commands.c     |   89 -
 drivers/net/qede/base/ecore_sp_commands.h     |   21 -
 drivers/net/qede/base/ecore_sriov.c           |  767 ----
 drivers/net/qede/base/ecore_vf.c              |   48 -
 drivers/net/qede/base/ecore_vf_api.h          |   40 -
 drivers/net/qede/qede_debug.c                 |  532 ---
 drivers/net/qede/qede_debug.h                 |   97 -
 drivers/net/sfc/sfc_kvargs.c                  |   37 -
 drivers/net/sfc/sfc_kvargs.h                  |    2 -
 drivers/net/softnic/parser.c                  |  218 --
 drivers/net/softnic/parser.h                  |   10 -
 .../net/softnic/rte_eth_softnic_cryptodev.c   |   15 -
 .../net/softnic/rte_eth_softnic_internals.h   |   28 -
 drivers/net/softnic/rte_eth_softnic_thread.c  |  183 -
 drivers/net/txgbe/base/txgbe_eeprom.c         |   72 -
 drivers/net/txgbe/base/txgbe_eeprom.h         |    2 -
 drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
 drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
 drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
 drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
 drivers/raw/ifpga/base/opae_i2c.c             |   12 -
 drivers/raw/ifpga/base/opae_i2c.h             |    4 -
 drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
 drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -
 drivers/regex/mlx5/mlx5_regex.h               |    2 -
 drivers/regex/mlx5/mlx5_regex_fastpath.c      |   25 -
 drivers/regex/mlx5/mlx5_rxp.c                 |   45 -
 .../regex/octeontx2/otx2_regexdev_hw_access.c |   58 -
 .../regex/octeontx2/otx2_regexdev_hw_access.h |    2 -
 drivers/regex/octeontx2/otx2_regexdev_mbox.c  |   28 -
 drivers/regex/octeontx2/otx2_regexdev_mbox.h  |    3 -
 examples/ip_pipeline/cryptodev.c              |    8 -
 examples/ip_pipeline/cryptodev.h              |    3 -
 examples/ip_pipeline/link.c                   |   21 -
 examples/ip_pipeline/link.h                   |    3 -
 examples/ip_pipeline/parser.c                 |  202 -
 examples/ip_pipeline/parser.h                 |    7 -
 examples/pipeline/obj.c                       |   21 -
 examples/pipeline/obj.h                       |    3 -
 lib/librte_eal/linux/eal_memory.c             |    8 -
 lib/librte_vhost/fd_man.c                     |   15 -
 lib/librte_vhost/fd_man.h                     |    2 -
 302 files changed, 833 insertions(+), 38856 deletions(-)
 delete mode 100644 drivers/net/i40e/base/i40e_diag.c
 delete mode 100644 drivers/net/i40e/base/i40e_diag.h
app/test-eventdev/parser.c +0 -88
index 24f1855e9a..131f7383d9 100644
@@ -37,44 +37,6 @@ get_hex_val(char c)
 	}
 }
 
-int
-parser_read_arg_bool(const char *p)
-{
-	p = skip_white_spaces(p);
-	int result = -EINVAL;
-
-	if (((p[0] == 'y') && (p[1] == 'e') && (p[2] == 's')) ||
-		((p[0] == 'Y') && (p[1] == 'E') && (p[2] == 'S'))) {
-		p += 3;
-		result = 1;
-	}
-
-	if (((p[0] == 'o') && (p[1] == 'n')) ||
-		((p[0] == 'O') && (p[1] == 'N'))) {
-		p += 2;
-		result = 1;
-	}
-
-	if (((p[0] == 'n') && (p[1] == 'o')) ||
-		((p[0] == 'N') && (p[1] == 'O'))) {
-		p += 2;
-		result = 0;
-	}
-
-	if (((p[0] == 'o') && (p[1] == 'f') && (p[2] == 'f')) ||
-		((p[0] == 'O') && (p[1] == 'F') && (p[2] == 'F'))) {
-		p += 3;
-		result = 0;
-	}
-
-	p = skip_white_spaces(p);
-
-	if (p[0] != '\0')
-		return -EINVAL;
-
-	return result;
-}
-
 int
 parser_read_uint64(uint64_t *value, const char *p)
 {
@@ -115,24 +77,6 @@ parser_read_uint64(uint64_t *value, const char *p)
 	return 0;
 }
 
-int
-parser_read_int32(int32_t *value, const char *p)
-{
-	char *next;
-	int32_t val;
-
-	p = skip_white_spaces(p);
-	if (!isdigit(*p))
-		return -EINVAL;
-
-	val = strtol(p, &next, 10);
-	if (p == next)
-		return -EINVAL;
-
-	*value = val;
-	return 0;
-}
-
 int
 parser_read_uint64_hex(uint64_t *value, const char *p)
 {
@@ -169,22 +113,6 @@ parser_read_uint32(uint32_t *value, const char *p)
 	return 0;
 }
 
-int
-parser_read_uint32_hex(uint32_t *value, const char *p)
-{
-	uint64_t val = 0;
-	int ret = parser_read_uint64_hex(&val, p);
-
-	if (ret < 0)
-		return ret;
-
-	if (val > UINT32_MAX)
-		return -ERANGE;
-
-	*value = val;
-	return 0;
-}
-
 int
 parser_read_uint16(uint16_t *value, const char *p)
 {
@@ -201,22 +129,6 @@ parser_read_uint16(uint16_t *value, const char *p)
 	return 0;
 }
 
-int
-parser_read_uint16_hex(uint16_t *value, const char *p)
-{
-	uint64_t val = 0;
-	int ret = parser_read_uint64_hex(&val, p);
-
-	if (ret < 0)
-		return ret;
-
-	if (val > UINT16_MAX)
-		return -ERANGE;
-
-	*value = val;
-	return 0;
-}
-
 int
 parser_read_uint8(uint8_t *value, const char *p)
 {
app/test-eventdev/parser.h +0 -6
index 673ff22d78..94856e66e3 100644
@@ -28,20 +28,14 @@ skip_digits(const char *src)
 	return i;
 }
 
-int parser_read_arg_bool(const char *p);
-
 int parser_read_uint64(uint64_t *value, const char *p);
 int parser_read_uint32(uint32_t *value, const char *p);
 int parser_read_uint16(uint16_t *value, const char *p);
 int parser_read_uint8(uint8_t *value, const char *p);
 
 int parser_read_uint64_hex(uint64_t *value, const char *p);
-int parser_read_uint32_hex(uint32_t *value, const char *p);
-int parser_read_uint16_hex(uint16_t *value, const char *p);
 int parser_read_uint8_hex(uint8_t *value, const char *p);
 
-int parser_read_int32(int32_t *value, const char *p);
-
 int parse_hex_string(char *src, uint8_t *dst, uint32_t *size);
 
 int parse_tokenize_string(char *string, char *tokens[], uint32_t *n_tokens);
app/test/test_table_pipeline.c +0 -36
index aabf4375db..4e5926a7c0 100644
@@ -61,46 +61,10 @@ rte_pipeline_port_out_action_handler port_action_stub(struct rte_mbuf **pkts,
 
 #endif
 
-rte_pipeline_table_action_handler_hit
-table_action_0x00(struct rte_pipeline *p, struct rte_mbuf **pkts,
-	uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg);
-
-rte_pipeline_table_action_handler_hit
-table_action_stub_hit(struct rte_pipeline *p, struct rte_mbuf **pkts,
-	uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg);
-
 static int
 table_action_stub_miss(struct rte_pipeline *p, struct rte_mbuf **pkts,
 	uint64_t pkts_mask, struct rte_pipeline_table_entry *entry, void *arg);
 
-rte_pipeline_table_action_handler_hit
-table_action_0x00(__rte_unused struct rte_pipeline *p,
-	__rte_unused struct rte_mbuf **pkts,
-	uint64_t pkts_mask,
-	__rte_unused struct rte_pipeline_table_entry **entry,
-	__rte_unused void *arg)
-{
-	printf("Table Action, setting pkts_mask to 0x00\n");
-	pkts_mask = ~0x00;
-	rte_pipeline_ah_packet_drop(p, pkts_mask);
-	return 0;
-}
-
-rte_pipeline_table_action_handler_hit
-table_action_stub_hit(__rte_unused struct rte_pipeline *p,
-	__rte_unused struct rte_mbuf **pkts,
-	uint64_t pkts_mask,
-	__rte_unused struct rte_pipeline_table_entry **entry,
-	__rte_unused void *arg)
-{
-	printf("STUB Table Action Hit - doing nothing\n");
-	printf("STUB Table Action Hit - setting mask to 0x%"PRIx64"\n",
-		override_hit_mask);
-	pkts_mask = (~override_hit_mask) & 0x3;
-	rte_pipeline_ah_packet_drop(p, pkts_mask);
-	return 0;
-}
-
 static int
 table_action_stub_miss(struct rte_pipeline *p,
 	__rte_unused struct rte_mbuf **pkts,
drivers/bus/dpaa/base/fman/fman_hw.c +0 -182

218 lines not on this page · raw message

drivers/bus/dpaa/base/fman/netcfg_layer.c +0 -11
index b7009f2299..1d6460f1d1 100644
@@ -148,14 +148,3 @@ netcfg_acquire(void)
 
 	return NULL;
 }
-
-void
-netcfg_release(struct netcfg_info *cfg_ptr)
-{
-	rte_free(cfg_ptr);
-	/* Close socket for shared interfaces */
-	if (skfd >= 0) {
-		close(skfd);
-		skfd = -1;
-	}
-}
drivers/bus/dpaa/base/qbman/bman.c +0 -34
index 8a6290734f..95215bb24e 100644
@@ -321,41 +321,7 @@ int bman_acquire(struct bman_pool *pool, struct bm_buffer *bufs, u8 num,
 	return ret;
 }
 
-int bman_query_pools(struct bm_pool_state *state)
-{
-	struct bman_portal *p = get_affine_portal();
-	struct bm_mc_result *mcr;
-
-	bm_mc_start(&p->p);
-	bm_mc_commit(&p->p, BM_MCC_VERB_CMD_QUERY);
-	while (!(mcr = bm_mc_result(&p->p)))
-		cpu_relax();
-	DPAA_ASSERT((mcr->verb & BM_MCR_VERB_CMD_MASK) ==
-		    BM_MCR_VERB_CMD_QUERY);
-	*state = mcr->query;
-	state->as.state.state[0] = be32_to_cpu(state->as.state.state[0]);
-	state->as.state.state[1] = be32_to_cpu(state->as.state.state[1]);
-	state->ds.state.state[0] = be32_to_cpu(state->ds.state.state[0]);
-	state->ds.state.state[1] = be32_to_cpu(state->ds.state.state[1]);
-	return 0;
-}
-
 u32 bman_query_free_buffers(struct bman_pool *pool)
 {
 	return bm_pool_free_buffers(pool->params.bpid);
 }
-
-int bman_update_pool_thresholds(struct bman_pool *pool, const u32 *thresholds)
-{
-	u32 bpid;
-
-	bpid = bman_get_params(pool)->bpid;
-
-	return bm_pool_set(bpid, thresholds);
-}
-
-int bman_shutdown_pool(u32 bpid)
-{
-	struct bman_portal *p = get_affine_portal();
-	return bm_shutdown_pool(&p->p, bpid);
-}
drivers/bus/dpaa/base/qbman/bman_driver.c +0 -16
index 750b756b93..8763ac6215 100644
@@ -109,11 +109,6 @@ static int fsl_bman_portal_finish(void)
 	return ret;
 }
 
-int bman_thread_fd(void)
-{
-	return bmfd;
-}
-
 int bman_thread_init(void)
 {
 	/* Convert from contiguous/virtual cpu numbering to real cpu when
@@ -127,17 +122,6 @@ int bman_thread_finish(void)
 	return fsl_bman_portal_finish();
 }
 
-void bman_thread_irq(void)
-{
-	qbman_invoke_irq(pcfg.irq);
-	/* Now we need to uninhibit interrupts. This is the only code outside
-	 * the regular portal driver that manipulates any portal register, so
-	 * rather than breaking that encapsulation I am simply hard-coding the
-	 * offset to the inhibit register here.
-	 */
-	out_be32(pcfg.addr_virt[DPAA_PORTAL_CI] + 0xe0c, 0);
-}
-
 int bman_init_ccsr(const struct device_node *node)
 {
 	static int ccsr_map_fd;
drivers/bus/dpaa/base/qbman/process.c +0 -94

100 lines not on this page · raw message

drivers/bus/dpaa/base/qbman/qman.c +0 -778

876 lines not on this page · raw message

drivers/bus/dpaa/base/qbman/qman_priv.h +0 -9
index 8254729e66..25306804a5 100644
@@ -165,15 +165,6 @@ struct qm_portal_config *qm_get_unused_portal_idx(uint32_t idx);
 void qm_put_unused_portal(struct qm_portal_config *pcfg);
 void qm_set_liodns(struct qm_portal_config *pcfg);
 
-/* This CGR feature is supported by h/w and required by unit-tests and the
- * debugfs hooks, so is implemented in the driver. However it allows an explicit
- * corruption of h/w fields by s/w that are usually incorruptible (because the
- * counters are usually maintained entirely within h/w). As such, we declare
- * this API internally.
- */
-int qman_testwrite_cgr(struct qman_cgr *cgr, u64 i_bcnt,
-		       struct qm_mcr_cgrtestwrite *result);
-
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
 /* If the fq object pointer is greater than the size of context_b field,
  * than a lookup table is required.
drivers/bus/dpaa/dpaa_bus.c +0 -20
index 3098e23093..ca1e27aeaf 100644
@@ -359,11 +359,6 @@ rte_dpaa_portal_fq_init(void *arg, struct qman_fq *fq)
 	return 0;
 }
 
-int rte_dpaa_portal_fq_close(struct qman_fq *fq)
-{
-	return fsl_qman_fq_portal_destroy(fq->qp);
-}
-
 void
 dpaa_portal_finish(void *arg)
 {
@@ -488,21 +483,6 @@ rte_dpaa_driver_register(struct rte_dpaa_driver *driver)
 	driver->dpaa_bus = &rte_dpaa_bus;
 }
 
-/* un-register a dpaa bus based dpaa driver */
-void
-rte_dpaa_driver_unregister(struct rte_dpaa_driver *driver)
-{
-	struct rte_dpaa_bus *dpaa_bus;
-
-	BUS_INIT_FUNC_TRACE();
-
-	dpaa_bus = driver->dpaa_bus;
-
-	TAILQ_REMOVE(&dpaa_bus->driver_list, driver, next);
-	/* Update Bus references */
-	driver->dpaa_bus = NULL;
-}
-
 static int
 rte_dpaa_device_match(struct rte_dpaa_driver *drv,
 		      struct rte_dpaa_device *dev)
drivers/bus/dpaa/include/fsl_bman.h +0 -15
index 82da2fcfe0..a06d29eb2d 100644
@@ -252,8 +252,6 @@ static inline int bman_reserve_bpid(u32 bpid)
 
 void bman_seed_bpid_range(u32 bpid, unsigned int count);
 
-int bman_shutdown_pool(u32 bpid);
-
 /**
  * bman_new_pool - Allocates a Buffer Pool object
  * @params: parameters specifying the buffer pool ID and behaviour
@@ -310,12 +308,6 @@ __rte_internal
 int bman_acquire(struct bman_pool *pool, struct bm_buffer *bufs, u8 num,
 		 u32 flags);
 
-/**
- * bman_query_pools - Query all buffer pool states
- * @state: storage for the queried availability and depletion states
- */
-int bman_query_pools(struct bm_pool_state *state);
-
 /**
  * bman_query_free_buffers - Query how many free buffers are in buffer pool
  * @pool: the buffer pool object to query
@@ -325,13 +317,6 @@ int bman_query_pools(struct bm_pool_state *state);
 __rte_internal
 u32 bman_query_free_buffers(struct bman_pool *pool);
 
-/**
- * bman_update_pool_thresholds - Change the buffer pool's depletion thresholds
- * @pool: the buffer pool object to which the thresholds will be set
- * @thresholds: the new thresholds
- */
-int bman_update_pool_thresholds(struct bman_pool *pool, const u32 *thresholds);
-
 /**
  * bm_pool_set_hw_threshold - Change the buffer pool's thresholds
  * @pool: Pool id
drivers/bus/dpaa/include/fsl_fman.h +0 -28
index a3cf77f0e3..71f5a2f8cf 100644
@@ -64,12 +64,6 @@ void fman_if_stats_reset(struct fman_if *p);
 __rte_internal
 void fman_if_stats_get_all(struct fman_if *p, uint64_t *value, int n);
 
-/* Set ignore pause option for a specific interface */
-void fman_if_set_rx_ignore_pause_frames(struct fman_if *p, bool enable);
-
-/* Set max frame length */
-void fman_if_conf_max_frame_len(struct fman_if *p, unsigned int max_frame_len);
-
 /* Enable/disable Rx promiscuous mode on specified interface */
 __rte_internal
 void fman_if_promiscuous_enable(struct fman_if *p);
@@ -114,18 +108,11 @@ int fman_if_set_fc_quanta(struct fman_if *fm_if, u16 pause_quanta);
 __rte_internal
 void fman_if_set_err_fqid(struct fman_if *fm_if, uint32_t err_fqid);
 
-/* Get IC transfer params */
-int fman_if_get_ic_params(struct fman_if *fm_if, struct fman_if_ic_params *icp);
-
 /* Set IC transfer params */
 __rte_internal
 int fman_if_set_ic_params(struct fman_if *fm_if,
 			  const struct fman_if_ic_params *icp);
 
-/* Get interface fd->offset value */
-__rte_internal
-int fman_if_get_fdoff(struct fman_if *fm_if);
-
 /* Set interface fd->offset value */
 __rte_internal
 void fman_if_set_fdoff(struct fman_if *fm_if, uint32_t fd_offset);
@@ -138,20 +125,10 @@ int fman_if_get_sg_enable(struct fman_if *fm_if);
 __rte_internal
 void fman_if_set_sg(struct fman_if *fm_if, int enable);
 
-/* Get interface Max Frame length (MTU) */
-uint16_t fman_if_get_maxfrm(struct fman_if *fm_if);
-
 /* Set interface  Max Frame length (MTU) */
 __rte_internal
 void fman_if_set_maxfrm(struct fman_if *fm_if, uint16_t max_frm);
 
-/* Set interface next invoked action for dequeue operation */
-void fman_if_set_dnia(struct fman_if *fm_if, uint32_t nia);
-
-/* discard error packets on rx */
-__rte_internal
-void fman_if_discard_rx_errors(struct fman_if *fm_if);
-
 __rte_internal
 void fman_if_receive_rx_errors(struct fman_if *fm_if,
 	unsigned int err_eq);
@@ -162,11 +139,6 @@ void fman_if_set_mcast_filter_table(struct fman_if *p);
 __rte_internal
 void fman_if_reset_mcast_filter_table(struct fman_if *p);
 
-int fman_if_add_hash_mac_addr(struct fman_if *p, uint8_t *eth);
-
-int fman_if_get_primary_mac_addr(struct fman_if *p, uint8_t *eth);
-
-
 /* Enable/disable Rx on all interfaces */
 static inline void fman_if_enable_all_rx(void)
 {
drivers/bus/dpaa/include/fsl_qman.h +0 -307

385 lines not on this page · raw message

drivers/bus/dpaa/include/fsl_usd.h +0 -11
index dcf35e4adb..3a5df9bf7e 100644
@@ -51,16 +51,9 @@ struct dpaa_raw_portal {
 	uint64_t cena;
 };
 
-int qman_allocate_raw_portal(struct dpaa_raw_portal *portal);
-int qman_free_raw_portal(struct dpaa_raw_portal *portal);
-
-int bman_allocate_raw_portal(struct dpaa_raw_portal *portal);
-int bman_free_raw_portal(struct dpaa_raw_portal *portal);
-
 /* Obtain thread-local UIO file-descriptors */
 __rte_internal
 int qman_thread_fd(void);
-int bman_thread_fd(void);
 
 /* Post-process interrupts. NB, the kernel IRQ handler disables the interrupt
  * line before notifying us, and this post-processing re-enables it once
@@ -70,12 +63,8 @@ int bman_thread_fd(void);
 __rte_internal
 void qman_thread_irq(void);
 
-__rte_internal
-void bman_thread_irq(void);
 __rte_internal
 void qman_fq_portal_thread_irq(struct qman_portal *qp);
-__rte_internal
-void qman_clear_irq(void);
 
 /* Global setup */
 int qman_global_init(void);
drivers/bus/dpaa/include/netcfg.h +0 -6
index d7d1befd24..815b3ba087 100644
@@ -49,12 +49,6 @@ struct netcfg_interface {
 __rte_internal
 struct netcfg_info *netcfg_acquire(void);
 
-/* cfg_ptr: configuration information pointer.
- * Frees the resources allocated by the configuration layer.
- */
-__rte_internal
-void netcfg_release(struct netcfg_info *cfg_ptr);
-
 #ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
 /* cfg_ptr: configuration information pointer.
  * This function dumps configuration data to stdout.
drivers/bus/dpaa/rte_dpaa_bus.h +0 -13
index 48d5cf4625..40d82412df 100644
@@ -214,16 +214,6 @@ rte_dpaa_mem_vtop(void *vaddr)
 __rte_internal
 void rte_dpaa_driver_register(struct rte_dpaa_driver *driver);
 
-/**
- * Unregister a DPAA driver.
- *
- * @param driver
- *	A pointer to a rte_dpaa_driver structure describing the driver
- *	to be unregistered.
- */
-__rte_internal
-void rte_dpaa_driver_unregister(struct rte_dpaa_driver *driver);
-
 /**
  * Initialize a DPAA portal
  *
@@ -239,9 +229,6 @@ int rte_dpaa_portal_init(void *arg);
 __rte_internal
 int rte_dpaa_portal_fq_init(void *arg, struct qman_fq *fq);
 
-__rte_internal
-int rte_dpaa_portal_fq_close(struct qman_fq *fq);
-
 /**
  * Cleanup a DPAA Portal
  */
drivers/bus/dpaa/version.map +0 -10
index fe4f9ac5aa..98f1e00582 100644
@@ -7,7 +7,6 @@ INTERNAL {
 	bman_new_pool;
 	bman_query_free_buffers;
 	bman_release;
-	bman_thread_irq;
 	dpaa_get_ioctl_version_number;
 	dpaa_get_eth_port_cfg;
 	dpaa_get_qm_channel_caam;
@@ -25,11 +24,9 @@ INTERNAL {
 	fman_if_add_mac_addr;
 	fman_if_clear_mac_addr;
 	fman_if_disable_rx;
-	fman_if_discard_rx_errors;
 	fman_if_enable_rx;
 	fman_if_get_fc_quanta;
 	fman_if_get_fc_threshold;
-	fman_if_get_fdoff;
 	fman_if_get_sg_enable;
 	fman_if_loopback_disable;
 	fman_if_loopback_enable;
@@ -52,19 +49,16 @@ INTERNAL {
 	fman_if_receive_rx_errors;
 	fsl_qman_fq_portal_create;
 	netcfg_acquire;
-	netcfg_release;
 	per_lcore_dpaa_io;
 	qman_alloc_cgrid_range;
 	qman_alloc_fqid_range;
 	qman_alloc_pool_range;
-	qman_clear_irq;
 	qman_create_cgr;
 	qman_create_fq;
 	qman_dca_index;
 	qman_delete_cgr;
 	qman_dequeue;
 	qman_dqrr_consume;
-	qman_enqueue;
 	qman_enqueue_multi;
 	qman_enqueue_multi_fq;
 	qman_ern_poll_free;
@@ -79,7 +73,6 @@ INTERNAL {
 	qman_irqsource_remove;
 	qman_modify_cgr;
 	qman_oos_fq;
-	qman_poll_dqrr;
 	qman_portal_dequeue;
 	qman_portal_poll_rx;
 	qman_query_fq_frm_cnt;
@@ -92,10 +85,7 @@ INTERNAL {
 	qman_static_dequeue_add;
 	qman_thread_fd;
 	qman_thread_irq;
-	qman_volatile_dequeue;
 	rte_dpaa_driver_register;
-	rte_dpaa_driver_unregister;
-	rte_dpaa_portal_fq_close;
 	rte_dpaa_portal_fq_init;
 	rte_dpaa_portal_init;
 
drivers/bus/fslmc/fslmc_bus.c +0 -19
index 58435589b2..51749764e7 100644
@@ -521,25 +521,6 @@ rte_fslmc_driver_register(struct rte_dpaa2_driver *driver)
 	driver->fslmc_bus = &rte_fslmc_bus;
 }
 
-/*un-register a fslmc bus based dpaa2 driver */
-void
-rte_fslmc_driver_unregister(struct rte_dpaa2_driver *driver)
-{
-	struct rte_fslmc_bus *fslmc_bus;
-
-	fslmc_bus = driver->fslmc_bus;
-
-	/* Cleanup the PA->VA Translation table; From whereever this function
-	 * is called from.
-	 */
-	if (rte_eal_iova_mode() == RTE_IOVA_PA)
-		dpaax_iova_table_depopulate();
-
-	TAILQ_REMOVE(&fslmc_bus->driver_list, driver, next);
-	/* Update Bus references */
-	driver->fslmc_bus = NULL;
-}
-
 /*
  * All device has iova as va
  */
drivers/bus/fslmc/mc/dpbp.c +0 -141

159 lines not on this page · raw message

drivers/bus/fslmc/mc/dpci.c +0 -320

335 lines not on this page · raw message

drivers/bus/fslmc/mc/dpcon.c +0 -241

250 lines not on this page · raw message

drivers/bus/fslmc/mc/dpdmai.c +0 -144

131 lines not on this page · raw message

drivers/bus/fslmc/mc/dpio.c +0 -191

191 lines not on this page · raw message

drivers/bus/fslmc/mc/fsl_dpbp.h +0 -20
index 8a021f55f1..f50131ba45 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/mc/fsl_dpci.h +0 -49

49 lines not on this page · raw message

drivers/bus/fslmc/mc/fsl_dpcon.h +0 -37
index 7caa6c68a1..0b3add5d52 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/mc/fsl_dpdmai.h +0 -20
index 19328c00a0..eb1d3c1658 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/mc/fsl_dpio.h +0 -26
index c2db76bdf8..0ddcdb41ec 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c +0 -7
index d9619848d8..06b3e81f26 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/portal/dpaa2_hw_pvt.h +0 -3
index ac24f01451..b72017bd32 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/qbman/include/fsl_qbman_debug.h +0 -2
index 54096e8774..12beb148fb 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h +0 -463

463 lines not on this page · raw message

drivers/bus/fslmc/qbman/qbman_debug.c +0 -5
index 34374ae4b6..2c6a7dcd16 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/qbman/qbman_portal.c +0 -437

437 lines not on this page · raw message

drivers/bus/fslmc/rte_fslmc.h +0 -10
index 37d45dffe5..f6ded1717e 100644

Lines of this file are not shown. View the raw message.

drivers/bus/fslmc/version.map +0 -6
index f44c1a7988..a95c0faa00 100644

Lines of this file are not shown. View the raw message.

drivers/bus/ifpga/ifpga_common.c +0 -23
index 78e2eaee4e..7281b169d0 100644

Lines of this file are not shown. View the raw message.

drivers/bus/ifpga/ifpga_common.h +0 -3
index f9254b9d5d..44381eb78d 100644

Lines of this file are not shown. View the raw message.

drivers/common/dpaax/dpaa_of.c +0 -27
index bb2c8fc66b..ad96eb0b3d 100644

Lines of this file are not shown. View the raw message.

drivers/common/dpaax/dpaa_of.h +0 -5
index aed6bf98b0..0ba3794e9b 100644

Lines of this file are not shown. View the raw message.

drivers/common/dpaax/dpaax_iova_table.c +0 -39
index 91bee65e7b..357e62c164 100644

Lines of this file are not shown. View the raw message.

drivers/common/dpaax/dpaax_iova_table.h +0 -2
index 230fba8ba0..8c3ce45f6a 100644

Lines of this file are not shown. View the raw message.

drivers/common/dpaax/version.map +0 -1
index ee1ca6801c..7390954793 100644

Lines of this file are not shown. View the raw message.

drivers/common/iavf/iavf_common.c +0 -425

425 lines not on this page · raw message

drivers/common/iavf/iavf_prototype.h +0 -17
index f34e77db0f..5d5deacfe2 100644

Lines of this file are not shown. View the raw message.

drivers/common/octeontx2/otx2_mbox.c +0 -13
index 6df1e8ea63..e65fe602f7 100644

Lines of this file are not shown. View the raw message.

drivers/common/octeontx2/otx2_mbox.h +0 -1
index f6d884c198..7d9c018597 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/bcmfs/bcmfs_sym_pmd.c +0 -19
index aa7fad6d70..d23e58ff6d 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/bcmfs/bcmfs_sym_pmd.h +0 -3
index 65d7046090..d9ddd024ff 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/bcmfs/bcmfs_vfio.c +0 -24
index dc2def580f..81994d9d56 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/bcmfs/bcmfs_vfio.h +0 -4
index d0fdf6483f..4177bc1fee 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/caam_jr/caam_jr_pvt.h +0 -1
index 552d6b9b1b..60cf1fa45b 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/caam_jr/caam_jr_uio.c +0 -28
index e4ee102344..60c551e4f2 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/ccp/ccp_dev.c +0 -65

65 lines not on this page · raw message

drivers/crypto/ccp/ccp_dev.h +0 -8
index 37e04218ce..8bfce5d9fb 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/dpaa2_sec/mc/dpseci.c +0 -401

401 lines not on this page · raw message

drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h +0 -52

52 lines not on this page · raw message

drivers/crypto/virtio/virtio_pci.c +0 -13
index ae069794a6..40bd748094 100644

Lines of this file are not shown. View the raw message.

drivers/crypto/virtio/virtio_pci.h +0 -5
index d9a214dfd0..3092b56952 100644

Lines of this file are not shown. View the raw message.

drivers/event/dlb/dlb_priv.h +0 -2
index 58ff4287df..deaf467090 100644

Lines of this file are not shown. View the raw message.

drivers/event/dlb/dlb_xstats.c +0 -7
index 5f4c590307..6678a8b322 100644

Lines of this file are not shown. View the raw message.

drivers/event/dlb2/dlb2_priv.h +0 -2
index b73cf3ff14..56bd4ebe1b 100644

Lines of this file are not shown. View the raw message.

drivers/event/dlb2/dlb2_xstats.c +0 -7
index 8c3c3cda94..574fca89e8 100644

Lines of this file are not shown. View the raw message.

drivers/event/opdl/opdl_ring.c +0 -210

210 lines not on this page · raw message

drivers/event/opdl/opdl_ring.h +0 -236

236 lines not on this page · raw message

drivers/net/ark/ark_ddm.c +0 -13
index 91d1179d88..2a6aa93ffe 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_ddm.h +0 -1
index 5456b4b5cc..5b722b6ede 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_pktchkr.c +0 -52

52 lines not on this page · raw message

drivers/net/ark/ark_pktchkr.h +0 -3
index b362281776..2b0ba17d90 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_pktdir.c +0 -22
index 25e1218310..00bf165bff 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_pktdir.h +0 -3
index 4afd128f95..e7f2026a00 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_pktgen.c +0 -27
index 4a02662a46..9769c46b47 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_pktgen.h +0 -2
index c61dfee6db..cc78577d3d 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_udm.c +0 -15
index a740d36d43..2132f4e972 100644

Lines of this file are not shown. View the raw message.

drivers/net/ark/ark_udm.h +0 -2
index 5846c825b8..7f0d3c2a5e 100644

Lines of this file are not shown. View the raw message.

drivers/net/atlantic/hw_atl/hw_atl_b0.c +0 -14
index 7d0e724019..415099e04a 100644

Lines of this file are not shown. View the raw message.

drivers/net/atlantic/hw_atl/hw_atl_b0.h +0 -2
index d1ba2aceb3..4a155d2bc7 100644

Lines of this file are not shown. View the raw message.

drivers/net/atlantic/hw_atl/hw_atl_llh.c +0 -318

318 lines not on this page · raw message

drivers/net/atlantic/hw_atl/hw_atl_llh.h +0 -153

153 lines not on this page · raw message

drivers/net/atlantic/hw_atl/hw_atl_utils.c +0 -36
index 84d11ab3a5..c94f5112f1 100644

Lines of this file are not shown. View the raw message.

drivers/net/atlantic/hw_atl/hw_atl_utils.h +0 -4
index d8fab010cf..f5e2b472a9 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnx2x/ecore_sp.c +0 -17
index 61f99c6408..7ade8f42d3 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnx2x/ecore_sp.h +0 -2
index d58072dac0..bfb55e8d01 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnx2x/elink.c +0 -1367

1,367 lines not on this page · raw message

drivers/net/bnx2x/elink.h +0 -57

57 lines not on this page · raw message

drivers/net/bnxt/tf_core/bitalloc.c +0 -156

156 lines not on this page · raw message

drivers/net/bnxt/tf_core/bitalloc.h +0 -26
index 2825bb37e5..9ac6eadd81 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/stack.c +0 -25
index 954806377e..bda415e82e 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/stack.h +0 -12
index 6732e03132..7e2f5dfec6 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_core.c +0 -241

241 lines not on this page · raw message

drivers/net/bnxt/tf_core/tf_core.h +0 -81

81 lines not on this page · raw message

drivers/net/bnxt/tf_core/tf_msg.c +0 -40
index 5615eedbbe..e4fe5fe055 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_msg.h +0 -31
index 72bf850487..4483017ada 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_session.c +0 -33
index c95c4bdbd3..912b2837f9 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_session.h +0 -16
index 6a5c894033..37d4703cc1 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_shadow_tbl.c +0 -53

53 lines not on this page · raw message

drivers/net/bnxt/tf_core/tf_shadow_tbl.h +0 -14
index 96a34309b2..bbd8cfd3a9 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_tcam.c +0 -7
index 7679d09eea..e3fec46926 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tf_tcam.h +0 -17
index 280f138dd3..9614cf52c7 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tfp.c +0 -27
index 0f6d63cc00..49ca034241 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_core/tfp.h +0 -4
index 551b9c569f..fc2409371a 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c +0 -78

78 lines not on this page · raw message

drivers/net/bnxt/tf_ulp/ulp_port_db.c +0 -31
index 4b4eaeb126..2d1dbb7e6e 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_ulp/ulp_port_db.h +0 -14
index 7b85987a0c..bd7032004f 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_ulp/ulp_utils.c +0 -11
index a13a3bbf65..b5a4f85fcf 100644

Lines of this file are not shown. View the raw message.

drivers/net/bnxt/tf_ulp/ulp_utils.h +0 -3
index 749ac06d87..a45a2705da 100644

Lines of this file are not shown. View the raw message.

drivers/net/bonding/eth_bond_private.h +0 -4
index 8f198bd50e..e5645a10ab 100644

Lines of this file are not shown. View the raw message.

drivers/net/bonding/rte_eth_bond.h +0 -38
index 874aa91a5f..23a4393f23 100644

Lines of this file are not shown. View the raw message.

drivers/net/bonding/rte_eth_bond_api.c +0 -39
index 55c8e3167c..1c09d2e4ba 100644

Lines of this file are not shown. View the raw message.

drivers/net/bonding/rte_eth_bond_pmd.c +0 -22
index 057b1ada54..d9a0154de1 100644

Lines of this file are not shown. View the raw message.

drivers/net/cxgbe/base/common.h +0 -5
index 8fe8e2a36b..6e360bc42d 100644

Lines of this file are not shown. View the raw message.

drivers/net/cxgbe/base/t4_hw.c +0 -41

41 lines not on this page · raw message

drivers/net/dpaa/fmlib/fm_vsp.c +0 -19
index 78efd93f22..0e261e3d1a 100644

Lines of this file are not shown. View the raw message.

drivers/net/dpaa/fmlib/fm_vsp_ext.h +0 -3
index b51c46162d..97590ea4c0 100644

Lines of this file are not shown. View the raw message.

drivers/net/dpaa2/mc/dpdmux.c +0 -725

725 lines not on this page · raw message

drivers/net/dpaa2/mc/dpni.c +6 -812

818 lines not on this page · raw message

drivers/net/dpaa2/mc/dprtc.c +0 -365

365 lines not on this page · raw message

drivers/net/dpaa2/mc/fsl_dpdmux.h +0 -108

108 lines not on this page · raw message

drivers/net/dpaa2/mc/fsl_dpni.h +0 -134

134 lines not on this page · raw message

drivers/net/dpaa2/mc/fsl_dprtc.h +0 -57

57 lines not on this page · raw message

drivers/net/e1000/base/e1000_82542.c +0 -97

97 lines not on this page · raw message

drivers/net/e1000/base/e1000_82543.c +0 -78

78 lines not on this page · raw message

drivers/net/e1000/base/e1000_82543.h +0 -4
index cf81e4e848..8af412bc77 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_82571.c +0 -35
index 9dc7f6025c..9da1fbf856 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_82571.h +0 -1
index 0d8412678d..3c1840d0e8 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_82575.c +0 -298

298 lines not on this page · raw message

drivers/net/e1000/base/e1000_82575.h +0 -8
index 006b37ae98..03284ca946 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_api.c +0 -530

530 lines not on this page · raw message

drivers/net/e1000/base/e1000_api.h +0 -40
index 6b38e2b7bb..1c240dfcdf 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_base.c +0 -78

78 lines not on this page · raw message

drivers/net/e1000/base/e1000_base.h +0 -1
index 0d6172b6d8..16d7ca98a7 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_ich8lan.c +0 -266

266 lines not on this page · raw message

drivers/net/e1000/base/e1000_ich8lan.h +0 -3
index e456e5132e..e28ebb55ba 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_mac.c +0 -14
index d3b3a6bac9..fe1516bd92 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_mac.h +0 -1
index 86fcad23bb..0abaf2f452 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_manage.c +0 -192

192 lines not on this page · raw message

drivers/net/e1000/base/e1000_manage.h +0 -2
index 268a13381d..da0246b6a9 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_nvm.c +0 -129

129 lines not on this page · raw message

drivers/net/e1000/base/e1000_nvm.h +0 -5
index 056f823537..e48d638795 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_phy.c +0 -201

201 lines not on this page · raw message

drivers/net/e1000/base/e1000_phy.h +0 -4
index 81c5308589..fcd1e09f42 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_vf.c +0 -19
index 44ebe07ee4..9b001f9c2e 100644

Lines of this file are not shown. View the raw message.

drivers/net/e1000/base/e1000_vf.h +0 -1
index 4bec21c935..ff62970132 100644

Lines of this file are not shown. View the raw message.

drivers/net/ena/base/ena_com.c +0 -222

222 lines not on this page · raw message

drivers/net/ena/base/ena_com.h +0 -144

144 lines not on this page · raw message

drivers/net/ena/base/ena_eth_com.c +0 -11
index a35d92fbd3..05ab030d07 100644

Lines of this file are not shown. View the raw message.

drivers/net/ena/base/ena_eth_com.h +0 -2
index 7dda16cd9f..3799f08bf4 100644

Lines of this file are not shown. View the raw message.

drivers/net/fm10k/base/fm10k_api.c +0 -104

104 lines not on this page · raw message

drivers/net/fm10k/base/fm10k_api.h +0 -11
index d9593bba00..4ffe41cd08 100644

Lines of this file are not shown. View the raw message.

drivers/net/fm10k/base/fm10k_tlv.c +0 -183

183 lines not on this page · raw message

drivers/net/fm10k/base/fm10k_tlv.h +0 -1
index af2e4c76a3..1665709d3d 100644

Lines of this file are not shown. View the raw message.

drivers/net/i40e/base/i40e_common.c +224 -2765

2,989 lines not on this page · raw message

drivers/net/i40e/base/i40e_dcb.c +0 -43

43 lines not on this page · raw message

drivers/net/i40e/base/i40e_dcb.h +0 -3
index 0409fd3e1a..01c1d8af11 100644

Lines of this file are not shown. View the raw message.

drivers/net/i40e/base/i40e_diag.c deleted +0 -146

146 lines not on this page · raw message

drivers/net/i40e/base/i40e_diag.h deleted +0 -30
deleted file mode 100644
index cb59285d9c..0000000000

Lines of this file are not shown. View the raw message.

drivers/net/i40e/base/i40e_lan_hmc.c +0 -264

264 lines not on this page · raw message

drivers/net/i40e/base/i40e_lan_hmc.h +0 -6
index aa5dceb792..1d2707e5ad 100644

Lines of this file are not shown. View the raw message.

drivers/net/i40e/base/i40e_nvm.c +0 -988

988 lines not on this page · raw message

drivers/net/i40e/base/i40e_prototype.h +0 -202

202 lines not on this page · raw message

drivers/net/i40e/base/meson.build +0 -1
index 8bc6a0fa0b..1a07449fa5 100644

Lines of this file are not shown. View the raw message.

drivers/net/iavf/iavf.h +0 -2
index 6d5912d8c1..db3dbbda48 100644

Lines of this file are not shown. View the raw message.

drivers/net/iavf/iavf_vchnl.c +0 -72

72 lines not on this page · raw message

drivers/net/ice/base/ice_acl.c +0 -108

108 lines not on this page · raw message

drivers/net/ice/base/ice_acl.h +0 -13
index 21aa5088f7..ef5a8245a3 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_common.c +296 -1788

2,084 lines not on this page · raw message

drivers/net/ice/base/ice_common.h +0 -70

70 lines not on this page · raw message

drivers/net/ice/base/ice_dcb.c +0 -161

161 lines not on this page · raw message

drivers/net/ice/base/ice_dcb.h +0 -11
index 8f0e09d50a..157845d592 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_fdir.c +0 -262

262 lines not on this page · raw message

drivers/net/ice/base/ice_fdir.h +0 -16
index d363de385d..1f0f5bda7d 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_flex_pipe.c +0 -103

103 lines not on this page · raw message

drivers/net/ice/base/ice_flex_pipe.h +0 -4
index 214c7a2837..257351adfe 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_flow.c +0 -207

207 lines not on this page · raw message

drivers/net/ice/base/ice_flow.h +0 -15
index 2a9ae66454..2675202240 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_nvm.c +0 -200

200 lines not on this page · raw message

drivers/net/ice/base/ice_nvm.h +0 -8
index 8e2eb4df1b..e46562f862 100644

Lines of this file are not shown. View the raw message.

drivers/net/ice/base/ice_sched.c +62 -1378

1,440 lines not on this page · raw message

drivers/net/ice/base/ice_sched.h +0 -78

78 lines not on this page · raw message

drivers/net/ice/base/ice_switch.c +46 -1600

1,646 lines not on this page · raw message

drivers/net/ice/base/ice_switch.h +0 -62

62 lines not on this page · raw message

drivers/net/igc/base/igc_api.c +0 -598

598 lines not on this page · raw message

drivers/net/igc/base/igc_api.h +0 -41

41 lines not on this page · raw message

drivers/net/igc/base/igc_base.c +0 -78

78 lines not on this page · raw message

drivers/net/igc/base/igc_base.h +0 -1
index 5f342af7ee..19b549ae45 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_hw.h +0 -3
index be38fafa5f..55d63b211c 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_i225.c +0 -159

159 lines not on this page · raw message

drivers/net/igc/base/igc_i225.h +0 -4
index c61ece0e82..ff17a2a9c9 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_mac.c +0 -853

853 lines not on this page · raw message

drivers/net/igc/base/igc_mac.h +0 -22
index 035a371e1e..26a88c2014 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_manage.c +0 -262

262 lines not on this page · raw message

drivers/net/igc/base/igc_manage.h +0 -4
index 10cae6d7f8..7070de54df 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_nvm.c +0 -679

679 lines not on this page · raw message

drivers/net/igc/base/igc_nvm.h +0 -16
index 0eee5e4571..e4c1c15f9f 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_osdep.c +0 -25
index 508f2e07ad..22e9471c79 100644

Lines of this file are not shown. View the raw message.

drivers/net/igc/base/igc_phy.c +178 -3078

3,256 lines not on this page · raw message

drivers/net/igc/base/igc_phy.h +0 -49

49 lines not on this page · raw message

drivers/net/ionic/ionic.h +0 -2
index 1538df3092..3536de39e9 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_dev.c +0 -39
index 5c2820b7a1..3700769aab 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_dev.h +0 -4
index 532255a603..dc47f0166a 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_lif.c +0 -11
index 60a5f3d537..9c36090a94 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_lif.h +0 -1
index 425762d652..d66da559f1 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_main.c +0 -33
index 2ade213d2d..2853601f9d 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_rx_filter.c +0 -14
index fe624538df..0c2c937a17 100644

Lines of this file are not shown. View the raw message.

drivers/net/ionic/ionic_rx_filter.h +0 -1
index 6204a7b535..851a56073b 100644

Lines of this file are not shown. View the raw message.

drivers/net/mlx5/mlx5.h +0 -1
index b0c3a2286d..836798a40c 100644

Lines of this file are not shown. View the raw message.

drivers/net/mlx5/mlx5_utils.c +0 -21
index 9889437c56..d607cc4b96 100644

Lines of this file are not shown. View the raw message.

drivers/net/mlx5/mlx5_utils.h +0 -25
index be6e5f67aa..e6cf37c96f 100644

Lines of this file are not shown. View the raw message.

drivers/net/mvneta/mvneta_ethdev.c +0 -18
index 2cd73919ce..afda8f2a50 100644

Lines of this file are not shown. View the raw message.

drivers/net/netvsc/hn_rndis.c +0 -31
index 1ce260c89b..beb716f3c9 100644

Lines of this file are not shown. View the raw message.

drivers/net/netvsc/hn_rndis.h +0 -1
index 9a8251fc2f..11b89042dd 100644

Lines of this file are not shown. View the raw message.

drivers/net/netvsc/hn_var.h +0 -3
index bd874c6b4d..1fa8a50c1b 100644

Lines of this file are not shown. View the raw message.

drivers/net/netvsc/hn_vf.c +0 -25
index d43ebaa69f..996324282b 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_cpp.h +0 -213

213 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_cppcore.c +0 -218

218 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_mip.c +0 -6
index c86966df8b..d67ff220eb 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_mip.h +0 -1
index d0919b58fe..27300ba9cd 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_mutex.c +0 -93

93 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_nsp.c +0 -41

41 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_nsp.h +0 -16
index c9c7b0d0fb..66cad416da 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_nsp_cmds.c +0 -79

79 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_nsp_eth.c +0 -206

206 lines not on this page · raw message

drivers/net/nfp/nfpcore/nfp_resource.c +0 -12
index dd41fa4de4..2a07a8e411 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_resource.h +0 -7
index 06cc6f74f4..d846402aac 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_rtsym.c +0 -34
index cb7d83db51..b02063f3b9 100644

Lines of this file are not shown. View the raw message.

drivers/net/nfp/nfpcore/nfp_rtsym.h +0 -4
index 8b494211bc..c63bc05fff 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx/base/octeontx_bgx.c +0 -54

54 lines not on this page · raw message

drivers/net/octeontx/base/octeontx_bgx.h +0 -2
index d126a0b7fc..fc61168b62 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx/base/octeontx_pkivf.c +0 -22
index 0ddff54886..30528c269e 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx/base/octeontx_pkivf.h +0 -1
index d41eaa57ed..06c409225f 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx2/otx2_ethdev.c +0 -26
index 6cebbe677d..b8f9eb188f 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx2/otx2_ethdev.h +0 -3
index 3b9871f4dc..f0ed59d89a 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx2/otx2_ethdev_debug.c +0 -55

55 lines not on this page · raw message

drivers/net/octeontx2/otx2_flow.h +0 -2
index 30a823c8a7..e390629b2f 100644

Lines of this file are not shown. View the raw message.

drivers/net/octeontx2/otx2_flow_utils.c +0 -18
index 9a0a5f9fb4..79541c86c0 100644

Lines of this file are not shown. View the raw message.

drivers/net/pfe/base/pfe.h +0 -12
index 0a88e98c1b..884694985d 100644

Lines of this file are not shown. View the raw message.

drivers/net/pfe/pfe_hal.c +0 -144

144 lines not on this page · raw message

drivers/net/pfe/pfe_hif_lib.c +0 -20
index 799050dce3..83edbd64fc 100644

Lines of this file are not shown. View the raw message.

drivers/net/pfe/pfe_hif_lib.h +0 -1
index d7c0606943..c89c8fed74 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore.h +0 -3
index 6c8e6d4072..b86674fdff 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_cxt.c +0 -229

229 lines not on this page · raw message

drivers/net/qede/base/ecore_cxt.h +0 -27
index 1a539bbc71..dc5f49ef57 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_dcbx.c +0 -266

266 lines not on this page · raw message

drivers/net/qede/base/ecore_dcbx_api.h +0 -27
index 6fad2ecc2e..5d7cd1b48b 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_dev.c +0 -306

306 lines not on this page · raw message

drivers/net/qede/base/ecore_dev_api.h +0 -127

127 lines not on this page · raw message

drivers/net/qede/base/ecore_hw.c +0 -16
index 1db39d6a36..881682df25 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_hw.h +0 -10
index 238bdb9dbc..e1042eefec 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_init_fw_funcs.c +0 -616

616 lines not on this page · raw message

drivers/net/qede/base/ecore_init_fw_funcs.h +0 -227

227 lines not on this page · raw message

drivers/net/qede/base/ecore_int.c +0 -193

193 lines not on this page · raw message

drivers/net/qede/base/ecore_int.h +0 -13
index 5042cd1d18..83ab4c9a97 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_int_api.h +0 -60

60 lines not on this page · raw message

drivers/net/qede/base/ecore_iov_api.h +0 -469

469 lines not on this page · raw message

drivers/net/qede/base/ecore_l2.c +0 -103

103 lines not on this page · raw message

drivers/net/qede/base/ecore_l2_api.h +0 -24
index bebf412edb..0f2baedc3e 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_mcp.c +21 -1100

1,121 lines not on this page · raw message

drivers/net/qede/base/ecore_mcp.h +0 -37
index 185cc23394..7dda431d99 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_mcp_api.h +0 -449

449 lines not on this page · raw message

drivers/net/qede/base/ecore_sp_commands.c +0 -89

89 lines not on this page · raw message

drivers/net/qede/base/ecore_sp_commands.h +0 -21
index 524fe57a14..7d9ec82c7c 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/base/ecore_sriov.c +0 -767

767 lines not on this page · raw message

drivers/net/qede/base/ecore_vf.c +0 -48

48 lines not on this page · raw message

drivers/net/qede/base/ecore_vf_api.h +0 -40
index 43951a9a34..68286355bf 100644

Lines of this file are not shown. View the raw message.

drivers/net/qede/qede_debug.c +0 -532

532 lines not on this page · raw message

drivers/net/qede/qede_debug.h +0 -97

97 lines not on this page · raw message

drivers/net/sfc/sfc_kvargs.c +0 -37
index 13e9665bb4..6513c6db81 100644

Lines of this file are not shown. View the raw message.

drivers/net/sfc/sfc_kvargs.h +0 -2
index 0c3660890c..e39f1191a9 100644

Lines of this file are not shown. View the raw message.

drivers/net/softnic/parser.c +0 -218

218 lines not on this page · raw message

drivers/net/softnic/parser.h +0 -10
index 6f408b2485..2c14af32dd 100644

Lines of this file are not shown. View the raw message.

drivers/net/softnic/rte_eth_softnic_cryptodev.c +0 -15
index a1a4ca5650..0198e1e35d 100644

Lines of this file are not shown. View the raw message.

drivers/net/softnic/rte_eth_softnic_internals.h +0 -28
index 9c8737c9e2..414b79e068 100644

Lines of this file are not shown. View the raw message.

drivers/net/softnic/rte_eth_softnic_thread.c +0 -183

183 lines not on this page · raw message

drivers/net/txgbe/base/txgbe_eeprom.c +0 -72

72 lines not on this page · raw message

drivers/net/txgbe/base/txgbe_eeprom.h +0 -2
index d0e142dba5..78b8af978b 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_eth_group.c +0 -25
index be28954e05..97c20a8068 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_eth_group.h +0 -1
index 4868bd0e11..8dc23663b8 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_hw_api.c +0 -212

212 lines not on this page · raw message

drivers/raw/ifpga/base/opae_hw_api.h +0 -36
index e99ee4564c..32b603fc8a 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_i2c.c +0 -12
index 598eab5742..5ea7ca3672 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_i2c.h +0 -4
index 4f6b0b28bb..a21277b7cc 100644

Lines of this file are not shown. View the raw message.

drivers/raw/ifpga/base/opae_ifpga_hw_api.c +0 -99

99 lines not on this page · raw message

drivers/raw/ifpga/base/opae_ifpga_hw_api.h +0 -15
index bab33862ee..104ab97edc 100644

Lines of this file are not shown. View the raw message.

drivers/regex/mlx5/mlx5_regex.h +0 -2
index 2c4877c37d..1ef5cfbda0 100644

Lines of this file are not shown. View the raw message.

drivers/regex/mlx5/mlx5_regex_fastpath.c +0 -25
index 254954776f..f38a3772cb 100644

Lines of this file are not shown. View the raw message.

drivers/regex/mlx5/mlx5_rxp.c +0 -45

45 lines not on this page · raw message

drivers/regex/octeontx2/otx2_regexdev_hw_access.c +0 -58

58 lines not on this page · raw message

drivers/regex/octeontx2/otx2_regexdev_hw_access.h +0 -2
index dedf5f3282..4733febc0e 100644

Lines of this file are not shown. View the raw message.

drivers/regex/octeontx2/otx2_regexdev_mbox.c +0 -28
index 6d58d367d4..726994e195 100644

Lines of this file are not shown. View the raw message.

drivers/regex/octeontx2/otx2_regexdev_mbox.h +0 -3
index 953efa6724..c36e6a5b7a 100644

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/cryptodev.c +0 -8
index b0d9f3d217..4c986e421d 100644

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/cryptodev.h +0 -3
index d00434379e..c91b8a69f7 100644

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/link.c +0 -21
index 16bcffe356..d09609b9e9 100644

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/link.h +0 -3
index 34ff1149e0..a4f6aa0e73 100644

Lines of this file are not shown. View the raw message.

examples/ip_pipeline/parser.c +0 -202

202 lines not on this page · raw message

examples/ip_pipeline/parser.h +0 -7
index 4538f675d4..826ed8d136 100644

Lines of this file are not shown. View the raw message.

examples/pipeline/obj.c +0 -21
index 84bbcf2b2d..424f281213 100644

Lines of this file are not shown. View the raw message.

examples/pipeline/obj.h +0 -3
index e6351fd279..3d729e43b0 100644

Lines of this file are not shown. View the raw message.

lib/librte_eal/linux/eal_memory.c +0 -8
index 03a4f2dd2d..4480e5249a 100644

Lines of this file are not shown. View the raw message.

lib/librte_vhost/fd_man.c +0 -15
index 55d4856f9e..942c5f145b 100644

Lines of this file are not shown. View the raw message.

lib/librte_vhost/fd_man.h +0 -2
index 3ab5cfdd60..f0157eeeed 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.26.2

Part of the diff is not shown here. View the raw message.

Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 111 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Thursday, November 19, 2020 11:53
To: Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Zhang, Tianfei <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: Yigit, Ferruh <[email protected]>; [email protected]
Subject: [RFC] remove unused functions

Removing unused functions, reported by cppcheck.

Easy way to remove clutter, since the code is already in the git repo, they can be added back when needed.

---
 drivers/bus/ifpga/ifpga_common.c              |   23 -
 drivers/bus/ifpga/ifpga_common.h              |    3 -
drivers/bus/ifpga/ifpga_common.c +0 -23
index 78e2eaee4e..7281b169d0 100644
@@ -52,29 +52,6 @@ int rte_ifpga_get_integer32_arg(const char *key
 __rte_unused,
 
 	return 0;
 }
-int ifpga_get_integer64_arg(const char *key __rte_unused,
-	const char *value, void *extra_args)
-{
-	if (!value || !extra_args)
-		return -EINVAL;
-
-	*(uint64_t *)extra_args = strtoull(value, NULL, 0);
-
-	return 0;
-}
-int ifpga_get_unsigned_long(const char *str, int base)
-{
-	unsigned long num;
-	char *end = NULL;
-
-	errno = 0;
-
-	num = strtoul(str, &end, base);
-	if ((str[0] == '\0') || (end == NULL) || (*end != '\0') || (errno != 0))
-		return -1;
-
-	return num;
-}
 
 int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
drivers/bus/ifpga/ifpga_common.c +0 -0
 	const struct rte_afu_id *afu_id1)
drivers/bus/ifpga/ifpga_common.h +0 -3
index f9254b9d5d..44381eb78d 100644
@@ -9,9 +9,6 @@ int rte_ifpga_get_string_arg(const char *key
 __rte_unused,
 	const char *value, void *extra_args);
 int rte_ifpga_get_integer32_arg(const char *key __rte_unused,
 	const char *value, void *extra_args);
-int ifpga_get_integer64_arg(const char *key __rte_unused,
-	const char *value, void *extra_args);
-int ifpga_get_unsigned_long(const char *str, int base);
 int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0,
 	const struct rte_afu_id *afu_id1);
Quoted 1 line

2.26.2

#2 lore raw
In reply to Ferruh Yigit
Quoted 4 lines · On Thu, 19 Nov 2020 03:52:36 +0000 Ferruh Yigit <[email protected]> wrote:
 drivers/net/netvsc/hn_rndis.c                 |   31 -
 drivers/net/netvsc/hn_rndis.h                 |    1 -
 drivers/net/netvsc/hn_var.h                   |    3 -
 drivers/net/netvsc/hn_vf.c                    |   25 -

Thanks this found some real bugs.
1. The get_supported_ptypes is wrong, the driver should just not support it.
2. VF stats need to get reset
3. VX tx_queue release call needs to be added.

Sent tentative patches off for testing.

#3 lore raw
In reply to Ferruh Yigit
Quoted 8 lines
 drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
 drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
 drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
 drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
 drivers/raw/ifpga/base/opae_i2c.c             |   12 -
 drivers/raw/ifpga/base/opae_i2c.h             |    4 -
 drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
 drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

#4 lore raw
Quoted 11 lines · Tianfei
Quoted 8 lines
  drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
  drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
  drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
  drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
  drivers/raw/ifpga/base/opae_i2c.c             |   12 -
  drivers/raw/ifpga/base/opae_i2c.h             |    4 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

The code is hidden behind the driver code, it is not accessible to user directly.

If the idea is the code can be used later, it can be added when needed.

If the idea is the code can be needed in the field by users, can you please give example on the use case?

#5 lore raw
Quoted 13 lines · On Mon, 23 Nov 2020 09:56:51 +0000 Ferruh Yigit <[email protected]> wrote:
Quoted 11 lines · Tianfei
Quoted 8 lines
  drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
  drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
  drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
  drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
  drivers/raw/ifpga/base/opae_i2c.c             |   12 -
  drivers/raw/ifpga/base/opae_i2c.h             |    4 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -  

The ifpga base code is want to provide fully functionality low level hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 6 lines

The code is hidden behind the driver code, it is not accessible to user directly.

If the idea is the code can be used later, it can be added when needed.

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Dead code is buggy code. Please remove it. Maintaining dead code increases the overall technical debt. Dead code is guaranteed not to be tested.

If someone needs it in future they can resurrect it from earlier versions which will always be there in git.

If Intel wants to support it in DPDK then it should provide API's and tests for it.

#6 lore raw
Quoted 76 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: 2020年11月24日 0:07
To: Yigit, Ferruh <[email protected]>
Cc: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [RFC] remove unused functions

Quoted 11 lines · On Mon, 23 Nov 2020 09:56:51 +0000 Ferruh Yigit <[email protected]> wrote:
Quoted 10 lines · Tianfei
Quoted 8 lines
  drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
  drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
  drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
  drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
  drivers/raw/ifpga/base/opae_i2c.c             |   12 -
  drivers/raw/ifpga/base/opae_i2c.h             |    4 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level

hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 3 lines
Quoted 1 line

The code is hidden behind the driver code, it is not accessible to user

directly.

Quoted 5 lines

If the idea is the code can be used later, it can be added when needed.

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Quoted 8 lines

Dead code is buggy code. Please remove it. Maintaining dead code increases the overall technical debt. Dead code is guaranteed not to be tested.

If someone needs it in future they can resurrect it from earlier versions which will always be there in git.

If Intel wants to support it in DPDK then it should provide API's and tests for it.

Yes, I agree with you. I want to write some test cases for ifpga base code.

#7 lore raw
In reply to Ferruh Yigit
Quoted 65 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月23日 17:57
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 10 lines · Tianfei
Quoted 8 lines
  drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
  drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
  drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
  drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
  drivers/raw/ifpga/base/opae_i2c.c             |   12 -
  drivers/raw/ifpga/base/opae_i2c.h             |    4 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
  drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware

support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 1 line
Quoted 3 lines

The code is hidden behind the driver code, it is not accessible to user directly.

If the idea is the code can be used later, it can be added when needed.

Sound good!

Quoted 3 lines

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Do you mean write some test cases in examples folder?

#8 lore raw
Quoted 67 lines · Tianfei
Quoted 67 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月23日 17:57
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 10 lines · Tianfei
Quoted 8 lines
   drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
   drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
   drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
   drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
   drivers/raw/ifpga/base/opae_i2c.c             |   12 -
   drivers/raw/ifpga/base/opae_i2c.h             |    4 -
   drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
   drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware

support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 1 line

The code is hidden behind the driver code, it is not accessible to user directly.

Quoted 9 lines
Quoted 1 line

If the idea is the code can be used later, it can be added when needed.

Sound good!

Quoted 3 lines

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Do you mean write some test cases in examples folder?

You mentioned end user may need some of the removed functions, can you give an example how an end user may need them?

#9 lore raw
Quoted 94 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月24日 18:26
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 9 lines · Tianfei
Quoted 9 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月23日 17:57
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena

<[email protected]>;

Quoted 8 lines
Quoted 8 lines

Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>;

Shahed

Quoted 2 lines
Quoted 2 lines

Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min

Hu

Quoted 6 lines
Quoted 6 lines

(Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao

W

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn

Quoted 15 lines

<[email protected]>;

Quoted 14 lines
Quoted 14 lines

Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 2 lines · Tianfei
Quoted 2 lines
   drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
   drivers/raw/ifpga/base/opae_eth_group.h       |    1 -

For those unused functions on opae_eth_group.c are release functions, like eth_group_release(), it should be called by fme_eth_group_uinit(), I will send a patch to fix it.

Quoted 22 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
   drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
   drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
   drivers/raw/ifpga/base/opae_i2c.c             |   12 -
   drivers/raw/ifpga/base/opae_i2c.h             |    4 -
   drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
   drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware

Quoted 7 lines
Quoted 7 lines

support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 1 line

The code is hidden behind the driver code, it is not accessible to user

directly.

Quoted 5 lines
Quoted 2 lines

If the idea is the code can be used later, it can be added when needed.

Sound good!

Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Do you mean write some test cases in examples folder?

You mentioned end user may need some of the removed functions, can you give an example how an end user may need them?

Currently, there is only one DPDK PMD driver using the ifpga base code, it is called ipn3ke, which is target for VBNG applications.
The ipn3ke is not using all of our APIs which provided by ifpga base code. I am agree remove the unused functions firstly. And I plan to write
an test application to test all of APIs ( including those unused functions ) and add those functions back in future, and I think the test applications should be a good example for the end-user how to use those APIs.

#10 lore raw
Quoted 141 lines · Tianfei
Quoted 94 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月24日 18:26
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 9 lines · Tianfei
Quoted 9 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月23日 17:57
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena

<[email protected]>;

Quoted 8 lines
Quoted 8 lines

Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>;

Shahed

Quoted 2 lines
Quoted 2 lines

Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min

Hu

Quoted 6 lines
Quoted 6 lines

(Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao

W

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn

Quoted 15 lines

<[email protected]>;

Quoted 14 lines
Quoted 14 lines

Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 2 lines · Tianfei
Quoted 2 lines
    drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
    drivers/raw/ifpga/base/opae_eth_group.h       |    1 -

For those unused functions on opae_eth_group.c are release functions, like eth_group_release(), it should be called by fme_eth_group_uinit(), I will send a patch to fix it.

Quoted 28 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
    drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
    drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
    drivers/raw/ifpga/base/opae_i2c.c             |   12 -
    drivers/raw/ifpga/base/opae_i2c.h             |    4 -
    drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
    drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware

Quoted 7 lines
Quoted 7 lines

support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 1 line

The code is hidden behind the driver code, it is not accessible to user

directly.

Quoted 10 lines
Quoted 2 lines

If the idea is the code can be used later, it can be added when needed.

Sound good!

Quoted 3 lines

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Do you mean write some test cases in examples folder?

Quoted 7 lines
Quoted 2 lines

You mentioned end user may need some of the removed functions, can you give an example how an end user may need them?

Currently, there is only one DPDK PMD driver using the ifpga base code, it is called ipn3ke, which is target for VBNG applications.
The ipn3ke is not using all of our APIs which provided by ifpga base code. I am agree remove the unused functions firstly. And I plan to write
an test application to test all of APIs ( including those unused functions ) and add those functions back in future, and I think the test applications should be a good example for the end-user how to use those APIs.

I am not clear how a test application can help to test driver base code functions.

Driver should call them to configure the HW, if there is no DPDK API to request that configuration, or current device doesn't support it, what application can do?

#11 lore raw
Quoted 218 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月24日 19:31
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao W <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn <[email protected]>; Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 9 lines · Tianfei
Quoted 9 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月24日 18:26
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena

<[email protected]>;

Quoted 8 lines
Quoted 8 lines

Ray Kinsella <[email protected]>; Neil Horman <[email protected]>; Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>;

Shahed

Quoted 2 lines
Quoted 2 lines

Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min

Hu

Quoted 6 lines
Quoted 6 lines

(Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Xiao

W

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn

<[email protected]>;

Quoted 21 lines
Quoted 21 lines

Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 9 lines · Tianfei
Quoted 9 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: 2020年11月23日 17:57
To: Zhang, Tianfei <[email protected]>; Jerin Jacob <[email protected]>; Dumitrescu, Cristian <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena

Quoted 2 lines
Quoted 2 lines

<[email protected]>;

Quoted 1 line
Quoted 1 line

Ray Kinsella <[email protected]>; Neil Horman

<[email protected]>;

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines

Xu, Rosen <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Nithin Dabilpuram <[email protected]>; Ajit Khaparde <[email protected]>; Raveendra Padasalagi <[email protected]>; Vikas Gupta <[email protected]>; Gagandeep Singh <[email protected]>; Somalapuram Amaranath <[email protected]>; Akhil Goyal <[email protected]>; Jay Zhou <[email protected]>; McDaniel, Timothy <[email protected]>; Ma, Liang J <[email protected]>; Mccarthy, Peter <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Rasesh Mody <[email protected]>;

Quoted 3 lines
Quoted 3 lines

Shahed

Quoted 2 lines
Quoted 2 lines

Shaikh <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>;

Min

Quoted 4 lines
Quoted 4 lines

Hu

Quoted 3 lines
Quoted 3 lines

(Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas

<[email protected]>;

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Michal Krawczyk <[email protected]>; Guy Tzalik

<[email protected]>;

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Zhang, Qi Z <[email protected]>; Wang,

Xiao

Quoted 21 lines
Quoted 21 lines

W

Quoted 8 lines
Quoted 8 lines

<[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Heinrich Kuhn

<[email protected]>;

Quoted 11 lines
Quoted 11 lines

Harman Kalra <[email protected]>; Kiran Kumar K <[email protected]>; Andrew Rybchenko <[email protected]>; Singh, Jasvinder <[email protected]>; Jiawen Wu <[email protected]>; Jian Wang <[email protected]>; Ori Kam <[email protected]>; Guy Kaneti <[email protected]>; Burakov, Anatoly <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] remove unused functions

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines · Tianfei
Quoted 2 lines
Quoted 2 lines
    drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
    drivers/raw/ifpga/base/opae_eth_group.h       |    1 -

For those unused functions on opae_eth_group.c are release functions, like eth_group_release(), it should be called by fme_eth_group_uinit(), I will

send a patch to fix it.

Quoted 27 lines
Quoted 27 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 7 lines
    drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
    drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
    drivers/raw/ifpga/base/opae_i2c.c             |   12 -
    drivers/raw/ifpga/base/opae_i2c.h             |    4 -
    drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
    drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -

The ifpga base code is want to provide fully functionality low level hardware

Quoted 8 lines
Quoted 8 lines

support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now,but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.

Quoted 1 line

The code is hidden behind the driver code, it is not accessible to user

directly.

Quoted 8 lines
Quoted 2 lines

If the idea is the code can be used later, it can be added when needed.

Sound good!

Quoted 3 lines

If the idea is the code can be needed in the field by users, can you please give example on the use case?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Do you mean write some test cases in examples folder?

You mentioned end user may need some of the removed functions, can you give an example how an end user may need them?

Currently, there is only one DPDK PMD driver using the ifpga base code, it is

called ipn3ke, which is target for VBNG applications.

Quoted 2 lines

The ipn3ke is not using all of our APIs which provided by ifpga base code. I am agree remove the unused functions firstly. And I plan to write an

test application to test all of APIs ( including those unused functions ) and add those functions back in future, and I think the test applications should be a good example for the end-user how to use those APIs.

Quoted 1 line
Quoted 6 lines

I am not clear how a test application can help to test driver base code functions.

Driver should call them to configure the HW, if there is no DPDK API to request that configuration, or current device doesn't support it, what application can do?

My though is write a test rawdev PMD driver and corresponding application which are only for the ifpga APIs testing purpose, I am not sure is it workable?

Reviewed-by on v1 1/1
#12 lore raw
In reply to Ferruh Yigit
Quoted 31 lines · Ferruh Yigit
lib/librte_vhost/fd_man.c +0 -15
index 55d4856f9e..942c5f145b 100644
@@ -100,21 +100,6 @@ fdset_add_fd(struct fdset *pfdset, int idx, int fd,
 	pfd->revents = 0;
 }
 
-void
-fdset_init(struct fdset *pfdset)
-{
-	int i;
-
-	if (pfdset == NULL)
-		return;
-
-	for (i = 0; i < MAX_FDS; i++) {
-		pfdset->fd[i].fd = -1;
-		pfdset->fd[i].dat = NULL;
-	}
-	pfdset->num = 0;
-}
-
 /**
  * Register the fd in the fdset with read/write handler and context.
  */
lib/librte_vhost/fd_man.h +0 -0
index 3ab5cfdd60..f0157eeeed 100644

lib/librte_vhost/fd_man.h struct fdset { · line 44

Quoted 8 lines
lib/librte_vhost/fd_man.h +0 -2
@@ -39,8 +39,6 @@ struct fdset {
 };
 
 
-void fdset_init(struct fdset *pfdset);
-
 int fdset_add(struct fdset *pfdset, int fd,
 	fd_cb rcb, fd_cb wcb, void *dat);
 

For Vhost changes:

For the patch in general, I think it would better be split per driver/lib.

Thanks,
Maxime

Reviewed-by on v1 1/1
#13 lore raw
In reply to Ferruh Yigit
Quoted 127 lines · Ferruh Yigit

Removing unused functions, reported by cppcheck.

Easy way to remove clutter, since the code is already in the git repo, they can be added back when needed.

---
 drivers/net/txgbe/base/txgbe_eeprom.c         |   72 -
 drivers/net/txgbe/base/txgbe_eeprom.h         |    2 -
drivers/net/txgbe/base/txgbe_eeprom.c +0 -36
index 72cd3ff307..fedaecf26d 100644
@@ -274,42 +274,6 @@ s32 txgbe_ee_read32(struct txgbe_hw *hw, u32
 addr, u32 *data)
 	return err;
 }
 
-/**
- *  txgbe_ee_read_buffer - Read EEPROM byte(s) using hostif
- *  @hw: pointer to hardware structure
- *  @addr: offset of bytes in the EEPROM to read
- *  @len: number of bytes
- *  @data: byte(s) read from the EEPROM
- *
- *  Reads a 8 bit byte(s) from the EEPROM using the hostif.
- **/
-s32 txgbe_ee_read_buffer(struct txgbe_hw *hw,
-				     u32 addr, u32 len, void *data)
-{
-	const u32 mask = TXGBE_MNGSEM_SWMBX |
 TXGBE_MNGSEM_SWFLASH;
-	u8 *buf = (u8 *)data;
-	int err;
-
-	err = hw->mac.acquire_swfw_sync(hw, mask);
-	if (err)
-		return err;
-
-	while (len) {
-		u32 seg = (len <= TXGBE_PMMBX_DATA_SIZE
-				? len : TXGBE_PMMBX_DATA_SIZE);
-
-		err = txgbe_hic_sr_read(hw, addr, buf, seg);
-		if (err)
-			break;
-
-		len -= seg;
-		buf += seg;
-	}
-
-	hw->mac.release_swfw_sync(hw, mask);
-	return err;
-}
-
 /**

* txgbe_ee_write - Write EEPROM word using hostif
* @hw: pointer to hardware structure

drivers/net/txgbe/base/txgbe_eeprom.c +0 -36
@@ -420,42 +384,6 @@ s32 txgbe_ee_write32(struct txgbe_hw *hw, u32
 addr, u32 data)
 	return err;
 }
 
-/**
- *  txgbe_ee_write_buffer - Write EEPROM byte(s) using hostif
- *  @hw: pointer to hardware structure
- *  @addr: offset of bytes in the EEPROM to write
- *  @len: number of bytes
- *  @data: word(s) write to the EEPROM
- *
- *  Write a 8 bit byte(s) to the EEPROM using the hostif.
- **/
-s32 txgbe_ee_write_buffer(struct txgbe_hw *hw,
-				      u32 addr, u32 len, void *data)
-{
-	const u32 mask = TXGBE_MNGSEM_SWMBX |
 TXGBE_MNGSEM_SWFLASH;
-	u8 *buf = (u8 *)data;
-	int err;
-
-	err = hw->mac.acquire_swfw_sync(hw, mask);
-	if (err)
-		return err;
-
-	while (len) {
-		u32 seg = (len <= TXGBE_PMMBX_DATA_SIZE
-				? len : TXGBE_PMMBX_DATA_SIZE);
-
-		err = txgbe_hic_sr_write(hw, addr, buf, seg);
-		if (err)
-			break;
-
-		len -= seg;
-		buf += seg;
-	}
-
-	hw->mac.release_swfw_sync(hw, mask);
-	return err;
-}
-
 /**

* txgbe_calc_eeprom_checksum - Calculates and returns the checksum
* @hw: pointer to hardware structure

drivers/net/txgbe/base/txgbe_eeprom.h +0 -2
index d0e142dba5..78b8af978b 100644
@@ -51,14 +51,12 @@ s32 txgbe_ee_readw_sw(struct txgbe_hw *hw, u32
 offset, u16 *data);
 s32 txgbe_ee_readw_buffer(struct txgbe_hw *hw, u32 offset, u32 words,
 				void *data);
 s32 txgbe_ee_read32(struct txgbe_hw *hw, u32 addr, u32 *data);
-s32 txgbe_ee_read_buffer(struct txgbe_hw *hw, u32 addr, u32 len, void
 *data);
 
 s32 txgbe_ee_write16(struct txgbe_hw *hw, u32 offset, u16 data);
 s32 txgbe_ee_writew_sw(struct txgbe_hw *hw, u32 offset, u16 data);
 s32 txgbe_ee_writew_buffer(struct txgbe_hw *hw, u32 offset, u32 words,
 				void *data);
 s32 txgbe_ee_write32(struct txgbe_hw *hw, u32 addr, u32 data);
-s32 txgbe_ee_write_buffer(struct txgbe_hw *hw, u32 addr, u32 len, void
 *data);
Quoted 1 line

#endif /* _TXGBE_EEPROM_H_ */

Thanks.

Acked-by on v1 1/1
#14 lore raw
In reply to Ferruh Yigit
Quoted 7 lines · Ferruh Yigit

Removing unused functions, reported by cppcheck.

Easy way to remove clutter, since the code is already in the git repo, they can be added back when needed.

---

<snip>

Quoted 9 lines
lib/librte_eal/linux/eal_memory.c +0 -1
index 03a4f2dd2d..4480e5249a 100644
@@ -238,14 +238,6 @@ static int huge_wrap_sigsetjmp(void)
  	return sigsetjmp(huge_jmpenv, 1);
  }
 
-#ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES

lib/librte_eal/linux/eal_memory.c static int huge_wrap_sigsetjmp(void) · line 243

Quoted 10 lines
lib/librte_eal/linux/eal_memory.c +0 -7
-/* Callback for numa library. */
-void numa_error(char *where)
-{
-	RTE_LOG(ERR, EAL, "%s failed: %s\n", where, strerror(errno));
-}
-#endif
-
  /*
   * Mmap all hugepages of hugepage table: it first open a file in
   * hugetlbfs, then mmap() hugepage_sz data in it. If orig is set, the

From looking at git history, this function looks to be accidentally added, perhaps an artifact of earlier implementation.

Signature · 2 lines
Thanks,
Anatoly
#15 lore raw
In reply to Ferruh Yigit
Quoted 7 lines · On Thu, 19 Nov 2020 03:52:36 +0000 Ferruh Yigit <[email protected]> wrote:

Removing unused functions, reported by cppcheck.

Easy way to remove clutter, since the code is already in the git repo, they can be added back when needed.

---

Rather than one large patch, could this be split up so individual driver maintainers could Ack that part. Also, would be good if the script to run cppcheck could just look for unused. I.e How to reproduce the result.