Skip to contentSkip to conversation

PCI: dwc/meson: do not fail on wait linkup timeout

PATCH In review Neil Armstrong 4 participants 5 messages Sep 21, 2020 – Nov 19, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: dwc/meson: do not fail on wait linkup timeout

When establish link timeouts, probe fails but the error is unrelated since the PCIe controller has been probed succesfully.

Align with most of the other dw-pcie drivers and ignore return of dw_pcie_wait_for_link() in the host_init callback.

---
 drivers/pci/controller/dwc/pci-meson.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/pci/controller/dwc/pci-meson.c +1 -4
index 33deb290c4e7..846275e68fbc 100644
@@ -383,10 +383,7 @@ static int meson_pcie_host_init(struct pcie_port *pp)
 
 	pp->bridge->ops = &meson_pci_ops;
 
-	ret = meson_pcie_establish_link(mp);
-	if (ret)
-		return ret;
-
+	meson_pcie_establish_link(mp);
 	dw_pcie_msi_init(pp);
 
 	return 0;
Signature · 1 line
2.22.0
reviewer
#2 lore raw
In reply to Neil Armstrong
Quoted 6 lines · Neil Armstrong

When establish link timeouts, probe fails but the error is unrelated since the PCIe controller has been probed succesfully.

Align with most of the other dw-pcie drivers and ignore return of dw_pcie_wait_for_link() in the host_init callback.

I think all, not most DWC drivers should be aligned. Plus the code here is pretty much the same, so I'm working on moving all this to the common DWC code. Drivers that need to bring up the link will need to implement .start_link() (currently only used for EP mode). Most of the time that is just setting the LTSSM bit which Synopsys thought letting every vendor do their own register for was a good idea. Sigh.

Rob

#3 lore raw
Quoted 8 lines · Rob Herring
Quoted 6 lines · Neil Armstrong

When establish link timeouts, probe fails but the error is unrelated since the PCIe controller has been probed succesfully.

Align with most of the other dw-pcie drivers and ignore return of dw_pcie_wait_for_link() in the host_init callback.

Quoted 6 lines

I think all, not most DWC drivers should be aligned. Plus the code here is pretty much the same, so I'm working on moving all this to the common DWC code. Drivers that need to bring up the link will need to implement .start_link() (currently only used for EP mode). Most of the time that is just setting the LTSSM bit which Synopsys thought letting every vendor do their own register for was a good idea. Sigh.

Should I drop this patch then ?

Thanks,
Lorenzo

reviewer
#4 lore raw
Quoted 10 lines · Lorenzo Pieralisi
Quoted 8 lines · Rob Herring
Quoted 6 lines · Neil Armstrong

When establish link timeouts, probe fails but the error is unrelated since the PCIe controller has been probed succesfully.

Align with most of the other dw-pcie drivers and ignore return of dw_pcie_wait_for_link() in the host_init callback.

Quoted 8 lines
Quoted 6 lines

I think all, not most DWC drivers should be aligned. Plus the code here is pretty much the same, so I'm working on moving all this to the common DWC code. Drivers that need to bring up the link will need to implement .start_link() (currently only used for EP mode). Most of the time that is just setting the LTSSM bit which Synopsys thought letting every vendor do their own register for was a good idea. Sigh.

Should I drop this patch then ?

Yes, this is done by my series.

Rob