Skip to contentSkip to conversation

eal/windows: add stub for rte_intr_free_epoll_fd

PATCH Superseded Tal Shnaiderman 3 participants 5 messages Nov 19, 2020 – Dec 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal/windows: add stub for rte_intr_free_epoll_fd

Linux epoll mechanism is not implemented in Windows.

Add stub similarly to freeBSD.

---
 lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
 1 file changed, 6 insertions(+)
lib/librte_eal/windows/eal_interrupts.c +6 -0
index 6c64a48f34..6f7a1c7acc 100644
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
 
 	return 0;
 }
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+	RTE_SET_USED(intr_handle);
+}
Signature · 1 line
2.16.1.windows.4
#1 lore raw
Quoted 15 lines · Tal Shnaiderman

Linux epoll mechanism is not implemented in Windows.

Add stub similarly to freeBSD.

---
 lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
 1 file changed, 6 insertions(+)
lib/librte_eal/windows/eal_interrupts.c +0 -0
index 6c64a48f34..6f7a1c7acc 100644

lib/librte_eal/windows/eal_interrupts.c eal_intr_thread_schedule(void (*func)(void *arg), void *arg) · line 113

Quoted 9 lines
lib/librte_eal/windows/eal_interrupts.c +6 -0
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
 
        return 0;
 }
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+       RTE_SET_USED(intr_handle);
+}

This will not be of much use if you don't export it in rte_eal_exports.def, right?

Signature · 1 line
David Marchand
#2 lore raw
Quoted 26 lines

Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd

External email: Use caution opening links or attachments

Quoted 18 lines · Tal Shnaiderman

Linux epoll mechanism is not implemented in Windows.

Add stub similarly to freeBSD.

---
 lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
 1 file changed, 6 insertions(+)
lib/librte_eal/windows/eal_interrupts.c +0 -0
index 6c64a48f34..6f7a1c7acc 100644
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg),
 void *arg)
 
Quoted 10 lines

lib/librte_eal/windows/eal_interrupts.c eal_intr_thread_schedule(void (*func)(void *arg), void *arg) · line 113

Quoted 7 lines
lib/librte_eal/windows/eal_interrupts.c +5 -0
        return 0;
 }
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) {
+       RTE_SET_USED(intr_handle);
+}

This will not be of much use if you don't export it in rte_eal_exports.def, right?

You're absolutely right, thank you for noticing, I'll send a v2 promptly.

Quoted 3 lines

--
David Marchand

#3 lore raw

PATCH v2 1/1 eal/windows: add stub for rte_intr_free_epoll_fd

In reply to Tal Shnaiderman

Linux epoll mechanism is not implemented in Windows.

Add stub similarly to freeBSD.

---
v2: add missing export in def file [DavidM]

---
 lib/librte_eal/rte_eal_exports.def      | 1 +
 lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
 2 files changed, 7 insertions(+)
lib/librte_eal/rte_eal_exports.def +1 -0
index 6a6be1cfa6..50e6cd3d42 100644
@@ -63,6 +63,7 @@ EXPORTS
 	rte_get_tsc_hz
 	rte_hexdump
 	rte_hypervisor_get
+	rte_intr_free_epoll_fd
 	rte_intr_rx_ctl
 	rte_lcore_count
 	rte_lcore_has_role
lib/librte_eal/windows/eal_interrupts.c +6 -0
index 6c64a48f34..6f7a1c7acc 100644
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
 
 	return 0;
 }
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+	RTE_SET_USED(intr_handle);
+}
Signature · 1 line
2.16.1.windows.4